You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Phabricator (JIRA)" <ji...@apache.org> on 2013/03/01 22:57:13 UTC

[jira] [Updated] (HIVE-4098) OrcInputFormat assumes Hive always calls createValue

     [ https://issues.apache.org/jira/browse/HIVE-4098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Phabricator updated HIVE-4098:
------------------------------

    Attachment: HIVE-4098.D9021.1.patch

omalley requested code review of "HIVE-4098 [jira] OrcInputFormat assumes Hive always calls createValue".

Reviewers: JIRA

hive-4098 remove assumption that only an inputformat's createValue() is used in the next() calls.

Hive's HiveContextAwareRecordReader doesn't create a new value for each InputFormat and instead reuses the same row between input formats. That causes the first record of second (and third, etc.) partition to be dropped and replaced with the last row of the previous partition.

TEST PLAN
  EMPTY

REVISION DETAIL
  https://reviews.facebook.net/D9021

AFFECTED FILES
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java

MANAGE HERALD RULES
  https://reviews.facebook.net/herald/view/differential/

WHY DID I GET THIS EMAIL?
  https://reviews.facebook.net/herald/transcript/21897/

To: JIRA, omalley

                
> OrcInputFormat assumes Hive always calls createValue
> ----------------------------------------------------
>
>                 Key: HIVE-4098
>                 URL: https://issues.apache.org/jira/browse/HIVE-4098
>             Project: Hive
>          Issue Type: Bug
>          Components: Serializers/Deserializers
>            Reporter: Owen O'Malley
>            Assignee: Owen O'Malley
>         Attachments: HIVE-4098.D9021.1.patch
>
>
> Hive's HiveContextAwareRecordReader doesn't create a new value for each InputFormat and instead reuses the same row between input formats. That causes the first record of second (and third, etc.) partition to be dropped and replaced with the last row of the previous partition.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira