You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Adrian Crum (JIRA)" <ji...@apache.org> on 2007/02/06 08:30:05 UTC
[jira] Created: (OFBIZ-691) Fix the layout problem with the recent
Product image patch
Fix the layout problem with the recent Product image patch
----------------------------------------------------------
Key: OFBIZ-691
URL: https://issues.apache.org/jira/browse/OFBIZ-691
Project: OFBiz (The Open for Business Project)
Issue Type: Sub-task
Reporter: Adrian Crum
Priority: Trivial
This is a good example of why some things are handled better in ftl files.
In the absence of a comprehensive style sheet, vertical alignment can be achieved in tables - so the HTML elements need to be put in tables. The attached patch demonstrates how to solve the problem, but it's not a complete solution. I don't know where $labelTitleProperty is defined, so I don't know how to make it work in this patch. Anyways, I hope this helps.
Btw, I removed the sizing properties from the image element. You might as well see the small image actual size - in case it needs to be resized or something.
This layout problem will be solved ultimately with the UI refactoring.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-691) Fix the layout problem with the
recent Product image patch
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12470471 ]
Adrian Crum commented on OFBIZ-691:
-----------------------------------
The point is, Anil and Scott couldn't get the image to appear the way they wanted. I'm offering a "hint" as to how the layout issue can be solved short term. I - like others - am busy working on other things. So, someone else can fill in the missing piece.
If you have been monitoring the dev mailing list, then you would be well aware that I'm aware of the future of OFBiz's UI layout - since you suggested I "champion" the effort. Can't we accept a temporary solution to the problem until the resources are available to solve it long term? (IE table-less layout).
> Fix the layout problem with the recent Product image patch
> ----------------------------------------------------------
>
> Key: OFBIZ-691
> URL: https://issues.apache.org/jira/browse/OFBIZ-691
> Project: OFBiz (The Open for Business Project)
> Issue Type: Sub-task
> Reporter: Adrian Crum
> Assigned To: David E. Jones
> Priority: Trivial
> Attachments: product_img.patch
>
>
> This is a good example of why some things are handled better in ftl files.
> In the absence of a comprehensive style sheet, vertical alignment can be achieved in tables - so the HTML elements need to be put in tables. The attached patch demonstrates how to solve the problem, but it's not a complete solution. I don't know where $labelTitleProperty is defined, so I don't know how to make it work in this patch. Anyways, I hope this helps.
> Btw, I removed the sizing properties from the image element. You might as well see the small image actual size - in case it needs to be resized or something.
> This layout problem will be solved ultimately with the UI refactoring.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-691) Fix the layout problem with the
recent Product image patch
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12470586 ]
Jacques Le Roux commented on OFBIZ-691:
---------------------------------------
Patch in ML sounds like a strange idea. The best in this case should have been simply to ask to reopen the issue, isn't ?
> Fix the layout problem with the recent Product image patch
> ----------------------------------------------------------
>
> Key: OFBIZ-691
> URL: https://issues.apache.org/jira/browse/OFBIZ-691
> Project: OFBiz (The Open for Business Project)
> Issue Type: Sub-task
> Reporter: Adrian Crum
> Assigned To: David E. Jones
> Priority: Trivial
> Attachments: product_img.patch
>
>
> This is a good example of why some things are handled better in ftl files.
> In the absence of a comprehensive style sheet, vertical alignment can be achieved in tables - so the HTML elements need to be put in tables. The attached patch demonstrates how to solve the problem, but it's not a complete solution. I don't know where $labelTitleProperty is defined, so I don't know how to make it work in this patch. Anyways, I hope this helps.
> Btw, I removed the sizing properties from the image element. You might as well see the small image actual size - in case it needs to be resized or something.
> This layout problem will be solved ultimately with the UI refactoring.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-691) Fix the layout problem with the
recent Product image patch
Posted by "Scott Gray (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12470482 ]
Scott Gray commented on OFBIZ-691:
----------------------------------
I haven't looked at this patch, but I would rather not use a table. If a quick fix is desired, I can add a style to the image tag that does have vertical-align: middle like tabupcenter or tabdowncenter, even though they contain other style information it's hidden behind the image anyway.
> Fix the layout problem with the recent Product image patch
> ----------------------------------------------------------
>
> Key: OFBIZ-691
> URL: https://issues.apache.org/jira/browse/OFBIZ-691
> Project: OFBiz (The Open for Business Project)
> Issue Type: Sub-task
> Reporter: Adrian Crum
> Assigned To: David E. Jones
> Priority: Trivial
> Attachments: product_img.patch
>
>
> This is a good example of why some things are handled better in ftl files.
> In the absence of a comprehensive style sheet, vertical alignment can be achieved in tables - so the HTML elements need to be put in tables. The attached patch demonstrates how to solve the problem, but it's not a complete solution. I don't know where $labelTitleProperty is defined, so I don't know how to make it work in this patch. Anyways, I hope this helps.
> Btw, I removed the sizing properties from the image element. You might as well see the small image actual size - in case it needs to be resized or something.
> This layout problem will be solved ultimately with the UI refactoring.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-691) Fix the layout problem with the
recent Product image patch
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12470478 ]
Adrian Crum commented on OFBIZ-691:
-----------------------------------
I understand completely! I wanted to submit this patch to the original issue, but it was closed. My only option was to created this sub-issue.
My hope with this patch is this:
Anil or Scott will apply it to their local copy and see where the missing piece is. They can "fill in the blanks" and commit a revised patch to the project.
In fact, I tried to solve the problem in the widget, but it won't let me nest <div>s. I'm just trying to help within the constraints the project has me locked into.
This issue was flagged as trivial. And for most observers it is. As for Anil and Scott, I'm sure they would like to get this trivial issue resolved. So, this issue is a pointer to the right direction. They can grab the ball and run with it. The rest of the community can ignore it.
I understand your motivation to "push back." I hope this explanation will clarify my intention with this issue.
> Fix the layout problem with the recent Product image patch
> ----------------------------------------------------------
>
> Key: OFBIZ-691
> URL: https://issues.apache.org/jira/browse/OFBIZ-691
> Project: OFBiz (The Open for Business Project)
> Issue Type: Sub-task
> Reporter: Adrian Crum
> Assigned To: David E. Jones
> Priority: Trivial
> Attachments: product_img.patch
>
>
> This is a good example of why some things are handled better in ftl files.
> In the absence of a comprehensive style sheet, vertical alignment can be achieved in tables - so the HTML elements need to be put in tables. The attached patch demonstrates how to solve the problem, but it's not a complete solution. I don't know where $labelTitleProperty is defined, so I don't know how to make it work in this patch. Anyways, I hope this helps.
> Btw, I removed the sizing properties from the image element. You might as well see the small image actual size - in case it needs to be resized or something.
> This layout problem will be solved ultimately with the UI refactoring.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-691) Fix the layout problem with the recent
Product image patch
Posted by "David E. Jones (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David E. Jones closed OFBIZ-691.
--------------------------------
Resolution: Won't Fix
Assignee: David E. Jones
I don't see the point of this patch, as in the comments it sounds like it is ready for commit.
Just an FYI, for the general layout stuff we are moving away from table-based layouts.
> Fix the layout problem with the recent Product image patch
> ----------------------------------------------------------
>
> Key: OFBIZ-691
> URL: https://issues.apache.org/jira/browse/OFBIZ-691
> Project: OFBiz (The Open for Business Project)
> Issue Type: Sub-task
> Reporter: Adrian Crum
> Assigned To: David E. Jones
> Priority: Trivial
> Attachments: product_img.patch
>
>
> This is a good example of why some things are handled better in ftl files.
> In the absence of a comprehensive style sheet, vertical alignment can be achieved in tables - so the HTML elements need to be put in tables. The attached patch demonstrates how to solve the problem, but it's not a complete solution. I don't know where $labelTitleProperty is defined, so I don't know how to make it work in this patch. Anyways, I hope this helps.
> Btw, I removed the sizing properties from the image element. You might as well see the small image actual size - in case it needs to be resized or something.
> This layout problem will be solved ultimately with the UI refactoring.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-691) Fix the layout problem with the
recent Product image patch
Posted by "Chris Howe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12470573 ]
Chris Howe commented on OFBIZ-691:
----------------------------------
Adrian, David
Perhaps this should be a discussion and then vote for community policy, but I would much prefer patches stay in JIRA and not go to the list.
> Fix the layout problem with the recent Product image patch
> ----------------------------------------------------------
>
> Key: OFBIZ-691
> URL: https://issues.apache.org/jira/browse/OFBIZ-691
> Project: OFBiz (The Open for Business Project)
> Issue Type: Sub-task
> Reporter: Adrian Crum
> Assigned To: David E. Jones
> Priority: Trivial
> Attachments: product_img.patch
>
>
> This is a good example of why some things are handled better in ftl files.
> In the absence of a comprehensive style sheet, vertical alignment can be achieved in tables - so the HTML elements need to be put in tables. The attached patch demonstrates how to solve the problem, but it's not a complete solution. I don't know where $labelTitleProperty is defined, so I don't know how to make it work in this patch. Anyways, I hope this helps.
> Btw, I removed the sizing properties from the image element. You might as well see the small image actual size - in case it needs to be resized or something.
> This layout problem will be solved ultimately with the UI refactoring.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-691) Fix the layout problem with the
recent Product image patch
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12470488 ]
Adrian Crum commented on OFBIZ-691:
-----------------------------------
Scott,
I considered that too. But down the road those CSS classes might be deprecated. In other words, whether table layout or tabxxxcenter styles, it will be ultimately refactored.
> Fix the layout problem with the recent Product image patch
> ----------------------------------------------------------
>
> Key: OFBIZ-691
> URL: https://issues.apache.org/jira/browse/OFBIZ-691
> Project: OFBiz (The Open for Business Project)
> Issue Type: Sub-task
> Reporter: Adrian Crum
> Assigned To: David E. Jones
> Priority: Trivial
> Attachments: product_img.patch
>
>
> This is a good example of why some things are handled better in ftl files.
> In the absence of a comprehensive style sheet, vertical alignment can be achieved in tables - so the HTML elements need to be put in tables. The attached patch demonstrates how to solve the problem, but it's not a complete solution. I don't know where $labelTitleProperty is defined, so I don't know how to make it work in this patch. Anyways, I hope this helps.
> Btw, I removed the sizing properties from the image element. You might as well see the small image actual size - in case it needs to be resized or something.
> This layout problem will be solved ultimately with the UI refactoring.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-691) Fix the layout problem with the
recent Product image patch
Posted by "David E. Jones (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12470474 ]
David E. Jones commented on OFBIZ-691:
--------------------------------------
The best approach is probably a comment on the other issue or on the mailing list with your idea. The patch makes a nice example, but shouldn't go in another issue. There seems recently to be a trend toward lots of people reporting problems or requesting things be fixed, but like your message on the mailing list bemoaned, there are too few people actually taking care of things. I'm hoping to balance that out a bit by pushing back on less important issues.
So, here we go...
> Fix the layout problem with the recent Product image patch
> ----------------------------------------------------------
>
> Key: OFBIZ-691
> URL: https://issues.apache.org/jira/browse/OFBIZ-691
> Project: OFBiz (The Open for Business Project)
> Issue Type: Sub-task
> Reporter: Adrian Crum
> Assigned To: David E. Jones
> Priority: Trivial
> Attachments: product_img.patch
>
>
> This is a good example of why some things are handled better in ftl files.
> In the absence of a comprehensive style sheet, vertical alignment can be achieved in tables - so the HTML elements need to be put in tables. The attached patch demonstrates how to solve the problem, but it's not a complete solution. I don't know where $labelTitleProperty is defined, so I don't know how to make it work in this patch. Anyways, I hope this helps.
> Btw, I removed the sizing properties from the image element. You might as well see the small image actual size - in case it needs to be resized or something.
> This layout problem will be solved ultimately with the UI refactoring.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-691) Fix the layout problem with the
recent Product image patch
Posted by "David E. Jones (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12470479 ]
David E. Jones commented on OFBIZ-691:
--------------------------------------
It's no problem Adrian. I hope I didn't rock the boat too much by closing the issue, ie pushing back on it.
BTW, it is possible to nest "div" tags in a screen def by putting container tags under other container tags.
> Fix the layout problem with the recent Product image patch
> ----------------------------------------------------------
>
> Key: OFBIZ-691
> URL: https://issues.apache.org/jira/browse/OFBIZ-691
> Project: OFBiz (The Open for Business Project)
> Issue Type: Sub-task
> Reporter: Adrian Crum
> Assigned To: David E. Jones
> Priority: Trivial
> Attachments: product_img.patch
>
>
> This is a good example of why some things are handled better in ftl files.
> In the absence of a comprehensive style sheet, vertical alignment can be achieved in tables - so the HTML elements need to be put in tables. The attached patch demonstrates how to solve the problem, but it's not a complete solution. I don't know where $labelTitleProperty is defined, so I don't know how to make it work in this patch. Anyways, I hope this helps.
> Btw, I removed the sizing properties from the image element. You might as well see the small image actual size - in case it needs to be resized or something.
> This layout problem will be solved ultimately with the UI refactoring.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-691) Fix the layout problem with the
recent Product image patch
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12470481 ]
Adrian Crum commented on OFBIZ-691:
-----------------------------------
I tried to put a container within a container and Eclipse (or Oxygen or whatever) gave me an error message.
Argh. Now when I try to reproduce it, it works.
You didn't rock the boat - you made a good point. From now on, incomplete patches will go to the mailing list instead of Jira.
Lesson learned. Rodger dodger. Thank you for your patience.
> Fix the layout problem with the recent Product image patch
> ----------------------------------------------------------
>
> Key: OFBIZ-691
> URL: https://issues.apache.org/jira/browse/OFBIZ-691
> Project: OFBiz (The Open for Business Project)
> Issue Type: Sub-task
> Reporter: Adrian Crum
> Assigned To: David E. Jones
> Priority: Trivial
> Attachments: product_img.patch
>
>
> This is a good example of why some things are handled better in ftl files.
> In the absence of a comprehensive style sheet, vertical alignment can be achieved in tables - so the HTML elements need to be put in tables. The attached patch demonstrates how to solve the problem, but it's not a complete solution. I don't know where $labelTitleProperty is defined, so I don't know how to make it work in this patch. Anyways, I hope this helps.
> Btw, I removed the sizing properties from the image element. You might as well see the small image actual size - in case it needs to be resized or something.
> This layout problem will be solved ultimately with the UI refactoring.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-691) Fix the layout problem with the recent
Product image patch
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adrian Crum updated OFBIZ-691:
------------------------------
Attachment: product_img.patch
> Fix the layout problem with the recent Product image patch
> ----------------------------------------------------------
>
> Key: OFBIZ-691
> URL: https://issues.apache.org/jira/browse/OFBIZ-691
> Project: OFBiz (The Open for Business Project)
> Issue Type: Sub-task
> Reporter: Adrian Crum
> Priority: Trivial
> Attachments: product_img.patch
>
>
> This is a good example of why some things are handled better in ftl files.
> In the absence of a comprehensive style sheet, vertical alignment can be achieved in tables - so the HTML elements need to be put in tables. The attached patch demonstrates how to solve the problem, but it's not a complete solution. I don't know where $labelTitleProperty is defined, so I don't know how to make it work in this patch. Anyways, I hope this helps.
> Btw, I removed the sizing properties from the image element. You might as well see the small image actual size - in case it needs to be resized or something.
> This layout problem will be solved ultimately with the UI refactoring.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.