You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by minahlee <gi...@git.apache.org> on 2016/08/30 15:37:01 UTC
[GitHub] zeppelin pull request #1388: [ZEPPELIN-1399] Refactor automatic interpreter ...
GitHub user minahlee opened a pull request:
https://github.com/apache/zeppelin/pull/1388
[ZEPPELIN-1399] Refactor automatic interpreter name insert
### What is this PR for?
Refine automatic interpreter name insert. See below jira issue for detailed description
### What type of PR is it?
Improvement | Refactoring
### What is the Jira issue?
[ZEPPELIN-1399](https://issues.apache.org/jira/browse/ZEPPELIN-1399)
### How should this be tested?
Outline the steps to test the PR here.
### Screenshots (if appropriate)
- Do not insert interpreter name if previous interpreter name is not specified
**Before**
**After**
- Insert interpreter name of previous paragraph without running
**Before**
**After**
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/minahlee/zeppelin ZEPPELIN-1399
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1388.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1388
----
commit a67df081f9cc8178365c08a7eefe55f0850e59e0
Author: Mina Lee <mi...@apache.org>
Date: 2016-08-23T13:40:26Z
Refactor automatic magic keyword insert
commit cb7e83c70f341b3bfec853583bbb2faf2c501030
Author: Mina Lee <mi...@apache.org>
Date: 2016-08-24T07:36:28Z
modify tests
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1388: [ZEPPELIN-1399] Refactor automatic interpreter name in...
Posted by minahlee <gi...@git.apache.org>.
Github user minahlee commented on the issue:
https://github.com/apache/zeppelin/pull/1388
Reverted #1248 during the rebase since this PR already has implemented same functionality in [this line](https://github.com/apache/zeppelin/pull/1388/commits/c777135ea66e80d2ea01e18578eaa6540814c7a7#diff-199a5155679a305a544902edda0c6fb7R584).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1388: [ZEPPELIN-1399] Refactor automatic interpreter name in...
Posted by minahlee <gi...@git.apache.org>.
Github user minahlee commented on the issue:
https://github.com/apache/zeppelin/pull/1388
CI is green. Merge if there is no more discussuion
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1388: [ZEPPELIN-1399] Refactor automatic interpreter name in...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1388
@minahlee For the first case, it is actually the default interpreter.
For example, In Master when you create a new Note you will have '%spark' in the paragraph.
In this Branch, it will stay empty.
Another example would be using: `sc.version` in a paragrah without `%spark`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1388: [ZEPPELIN-1399] Refactor automatic interpreter ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1388
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1388: [ZEPPELIN-1399] Refactor automatic interpreter name in...
Posted by minahlee <gi...@git.apache.org>.
Github user minahlee commented on the issue:
https://github.com/apache/zeppelin/pull/1388
I totally agree that we shouldn't make ux change often. But showing default interpreter in text is implemented only in master branch but not in previous release so I think it won't bring much of confusion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1388: [ZEPPELIN-1399] Refactor automatic interpreter name in...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1388
Tested and LGTM.
Thanks @minahlee for the great improvement.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1388: [ZEPPELIN-1399] Refactor automatic interpreter name in...
Posted by minahlee <gi...@git.apache.org>.
Github user minahlee commented on the issue:
https://github.com/apache/zeppelin/pull/1388
@corneadoug actually I made it empty intentionally. please check out the discussion [here] (https://issues.apache.org/jira/browse/ZEPPELIN-707?focusedCommentId=15358493&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15358493)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1388: [ZEPPELIN-1399] Refactor automatic interpreter name in...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1388
@minahlee Making a new line is a good improvement because some interpreters do not handle same line typing.
For removing the default interpreter, I don't have a strong opinion.
If we plan on having the backend provide the interpreter information in the paragraph and always show it outside of the text editor, we would remove this feature anyway.
However it could feel weird to have Release 0.6.1 have the default interpreter shown, 0.6.2 not showing it, then 0.6.3 or 0.7.0 have Interpreter always shown again but this time as part of the paragraph (not in text editor)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---