You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/07/12 20:26:55 UTC

[GitHub] [arrow] pitrou commented on a diff in pull request #13577: ARROW-17045: [C++] Ignore trailing slashes on files in GCS

pitrou commented on code in PR #13577:
URL: https://github.com/apache/arrow/pull/13577#discussion_r919397212


##########
cpp/src/arrow/filesystem/path_util.cc:
##########
@@ -139,6 +140,13 @@ util::string_view RemoveLeadingSlash(util::string_view key) {
   return key;
 }
 
+Status AssertNoTrailingSlash(const std::string& key) {
+  if (key.back() == '/') {
+    return NotAFile(key);

Review Comment:
   Definitely ok!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org