Re: svn commit: r945280 - in /subversion/trunk: build.conf subversion/libsvn_ra_serf/commit.c subversion/mod_dav_svn/dav_svn.h subversion/mod_dav_svn/posts/ subversion/mod_dav_svn/posts/create-transaction.c subversion/mod_dav_svn/repos.c

[Philip Martin <ph...@wandisco.com>]

cmpilato@apache.org writes:

> Author: cmpilato
> Date: Mon May 17 18:09:28 2010
> New Revision: 945280

> +/* Respond to a S:dated-rev-report request. */
> +int
> +dav_svn__create_transaction_post(const dav_resource *resource,
> +                                 const apr_xml_doc *doc,
> +                                 ap_filter_t *output)
> +{
> +  request_rec *r = resource->info->r;
> +  apr_bucket_brigade *bb;
> +  apr_status_t apr_err;
> +  dav_error *derr = NULL;
> +  const char *txn_name;
> +
> +  /* Create a Subversion repository transaction based on HEAD, and
> +     return the new transaction's name in a custom "201 Created"
> +     response header.  */
> +  derr = dav_svn__create_txn(resource->info->repos, &txn_name, resource->pool);
> +  if (derr)
> +    return dav_svn__error_response_tag(r, derr);
> +
> +  /* We'll set this header only because some early 1.7-dev client
> +     expect it. */
> +  apr_table_set(r->headers_out, SVN_DAV_TXN_NAME_HEADER, txn_name);
> +  r->status = HTTP_CREATED;
> +
> +  bb = apr_brigade_create(resource->pool, output->c->bucket_alloc);
> +  apr_err = ap_fprintf(output, bb,
> +                       DAV_XML_HEADER DEBUG_CR
> +                       "<S:transaction xmlns:S=\"" SVN_XML_NAMESPACE "\""
> +                       ">%ld</S:transaction",
> +                       apr_xml_quote_string(resource->pool, txn_name, 0));

../src/subversion/mod_dav_svn/posts/create-transaction.c:63: warning: format ‘%ld’ expects type ‘long int’, but argument 4 has type ‘const char *’

> +  if (apr_err)
> +    derr = dav_svn__convert_err(svn_error_create(apr_err, 0, NULL),
> +                                HTTP_INTERNAL_SERVER_ERROR,
> +                                "Error writing POST response.",
> +                                resource->pool);
> +      
> +  return dav_svn__final_flush_or_error(r, bb, output, derr, resource->pool);

../src/subversion/mod_dav_svn/posts/create-transaction.c:70: warning: return makes integer from pointer without a cast

> +}
>

-- 
Philip