You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "Gabriel39 (via GitHub)" <gi...@apache.org> on 2025/12/17 11:18:07 UTC
[PR] [refactor](predicate) Refine predicate and unit tests [doris]
Gabriel39 opened a new pull request, #59126:
URL: https://github.com/apache/doris/pull/59126
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](predicate) Refine predicate and unit tests [doris]
Posted by "Gabriel39 (via GitHub)" <gi...@apache.org>.
Gabriel39 commented on PR #59126:
URL: https://github.com/apache/doris/pull/59126#issuecomment-3664886625
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](predicate) Refine predicate and unit tests [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59126:
URL: https://github.com/apache/doris/pull/59126#issuecomment-3665223767
<details>
<summary>ClickBench: <b>Total hot run time: 27.29 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit a8991ea195c4f367e42e922c2fad240976eed8ef, data reload: false
query1 0.06 0.05 0.05
query2 0.10 0.05 0.05
query3 0.26 0.09 0.09
query4 1.61 0.12 0.11
query5 0.28 0.26 0.27
query6 1.16 0.64 0.64
query7 0.04 0.03 0.03
query8 0.06 0.04 0.04
query9 0.56 0.50 0.51
query10 0.54 0.55 0.55
query11 0.16 0.11 0.11
query12 0.15 0.11 0.11
query13 0.61 0.60 0.59
query14 0.98 0.97 0.98
query15 0.81 0.80 0.80
query16 0.39 0.40 0.39
query17 1.08 0.99 1.05
query18 0.24 0.21 0.21
query19 1.91 1.86 1.84
query20 0.02 0.02 0.02
query21 15.44 0.27 0.14
query22 4.85 0.06 0.05
query23 15.99 0.30 0.10
query24 0.98 0.91 0.31
query25 0.12 0.06 0.09
query26 0.14 0.14 0.14
query27 0.08 0.06 0.04
query28 3.86 1.22 1.02
query29 12.58 3.92 3.18
query30 0.28 0.14 0.12
query31 2.81 0.61 0.39
query32 3.24 0.54 0.46
query33 2.96 3.05 3.04
query34 16.97 5.20 4.53
query35 4.59 4.52 4.54
query36 0.66 0.50 0.48
query37 0.11 0.07 0.07
query38 0.08 0.04 0.04
query39 0.05 0.03 0.03
query40 0.17 0.14 0.13
query41 0.09 0.03 0.03
query42 0.04 0.03 0.03
query43 0.04 0.03 0.03
Total cold run time: 97.15 s
Total hot run time: 27.29 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](predicate) Refine predicate and unit tests [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #59126:
URL: https://github.com/apache/doris/pull/59126#issuecomment-3665747371
# BE Regression && UT Coverage Report
Increment line coverage `52.00% (13/25)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/59126_a8991ea195c4f367e42e922c2fad240976eed8ef_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/59126_a8991ea195c4f367e42e922c2fad240976eed8ef_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 72.23% (24954/34550) |
| Line Coverage | 58.97% (261921/444189) |
| Region Coverage | 53.85% (217684/404246) |
| Branch Coverage | 55.36% (93253/168458) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](predicate) Refine predicate and unit tests [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59126:
URL: https://github.com/apache/doris/pull/59126#issuecomment-3665204024
<details>
<summary>TPC-DS: <b>Total hot run time: 177942 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit a8991ea195c4f367e42e922c2fad240976eed8ef, data reload: false
query5 4396 577 454 454
query6 336 223 209 209
query7 4209 462 265 265
query8 300 254 272 254
query9 8733 2528 2524 2524
query10 499 367 314 314
query11 15207 14743 14626 14626
query12 177 111 114 111
query13 1252 496 371 371
query14 5459 3046 2786 2786
query14_1 2714 2660 2673 2660
query15 214 207 183 183
query16 916 447 458 447
query17 1050 702 586 586
query18 2422 433 342 342
query19 221 225 199 199
query20 122 113 108 108
query21 218 136 123 123
query22 3832 4031 3983 3983
query23 16449 16206 15974 15974
query23_1 15963 15999 15958 15958
query24 7321 1671 1228 1228
query24_1 1231 1238 1250 1238
query25 551 485 452 452
query26 1283 287 188 188
query27 2728 453 318 318
query28 4492 2122 2129 2122
query29 817 570 471 471
query30 327 248 220 220
query31 842 687 626 626
query32 80 69 78 69
query33 554 356 306 306
query34 896 903 543 543
query35 785 808 754 754
query36 898 906 806 806
query37 137 101 80 80
query38 2931 2897 2880 2880
query39 773 751 720 720
query39_1 703 700 709 700
query40 232 144 127 127
query41 75 69 68 68
query42 112 105 108 105
query43 438 429 392 392
query44 1320 754 750 750
query45 202 202 187 187
query46 884 991 608 608
query47 1629 1677 1591 1591
query48 323 334 254 254
query49 638 451 379 379
query50 651 295 229 229
query51 3817 3801 3889 3801
query52 111 117 106 106
query53 323 359 300 300
query54 306 274 277 274
query55 83 77 78 77
query56 315 313 315 313
query57 1156 1138 1075 1075
query58 295 273 264 264
query59 2315 2569 2276 2276
query60 332 331 319 319
query61 198 193 189 189
query62 698 662 627 627
query63 331 296 314 296
query64 5124 1350 993 993
query65 4061 3930 3973 3930
query66 1465 455 312 312
query67 15166 14836 14915 14836
query68 7788 1009 722 722
query69 487 347 312 312
query70 1072 986 956 956
query71 364 308 287 287
query72 6210 4929 4883 4883
query73 662 569 306 306
query74 9093 8872 8532 8532
query75 3244 3153 2794 2794
query76 3832 1134 715 715
query77 538 402 296 296
query78 9382 9501 8849 8849
query79 1632 877 607 607
query80 712 671 560 560
query81 496 275 238 238
query82 469 131 105 105
query83 256 254 240 240
query84 298 114 103 103
query85 965 515 475 475
query86 329 295 302 295
query87 3085 3001 3016 3001
query88 4161 2268 2267 2267
query89 477 421 405 405
query90 2157 164 160 160
query91 169 167 148 148
query92 78 73 67 67
query93 1485 918 557 557
query94 486 305 282 282
query95 567 347 361 347
query96 588 482 214 214
query97 2249 2284 2212 2212
query98 219 203 203 203
query99 1283 1301 1204 1204
Total cold run time: 259651 ms
Total hot run time: 177942 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](predicate) Refine predicate and unit tests [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59126:
URL: https://github.com/apache/doris/pull/59126#issuecomment-3665165616
<details>
<summary>TPC-H: <b>Total hot run time: 35110 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit a8991ea195c4f367e42e922c2fad240976eed8ef, data reload: false
------ Round 1 ----------------------------------
q1 17640 4254 4091 4091
q2 2031 360 238 238
q3 10191 1351 742 742
q4 10224 834 310 310
q5 7523 2185 1924 1924
q6 193 176 140 140
q7 1033 861 715 715
q8 9373 1484 1159 1159
q9 7201 5350 5324 5324
q10 6848 2398 1978 1978
q11 519 340 308 308
q12 680 713 580 580
q13 17814 3693 3068 3068
q14 289 313 274 274
q15 618 518 528 518
q16 694 686 631 631
q17 694 830 520 520
q18 7677 7157 6961 6961
q19 1308 975 615 615
q20 405 352 254 254
q21 4264 3857 3799 3799
q22 1040 1006 961 961
Total cold run time: 108259 ms
Total hot run time: 35110 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4158 4041 4050 4041
q2 323 411 311 311
q3 2118 2671 2317 2317
q4 1338 1781 1316 1316
q5 4264 4645 4737 4645
q6 228 178 128 128
q7 2050 1965 1838 1838
q8 2611 2634 2518 2518
q9 7490 7489 7518 7489
q10 3124 3240 2903 2903
q11 601 500 490 490
q12 677 899 658 658
q13 3442 4028 3433 3433
q14 311 328 304 304
q15 551 513 513 513
q16 710 687 645 645
q17 1172 1546 1420 1420
q18 7802 7676 7731 7676
q19 905 850 833 833
q20 1893 1989 1816 1816
q21 4603 4327 4114 4114
q22 1058 1066 964 964
Total cold run time: 51429 ms
Total hot run time: 50372 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](predicate) Refine predicate and unit tests [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #59126:
URL: https://github.com/apache/doris/pull/59126#issuecomment-3667937029
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](predicate) Refine predicate and unit tests [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #59126:
URL: https://github.com/apache/doris/pull/59126#issuecomment-3667912872
# BE Regression && UT Coverage Report
Increment line coverage `52.00% (13/25)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/59126_a8991ea195c4f367e42e922c2fad240976eed8ef_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/59126_a8991ea195c4f367e42e922c2fad240976eed8ef_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 72.23% (24954/34550) |
| Line Coverage | 58.97% (261921/444189) |
| Region Coverage | 53.85% (217684/404246) |
| Branch Coverage | 55.36% (93253/168458) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](predicate) Refine predicate and unit tests [doris]
Posted by "Thearas (via GitHub)" <gi...@apache.org>.
Thearas commented on PR #59126:
URL: https://github.com/apache/doris/pull/59126#issuecomment-3664886334
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](predicate) Refine predicate and unit tests [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59126:
URL: https://github.com/apache/doris/pull/59126#issuecomment-3665421585
# BE UT Coverage Report
Increment line coverage `40.00% (10/25)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/a8991ea195c4f367e42e922c2fad240976eed8ef_a8991ea195c4f367e42e922c2fad240976eed8ef/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/a8991ea195c4f367e42e922c2fad240976eed8ef_a8991ea195c4f367e42e922c2fad240976eed8ef/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 53.38% (18821/35257) |
| Line Coverage | 39.17% (174248/444804) |
| Region Coverage | 33.76% (134893/399619) |
| Branch Coverage | 34.65% (58094/167647) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](predicate) Refine predicate and unit tests [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #59126:
URL: https://github.com/apache/doris/pull/59126#issuecomment-3667936954
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](predicate) Refine predicate and unit tests [doris]
Posted by "Gabriel39 (via GitHub)" <gi...@apache.org>.
Gabriel39 merged PR #59126:
URL: https://github.com/apache/doris/pull/59126
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org