You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Wolfgang Hoschek <wh...@cloudera.com> on 2013/11/04 21:42:22 UTC
Re: Review Request 15107: Moving BlobHandler out of morphline sink and into
HTTP source
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15107/#review28135
-----------------------------------------------------------
flume-ng-sinks/flume-ng-morphline-solr-sink/src/main/java/org/apache/flume/sink/solr/morphline/BlobHandler.java
<https://reviews.apache.org/r/15107/#comment54748>
How about using the same implementation approach as for BlobDeserializer wrt. subclassing, etc?
- Wolfgang Hoschek
On Oct. 31, 2013, 12:48 a.m., Roshan Naik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15107/
> -----------------------------------------------------------
>
> (Updated Oct. 31, 2013, 12:48 a.m.)
>
>
> Review request for Flume.
>
>
> Bugs: FLUME-2226
> https://issues.apache.org/jira/browse/FLUME-2226
>
>
> Repository: flume-git
>
>
> Description
> -------
>
> - Moved BlobHandler out of morphline sink and into HTTP source along with tests.
> - Updated docs to reflect new FQCN
> - Retained dummy class for old FQCN compat
>
>
> Diffs
> -----
>
> flume-ng-core/src/main/java/org/apache/flume/source/http/BlobHandler.java PRE-CREATION
> flume-ng-core/src/test/java/org/apache/flume/source/http/FlumeHttpServletByteRequestWrapper.java PRE-CREATION
> flume-ng-core/src/test/java/org/apache/flume/source/http/TestBlobHandler.java PRE-CREATION
> flume-ng-doc/sphinx/FlumeUserGuide.rst e38bb67
> flume-ng-sinks/flume-ng-morphline-solr-sink/src/main/java/org/apache/flume/sink/solr/morphline/BlobHandler.java e84dec1
> flume-ng-sinks/flume-ng-morphline-solr-sink/src/test/java/org/apache/flume/sink/solr/morphline/FlumeHttpServletRequestWrapper.java 9711a3a
> flume-ng-sinks/flume-ng-morphline-solr-sink/src/test/java/org/apache/flume/sink/solr/morphline/TestBlobHandler.java 3e7de99
>
> Diff: https://reviews.apache.org/r/15107/diff/
>
>
> Testing
> -------
>
> Ran unit tests & some manual Test.
>
>
> Thanks,
>
> Roshan Naik
>
>
Re: Review Request 15107: Moving BlobHandler out of morphline sink and into
HTTP source
Posted by Roshan Naik <ro...@hortonworks.com>.
> On Nov. 4, 2013, 8:42 p.m., Wolfgang Hoschek wrote:
> > flume-ng-sinks/flume-ng-morphline-solr-sink/src/main/java/org/apache/flume/sink/solr/morphline/BlobHandler.java, line 52
> > <https://reviews.apache.org/r/15107/diff/1/?file=374518#file374518line52>
> >
> > How about using the same implementation approach as for BlobDeserializer wrt. subclassing, etc?
yes plan to do it sometime this week.
- Roshan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15107/#review28135
-----------------------------------------------------------
On Oct. 31, 2013, 12:48 a.m., Roshan Naik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15107/
> -----------------------------------------------------------
>
> (Updated Oct. 31, 2013, 12:48 a.m.)
>
>
> Review request for Flume.
>
>
> Bugs: FLUME-2226
> https://issues.apache.org/jira/browse/FLUME-2226
>
>
> Repository: flume-git
>
>
> Description
> -------
>
> - Moved BlobHandler out of morphline sink and into HTTP source along with tests.
> - Updated docs to reflect new FQCN
> - Retained dummy class for old FQCN compat
>
>
> Diffs
> -----
>
> flume-ng-core/src/main/java/org/apache/flume/source/http/BlobHandler.java PRE-CREATION
> flume-ng-core/src/test/java/org/apache/flume/source/http/FlumeHttpServletByteRequestWrapper.java PRE-CREATION
> flume-ng-core/src/test/java/org/apache/flume/source/http/TestBlobHandler.java PRE-CREATION
> flume-ng-doc/sphinx/FlumeUserGuide.rst e38bb67
> flume-ng-sinks/flume-ng-morphline-solr-sink/src/main/java/org/apache/flume/sink/solr/morphline/BlobHandler.java e84dec1
> flume-ng-sinks/flume-ng-morphline-solr-sink/src/test/java/org/apache/flume/sink/solr/morphline/FlumeHttpServletRequestWrapper.java 9711a3a
> flume-ng-sinks/flume-ng-morphline-solr-sink/src/test/java/org/apache/flume/sink/solr/morphline/TestBlobHandler.java 3e7de99
>
> Diff: https://reviews.apache.org/r/15107/diff/
>
>
> Testing
> -------
>
> Ran unit tests & some manual Test.
>
>
> Thanks,
>
> Roshan Naik
>
>
Re: Review Request 15107: Moving BlobHandler out of morphline sink and into
HTTP source
Posted by Wolfgang Hoschek <wh...@cloudera.com>.
> On Nov. 4, 2013, 8:42 p.m., Wolfgang Hoschek wrote:
> > flume-ng-sinks/flume-ng-morphline-solr-sink/src/main/java/org/apache/flume/sink/solr/morphline/BlobHandler.java, line 52
> > <https://reviews.apache.org/r/15107/diff/1/?file=374518#file374518line52>
> >
> > How about using the same implementation approach as for BlobDeserializer wrt. subclassing, etc?
>
> Roshan Naik wrote:
> yes plan to do it sometime this week.
Ah, I now see that TestBlobHandler is already moved over - Pls ignore my prior comment.
- Wolfgang
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15107/#review28135
-----------------------------------------------------------
On Nov. 5, 2013, 1:42 a.m., Roshan Naik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15107/
> -----------------------------------------------------------
>
> (Updated Nov. 5, 2013, 1:42 a.m.)
>
>
> Review request for Flume.
>
>
> Bugs: FLUME-2226
> https://issues.apache.org/jira/browse/FLUME-2226
>
>
> Repository: flume-git
>
>
> Description
> -------
>
> - Moved BlobHandler out of morphline sink and into HTTP source along with tests.
> - Updated docs to reflect new FQCN
> - Retained dummy class for old FQCN compat
>
>
> Diffs
> -----
>
> flume-ng-core/src/main/java/org/apache/flume/source/http/BlobHandler.java PRE-CREATION
> flume-ng-core/src/test/java/org/apache/flume/source/http/FlumeHttpServletByteRequestWrapper.java PRE-CREATION
> flume-ng-core/src/test/java/org/apache/flume/source/http/TestBlobHandler.java PRE-CREATION
> flume-ng-doc/sphinx/FlumeUserGuide.rst 3a3038c
> flume-ng-sinks/flume-ng-morphline-solr-sink/src/main/java/org/apache/flume/sink/solr/morphline/BlobHandler.java e84dec1
> flume-ng-sinks/flume-ng-morphline-solr-sink/src/test/java/org/apache/flume/sink/solr/morphline/FlumeHttpServletRequestWrapper.java 9711a3a
> flume-ng-sinks/flume-ng-morphline-solr-sink/src/test/java/org/apache/flume/sink/solr/morphline/TestBlobHandler.java 3e7de99
>
> Diff: https://reviews.apache.org/r/15107/diff/
>
>
> Testing
> -------
>
> Ran unit tests & some manual Test.
>
>
> Thanks,
>
> Roshan Naik
>
>