[GitHub] [httpcomponents-core] garydgregory commented on a change in pull request #316: HTTPCORE-693 - Add HttpHeaders headers.

[GitBox <gi...@apache.org>]

garydgregory commented on a change in pull request #316:
URL: https://github.com/apache/httpcomponents-core/pull/316#discussion_r742265559



##########
File path: httpcore5/src/main/java/org/apache/hc/core5/http/HttpHeaders.java
##########
@@ -131,6 +143,10 @@ private HttpHeaders() {
     public static final String FROM = "From";
 
     public static final String HOST = "Host";
+    /**
+     * The HTTP {@code HTTP2-Settings} header field name.
+     */
+    public static final String HTTP2_SETTINGS = " HTTP2-Settings";

Review comment:
       Is there really a space?

##########
File path: httpcore5/src/main/java/org/apache/hc/core5/http/HttpHeaders.java
##########
@@ -162,12 +178,20 @@ private HttpHeaders() {
     public static final String OVERWRITE = "Overwrite";
 
     public static final String PRAGMA = "Pragma";
+    /**

Review comment:
       I would add a blank line before a Javadoc comment. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org