[GitHub] [druid] a2l007 commented on a diff in pull request #13815: Improved error message when topic name changes within same supervisor

["a2l007 (via GitHub)" <gi...@apache.org>]

a2l007 commented on code in PR #13815:
URL: https://github.com/apache/druid/pull/13815#discussion_r1108774005


##########
server/src/main/java/org/apache/druid/metadata/IndexerSQLMetadataStorageCoordinator.java:
##########
@@ -1572,12 +1566,12 @@ protected DataStoreMetadataUpdateResult updateDataSourceMetadataWithHandle(
 
     if (!startMetadataMatchesExisting) {
       // Not in the desired start state.
-      log.error(
-          "Not updating metadata, existing state[%s] in metadata store doesn't match to the new start state[%s].",
+      return new DataStoreMetadataUpdateResult(true, false, StringUtils.format(
+          "Not updating metadata, existing state[%s] in metadata store doesn't match to the new start state[%s]." +
+              " This usually happens if the input stream is changed within the same supervisor.",

Review Comment:
   The resolution for this is to reset the supervisor right? Should we also incorporate that information into this error message?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org