You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/11/13 07:45:58 UTC
[GitHub] [shardingsphere] RaigorJiang opened a new issue, #22135: Optimize algorithmDefinition naming in encryptColumnDefinition
RaigorJiang opened a new issue, #22135:
URL: https://github.com/apache/shardingsphere/issues/22135
In the `CREATE ENCRYPT RULE` syntax, there is such a definition as follows:
```sql
encryptColumnDefinition
: LP columnDefinition (COMMA plainColumnDefinition)? COMMA cipherColumnDefinition (COMMA assistedQueryColumnDefinition)? (COMMA likeQueryColumnDefinition)? COMMA algorithmDefinition (COMMA algorithmDefinition)? (COMMA algorithmDefinition)? RP
;
```
Ref: https://github.com/apache/shardingsphere/blob/master/features/encrypt/distsql/parser/src/main/antlr4/imports/encrypt/RDLStatement.g4
It can be found that there are three `algorithmDefinitions` in this definition, but they actually represent different meanings.
According to the semantics, these three `algorithmDefinition` represent `encrypt algorithm`, `assisted query algorithm` and `like query algorithm` respectively.
We should add variables to distinguish these names and improve readability.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] isHuangXin commented on issue #22135: Optimize algorithmDefinition naming in encryptColumnDefinition
Posted by GitBox <gi...@apache.org>.
isHuangXin commented on issue #22135:
URL: https://github.com/apache/shardingsphere/issues/22135#issuecomment-1313178178
I probably understand the meaning of this issue.
There are three algorithmDefinitions in `COMMA algorithmDefinition (COMMA algorithmDefinition)? (COMMA algorithmDefinition)?`, which represent `encrypt algorithm`, `assisted query algorithm` , and `like query algorithm` respectively.
The task I need to finish is to alias these three algorithms separately for better readability.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on issue #22135: Optimize algorithmDefinition naming in encryptColumnDefinition
Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on issue #22135:
URL: https://github.com/apache/shardingsphere/issues/22135#issuecomment-1313133596
Welcome backļ¼ @isHuangXin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] isHuangXin commented on issue #22135: Optimize algorithmDefinition naming in encryptColumnDefinition
Posted by GitBox <gi...@apache.org>.
isHuangXin commented on issue #22135:
URL: https://github.com/apache/shardingsphere/issues/22135#issuecomment-1313051359
[WeOpen Star] Hi, Jiang. I want to try this issue. Plz assign it to me~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang closed issue #22135: Optimize algorithmDefinition naming in encryptColumnDefinition
Posted by GitBox <gi...@apache.org>.
RaigorJiang closed issue #22135: Optimize algorithmDefinition naming in encryptColumnDefinition
URL: https://github.com/apache/shardingsphere/issues/22135
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on issue #22135: Optimize algorithmDefinition naming in encryptColumnDefinition
Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on issue #22135:
URL: https://github.com/apache/shardingsphere/issues/22135#issuecomment-1313312655
> I probably understand the meaning of this issue.
>
> There are three algorithmDefinitions in `COMMA algorithmDefinition (COMMA algorithmDefinition)? (COMMA algorithmDefinition)?`, which represent `encrypt algorithm`, `assisted query algorithm` , and `like query algorithm` respectively.
>
> The task I need to finish is to alias these three algorithms separately for better readability.
Yes, you are right!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org