You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2022/08/27 02:10:43 UTC
[kudu-CR] [test] instantiate ScanPrivilegeVirtualColumnsTest
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18921
Change subject: [test] instantiate ScanPrivilegeVirtualColumnsTest
......................................................................
[test] instantiate ScanPrivilegeVirtualColumnsTest
Before this patch, the ScanPrivilegeVirtualColumnsTest suite was not
instantiated, so no tests from the parameterized suite were run. This
patch adds the missing instantiation, so now the tests are run.
This is a follow-up to 66f4bb136e1bc42e8c031548b56ee1927002ac09.
Change-Id: Id60acd02f22a9ed617c590d8cf0387a366ddc0b1
---
M src/kudu/tserver/tablet_server_authorization-test.cc
1 file changed, 9 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/21/18921/1
--
To view, visit http://gerrit.cloudera.org:8080/18921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id60acd02f22a9ed617c590d8cf0387a366ddc0b1
Gerrit-Change-Number: 18921
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
[kudu-CR] [test] instantiate ScanPrivilegeVirtualColumnsTest
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18921 )
Change subject: [test] instantiate ScanPrivilegeVirtualColumnsTest
......................................................................
[test] instantiate ScanPrivilegeVirtualColumnsTest
Before this patch, the ScanPrivilegeVirtualColumnsTest suite was not
instantiated, so no tests from the parameterized suite were run. This
patch adds the missing instantiation, so now the tests are run.
This is a follow-up to 66f4bb136e1bc42e8c031548b56ee1927002ac09.
Change-Id: Id60acd02f22a9ed617c590d8cf0387a366ddc0b1
Reviewed-on: http://gerrit.cloudera.org:8080/18921
Tested-by: Kudu Jenkins
Reviewed-by: Yingchun Lai <ac...@gmail.com>
---
M src/kudu/tserver/tablet_server_authorization-test.cc
1 file changed, 9 insertions(+), 0 deletions(-)
Approvals:
Kudu Jenkins: Verified
Yingchun Lai: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/18921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id60acd02f22a9ed617c590d8cf0387a366ddc0b1
Gerrit-Change-Number: 18921
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
[kudu-CR] [test] instantiate ScanPrivilegeVirtualColumnsTest
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18921 )
Change subject: [test] instantiate ScanPrivilegeVirtualColumnsTest
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id60acd02f22a9ed617c590d8cf0387a366ddc0b1
Gerrit-Change-Number: 18921
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Sat, 27 Aug 2022 07:41:05 +0000
Gerrit-HasComments: No