You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Leonardo Uribe (JIRA)" <de...@myfaces.apache.org> on 2007/11/18 03:26:42 UTC

[jira] Created: (MYFACES-1769) JSR-252 Issue #224: Corrected h:dataTable var to be a String, and not ValueExpression enabled

JSR-252 Issue #224: Corrected h:dataTable var to be a String, and not ValueExpression enabled
---------------------------------------------------------------------------------------------

                 Key: MYFACES-1769
                 URL: https://issues.apache.org/jira/browse/MYFACES-1769
             Project: MyFaces Core
          Issue Type: Bug
          Components: JSR-252
         Environment: Tomcat 6.0.14, Myfaces 1.2.1-SNAPSHOT
            Reporter: Leonardo Uribe
            Priority: Minor



Now myfaces has the following on UIData:

  // Property: var
  private String _var;

  /**
   * Gets Defines the name of the request-scope variable that will hold the current row during iteration.  This value must be a static value.
   *
   * @return  the new var value
   */
  public String getVar()
  {
    if (_var != null)
    {
      return _var;
    }
    ValueExpression expression = getValueExpression("var");
    if (expression != null)
    {
      return (String)expression.getValue(getFacesContext().getELContext());
    }
    return null;
  }

  /**
   * Sets Defines the name of the request-scope variable that will hold the current row during iteration.  This value must be a static value.
   * 
   * @param var  the new var value
   */
  public void setVar(String var)
  {
    this._var = var;
  }

Because var is a static String, according to the spec it should be as is:

  // Property: var
  private String _var;

  /**
   * Gets Defines the name of the request-scope variable that will hold the current row during iteration.  This value must be a static value.
   *
   * @return  the new var value
   */
  public String getVar()
  {
      return _var;
  }

  /**
   * Sets Defines the name of the request-scope variable that will hold the current row during iteration.  This value must be a static value.
   * 
   * @param var  the new var value
   */
  public void setVar(String var)
  {
    this._var = var;
  }

HtmlDataTableTag has this:

  private ValueExpression _var;
  public void setVar(ValueExpression var)
  {
    _var = var;
  }

it should be this:

  private String _var;
  public void setVar(String var)
  {
   _var=var;
  }

The proper corrections on h.tld and others should be done.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Reopened: (MYFACES-1769) JSR-252 Issue #224: Corrected h:dataTable var to be a String, and not ValueExpression enabled

Posted by "Matthias Weßendorf (JIRA)" <de...@myfaces.apache.org>.
     [ https://issues.apache.org/jira/browse/MYFACES-1769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matthias Weßendorf reopened MYFACES-1769:
-----------------------------------------


> JSR-252 Issue #224: Corrected h:dataTable var to be a String, and not ValueExpression enabled
> ---------------------------------------------------------------------------------------------
>
>                 Key: MYFACES-1769
>                 URL: https://issues.apache.org/jira/browse/MYFACES-1769
>             Project: MyFaces Core
>          Issue Type: Bug
>          Components: JSR-252
>         Environment: Tomcat 6.0.14, Myfaces 1.2.1-SNAPSHOT
>            Reporter: Leonardo Uribe
>            Priority: Minor
>
> Now myfaces has the following on UIData:
>   // Property: var
>   private String _var;
>   /**
>    * Gets Defines the name of the request-scope variable that will hold the current row during iteration.  This value must be a static value.
>    *
>    * @return  the new var value
>    */
>   public String getVar()
>   {
>     if (_var != null)
>     {
>       return _var;
>     }
>     ValueExpression expression = getValueExpression("var");
>     if (expression != null)
>     {
>       return (String)expression.getValue(getFacesContext().getELContext());
>     }
>     return null;
>   }
>   /**
>    * Sets Defines the name of the request-scope variable that will hold the current row during iteration.  This value must be a static value.
>    * 
>    * @param var  the new var value
>    */
>   public void setVar(String var)
>   {
>     this._var = var;
>   }
> Because var is a static String, according to the spec it should be as is:
>   // Property: var
>   private String _var;
>   /**
>    * Gets Defines the name of the request-scope variable that will hold the current row during iteration.  This value must be a static value.
>    *
>    * @return  the new var value
>    */
>   public String getVar()
>   {
>       return _var;
>   }
>   /**
>    * Sets Defines the name of the request-scope variable that will hold the current row during iteration.  This value must be a static value.
>    * 
>    * @param var  the new var value
>    */
>   public void setVar(String var)
>   {
>     this._var = var;
>   }
> HtmlDataTableTag has this:
>   private ValueExpression _var;
>   public void setVar(ValueExpression var)
>   {
>     _var = var;
>   }
> it should be this:
>   private String _var;
>   public void setVar(String var)
>   {
>    _var=var;
>   }
> The proper corrections on h.tld and others should be done.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (MYFACES-1769) JSR-252 Issue #224: Corrected h:dataTable var to be a String, and not ValueExpression enabled

Posted by "Matthias Weßendorf (JIRA)" <de...@myfaces.apache.org>.
     [ https://issues.apache.org/jira/browse/MYFACES-1769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matthias Weßendorf resolved MYFACES-1769.
-----------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.2.1-SNAPSHOT

> JSR-252 Issue #224: Corrected h:dataTable var to be a String, and not ValueExpression enabled
> ---------------------------------------------------------------------------------------------
>
>                 Key: MYFACES-1769
>                 URL: https://issues.apache.org/jira/browse/MYFACES-1769
>             Project: MyFaces Core
>          Issue Type: Bug
>          Components: JSR-252
>         Environment: Tomcat 6.0.14, Myfaces 1.2.1-SNAPSHOT
>            Reporter: Leonardo Uribe
>            Assignee: Matthias Weßendorf
>            Priority: Minor
>             Fix For: 1.2.1-SNAPSHOT
>
>
> Now myfaces has the following on UIData:
>   // Property: var
>   private String _var;
>   /**
>    * Gets Defines the name of the request-scope variable that will hold the current row during iteration.  This value must be a static value.
>    *
>    * @return  the new var value
>    */
>   public String getVar()
>   {
>     if (_var != null)
>     {
>       return _var;
>     }
>     ValueExpression expression = getValueExpression("var");
>     if (expression != null)
>     {
>       return (String)expression.getValue(getFacesContext().getELContext());
>     }
>     return null;
>   }
>   /**
>    * Sets Defines the name of the request-scope variable that will hold the current row during iteration.  This value must be a static value.
>    * 
>    * @param var  the new var value
>    */
>   public void setVar(String var)
>   {
>     this._var = var;
>   }
> Because var is a static String, according to the spec it should be as is:
>   // Property: var
>   private String _var;
>   /**
>    * Gets Defines the name of the request-scope variable that will hold the current row during iteration.  This value must be a static value.
>    *
>    * @return  the new var value
>    */
>   public String getVar()
>   {
>       return _var;
>   }
>   /**
>    * Sets Defines the name of the request-scope variable that will hold the current row during iteration.  This value must be a static value.
>    * 
>    * @param var  the new var value
>    */
>   public void setVar(String var)
>   {
>     this._var = var;
>   }
> HtmlDataTableTag has this:
>   private ValueExpression _var;
>   public void setVar(ValueExpression var)
>   {
>     _var = var;
>   }
> it should be this:
>   private String _var;
>   public void setVar(String var)
>   {
>    _var=var;
>   }
> The proper corrections on h.tld and others should be done.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.