You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by tr...@apache.org on 2017/02/13 14:37:28 UTC
flink git commit: [hotfix] [tests] Correct EitherTypeInfoTest to
respect equals-hashcode contract
Repository: flink
Updated Branches:
refs/heads/master d3a07ef61 -> 1ce10c877
[hotfix] [tests] Correct EitherTypeInfoTest to respect equals-hashcode contract
equality implies equal hash codes but not vice versa. Thus, if two objects are not equal,
then we cannot assume that their hash codes differ as well.
EitherTypeInfoTest#testEitherTypeInequality, however, did exactly that.
Project: http://git-wip-us.apache.org/repos/asf/flink/repo
Commit: http://git-wip-us.apache.org/repos/asf/flink/commit/1ce10c87
Tree: http://git-wip-us.apache.org/repos/asf/flink/tree/1ce10c87
Diff: http://git-wip-us.apache.org/repos/asf/flink/diff/1ce10c87
Branch: refs/heads/master
Commit: 1ce10c8775cf37f0aa792df0e45fa38f1f543846
Parents: d3a07ef
Author: Till Rohrmann <tr...@apache.org>
Authored: Mon Feb 13 15:34:48 2017 +0100
Committer: Till Rohrmann <tr...@apache.org>
Committed: Mon Feb 13 15:36:42 2017 +0100
----------------------------------------------------------------------
.../apache/flink/api/java/typeutils/EitherTypeInfoTest.java | 9 +--------
1 file changed, 1 insertion(+), 8 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/flink/blob/1ce10c87/flink-core/src/test/java/org/apache/flink/api/java/typeutils/EitherTypeInfoTest.java
----------------------------------------------------------------------
diff --git a/flink-core/src/test/java/org/apache/flink/api/java/typeutils/EitherTypeInfoTest.java b/flink-core/src/test/java/org/apache/flink/api/java/typeutils/EitherTypeInfoTest.java
index a3d4568..13009ee 100644
--- a/flink-core/src/test/java/org/apache/flink/api/java/typeutils/EitherTypeInfoTest.java
+++ b/flink-core/src/test/java/org/apache/flink/api/java/typeutils/EitherTypeInfoTest.java
@@ -23,17 +23,11 @@ import static org.junit.Assert.assertNotEquals;
import org.apache.flink.api.common.typeinfo.BasicTypeInfo;
import org.apache.flink.api.java.tuple.Tuple2;
-import org.apache.flink.types.Either;
-import org.apache.flink.types.Either.Right;
import org.apache.flink.util.TestLogger;
import org.junit.Test;
public class EitherTypeInfoTest extends TestLogger {
- Either<Integer, String> intEither = Either.Left(1);
- Either<Integer, String> stringEither = Either.Right("boo");
- Either<Integer, Tuple2<Double, Long>> tuple2Either = new Right<>(new Tuple2<Double, Long>(42.0, 2L));
-
@Test
public void testEitherTypeEquality() {
EitherTypeInfo<Integer, String> eitherInfo1 = new EitherTypeInfo<Integer, String>(
@@ -47,7 +41,7 @@ public class EitherTypeInfoTest extends TestLogger {
}
@Test
- public void testEitherTypeInEquality() {
+ public void testEitherTypeInequality() {
EitherTypeInfo<Integer, String> eitherInfo1 = new EitherTypeInfo<Integer, String>(
BasicTypeInfo.INT_TYPE_INFO, BasicTypeInfo.STRING_TYPE_INFO);
@@ -56,6 +50,5 @@ public class EitherTypeInfoTest extends TestLogger {
TypeExtractor.getForClass(Double.class), TypeExtractor.getForClass(String.class)));
assertNotEquals(eitherInfo1, eitherInfo2);
- assertNotEquals(eitherInfo1.hashCode(), eitherInfo2.hashCode());
}
}