You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "raiden00pl (via GitHub)" <gi...@apache.org> on 2023/07/01 09:29:58 UTC

[GitHub] [nuttx] raiden00pl opened a new pull request, #9661: initial support for nrf9160

raiden00pl opened a new pull request, #9661:
URL: https://github.com/apache/nuttx/pull/9661

   ## Summary
   
   - arch/arm: initial support for NRF91
       Port based on arch/arm/nrf53.
       Modem not fully supported yet. At the moment, initialization and AT interface work.
       Sockets and GNSS interface will be added later.
   
   - boards: initial support for nrf9160-dk
   
   - Documentation: initial doc for NRF91
   
   ## Impact
   
   ## Testing
   nrf9160-dk
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [nuttx] raiden00pl commented on pull request #9661: initial support for nrf9160

Posted by "raiden00pl (via GitHub)" <gi...@apache.org>.
raiden00pl commented on PR #9661:
URL: https://github.com/apache/nuttx/pull/9661#issuecomment-1616417207

   @acassis  At the moment we use `NRF` for other Nordic chips, so it'll be better to change it to `nRF` in a separate PR and update all Nordic chips at once.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [nuttx] acassis commented on a diff in pull request #9661: initial support for nrf9160

Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on code in PR #9661:
URL: https://github.com/apache/nuttx/pull/9661#discussion_r1248918824


##########
arch/arm/src/nrf91/Kconfig:
##########
@@ -0,0 +1,689 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX tools repository.
+#
+
+comment "NRF91 Configuration Options"
+
+# NRF91 Families
+
+choice
+	prompt "NRF91 Chip Selection"
+	default ARCH_CHIP_NRF9160
+	depends on ARCH_CHIP_NRF91
+
+config ARCH_CHIP_NRF9160
+	bool "NRF9160"

Review Comment:
   ```suggestion
   	bool "nRF9160"



##########
arch/arm/src/nrf91/Kconfig:
##########
@@ -0,0 +1,689 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX tools repository.
+#
+
+comment "NRF91 Configuration Options"
+
+# NRF91 Families
+
+choice
+	prompt "NRF91 Chip Selection"
+	default ARCH_CHIP_NRF9160
+	depends on ARCH_CHIP_NRF91
+
+config ARCH_CHIP_NRF9160
+	bool "NRF9160"
+
+endchoice # NRF91 Chip Selection
+
+config NRF91_ENABLE_APPROTECT
+	bool "NRF91 enable APPROTECT"
+	default n
+
+# Peripheral Selection
+
+config NRF91_I2C_MASTER
+	bool
+	default n
+
+config NRF91_SPI_MASTER
+	bool
+	default n
+
+config NRF91_IPC
+	bool
+
+config NRF91_UART
+	bool
+	default n
+
+config NRF91_TIMER
+	bool
+	default n
+
+config NRF91_PWM
+	bool
+	default n
+
+config NRF91_RTC
+	bool
+	default n
+
+config NRF91_SERIAL0
+	bool
+	default n
+
+config NRF91_SERIAL2
+	bool
+	default n
+
+config NRF91_SERIAL3
+	bool
+	default n
+
+config NRF91_SERIAL4
+	bool
+	default n
+
+menu "NRF91 Peripheral Selection"

Review Comment:
   ```suggestion
   menu "nRF91 Peripheral Selection"



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [nuttx] acassis merged pull request #9661: initial support for nrf9160

Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis merged PR #9661:
URL: https://github.com/apache/nuttx/pull/9661


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [nuttx] acassis commented on pull request #9661: initial support for nrf9160

Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on PR #9661:
URL: https://github.com/apache/nuttx/pull/9661#issuecomment-1616036116

   According you Nordic website: 
   https://www.nordicsemi.com/products/nrf9160


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org