You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/05/13 19:15:52 UTC
[GitHub] [superset] aehanno opened a new pull request, #20063: fix : add locale to activate french translation for DatePicker component
aehanno opened a new pull request, #20063:
URL: https://github.com/apache/superset/pull/20063
### SUMMARY
Adding french translation for DatePicker component
### ADDITIONAL INFORMATION
fix https://github.com/apache/superset/issues/20062
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on a diff in pull request #20063: fix : add locale to activate french translation for DatePicker component
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on code in PR #20063:
URL: https://github.com/apache/superset/pull/20063#discussion_r872942176
##########
superset-frontend/src/explore/components/controls/DateFilterControl/components/CustomFrame.tsx:
##########
@@ -132,6 +139,7 @@ export function CustomFrame(props: FrameComponentProps) {
onChange('sinceDatetime', datetime.format(MOMENT_FORMAT))
}
allowClear={false}
+ locale={locale}
Review Comment:
Thanks for the contribution! Could we make translation more generic? For example, we can define a map constant that mapping from `bootstrapData.common.local` to the `antd locale`. Feel free to leave messages if you need help.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] nytai closed pull request #20063: fix: Add locale to activate french translation for DatePicker component
Posted by GitBox <gi...@apache.org>.
nytai closed pull request #20063: fix: Add locale to activate french translation for DatePicker component
URL: https://github.com/apache/superset/pull/20063
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on pull request #20063: fix: Add locale to activate french translation for DatePicker component
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on PR #20063:
URL: https://github.com/apache/superset/pull/20063#issuecomment-1236047462
Hi @mathieudruart, Thank you for the patient. I have pushed a [branch](https://github.com/apache/superset/commits/add-translation-for-DatePicker) to the repo base on your current branch, you should just 1) rebase the master branch 2) cheery-pick the latest [commit](https://github.com/apache/superset/commit/9ebf3c3c00ecc80aa4747e9113a055423d47ffa3) to this for unblocking the CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on pull request #20063: fix: Add locale to activate french translation for DatePicker component
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on PR #20063:
URL: https://github.com/apache/superset/pull/20063#issuecomment-1147613727
@aehanno Sorry for the waiting. I will review PR tomorrow. Thanks for your patience.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #20063: fix: Add locale to activate french translation for DatePicker component
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #20063:
URL: https://github.com/apache/superset/pull/20063#issuecomment-1238821019
# [Codecov](https://codecov.io/gh/apache/superset/pull/20063?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#20063](https://codecov.io/gh/apache/superset/pull/20063?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ca89c4a) into [master](https://codecov.io/gh/apache/superset/commit/286474c3d83903beb37ab5dc650aa2a0977033bb?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (286474c) will **not change** coverage.
> The diff coverage is `66.66%`.
```diff
@@ Coverage Diff @@
## master #20063 +/- ##
=======================================
Coverage 66.58% 66.58%
=======================================
Files 1790 1790
Lines 68416 68419 +3
Branches 7287 7287
=======================================
+ Hits 45554 45556 +2
Misses 20986 20986
- Partials 1876 1877 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `52.71% <66.66%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/20063?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...trols/DateFilterControl/components/CustomFrame.tsx](https://codecov.io/gh/apache/superset/pull/20063/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0N1c3RvbUZyYW1lLnRzeA==) | `70.96% <50.00%> (-1.45%)` | :arrow_down: |
| [...ents/controls/DateFilterControl/utils/constants.ts](https://codecov.io/gh/apache/superset/pull/20063/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC91dGlscy9jb25zdGFudHMudHM=) | `100.00% <100.00%> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] mathieudruart commented on pull request #20063: fix: Add locale to activate french translation for DatePicker component
Posted by GitBox <gi...@apache.org>.
mathieudruart commented on PR #20063:
URL: https://github.com/apache/superset/pull/20063#issuecomment-1235790918
Hi @nyta we pushed a correction, is it possible trigger CI ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] aehanno commented on a diff in pull request #20063: fix: Add locale to activate french translation for DatePicker component
Posted by GitBox <gi...@apache.org>.
aehanno commented on code in PR #20063:
URL: https://github.com/apache/superset/pull/20063#discussion_r874145974
##########
superset-frontend/src/explore/components/controls/DateFilterControl/components/CustomFrame.tsx:
##########
@@ -132,6 +139,7 @@ export function CustomFrame(props: FrameComponentProps) {
onChange('sinceDatetime', datetime.format(MOMENT_FORMAT))
}
allowClear={false}
+ locale={locale}
Review Comment:
Thanks for the review @zhaoyongjie, I agree it will be better with mapping.
I just wonder where I can put this map and I don't really see how I can integrate an import in a map
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] nytai commented on pull request #20063: fix: Add locale to activate french translation for DatePicker component
Posted by GitBox <gi...@apache.org>.
nytai commented on PR #20063:
URL: https://github.com/apache/superset/pull/20063#issuecomment-1232072329
triggering CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie merged pull request #20063: fix: Add locale for DatePicker component
Posted by GitBox <gi...@apache.org>.
zhaoyongjie merged PR #20063:
URL: https://github.com/apache/superset/pull/20063
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on a diff in pull request #20063: fix : add locale to activate french translation for DatePicker component
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on code in PR #20063:
URL: https://github.com/apache/superset/pull/20063#discussion_r872942176
##########
superset-frontend/src/explore/components/controls/DateFilterControl/components/CustomFrame.tsx:
##########
@@ -132,6 +139,7 @@ export function CustomFrame(props: FrameComponentProps) {
onChange('sinceDatetime', datetime.format(MOMENT_FORMAT))
}
allowClear={false}
+ locale={locale}
Review Comment:
Thanks for the contribution! Could we make translation more generic? For example, we can define a map constant that mapping from `bootstrapData.common.local` to the `antd locale`. feel free to leave messages if you need help.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] aehanno commented on a diff in pull request #20063: fix: Add locale to activate french translation for DatePicker component
Posted by GitBox <gi...@apache.org>.
aehanno commented on code in PR #20063:
URL: https://github.com/apache/superset/pull/20063#discussion_r876228250
##########
superset-frontend/src/explore/components/controls/DateFilterControl/components/CustomFrame.tsx:
##########
@@ -132,6 +139,7 @@ export function CustomFrame(props: FrameComponentProps) {
onChange('sinceDatetime', datetime.format(MOMENT_FORMAT))
}
allowClear={false}
+ locale={locale}
Review Comment:
Hey @zhaoyongjie, I change the process to choose dynamicly the locale.
I use a list instead of import all local we need
Just for french translation, there is a bug in antd. We can't distinguish the fr from france and belgium properly so I add a if for now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] aehanno commented on pull request #20063: fix: Add locale to activate french translation for DatePicker component
Posted by GitBox <gi...@apache.org>.
aehanno commented on PR #20063:
URL: https://github.com/apache/superset/pull/20063#issuecomment-1147611735
Hello @zhaoyongjie, just to know if you got time to check on my changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] aehanno commented on a diff in pull request #20063: fix: Add locale to activate french translation for DatePicker component
Posted by GitBox <gi...@apache.org>.
aehanno commented on code in PR #20063:
URL: https://github.com/apache/superset/pull/20063#discussion_r874145974
##########
superset-frontend/src/explore/components/controls/DateFilterControl/components/CustomFrame.tsx:
##########
@@ -132,6 +139,7 @@ export function CustomFrame(props: FrameComponentProps) {
onChange('sinceDatetime', datetime.format(MOMENT_FORMAT))
}
allowClear={false}
+ locale={locale}
Review Comment:
Thanks for the review, I agree it will be better with mapping.
I just wonder where I can put this map and I don't really see how I can integrate an import in a map
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] mathieudruart commented on pull request #20063: fix: Add locale to activate french translation for DatePicker component
Posted by GitBox <gi...@apache.org>.
mathieudruart commented on PR #20063:
URL: https://github.com/apache/superset/pull/20063#issuecomment-1212150382
Hi @zhaoyongjie is it possible to review this PR ? Thank you !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] mathieudruart commented on pull request #20063: fix: Add locale to activate french translation for DatePicker component
Posted by GitBox <gi...@apache.org>.
mathieudruart commented on PR #20063:
URL: https://github.com/apache/superset/pull/20063#issuecomment-1165828506
Hi @zhaoyongjie any news on this PR ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org