You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/04/04 18:58:10 UTC

[GitHub] [cloudstack] BryanMLima opened a new pull request, #6201: [UI'Added attach and detach features to UI for ROOT disks

BryanMLima opened a new pull request, #6201:
URL: https://github.com/apache/cloudstack/pull/6201

   ### Description
   
   It was already possible via API to attach and detach ROOT disks as well as DATADISKs. However, it was only possible to call these methods on DATADISKs through the UI. This PR implements this functionality on the ROOT disks via UI as well with the use of the `deviceid` parameter. Moreover, the API description for `attachVolume` was improved for a better understanding.
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [x] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Feature/Enhancement Scale
   
   - [ ] Major
   - [x] Minor
   
   #### Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [ ] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate):
   ![image](https://user-images.githubusercontent.com/42067040/161584396-853ccb0f-52ad-4c74-a23e-f7d20c90cf20.png)
   
   
   ### How Has This Been Tested?
   This was tested on a local lab with the following scenarios:
   
   VM1 with ROOT disk and DATA disk:
   - Attach DATADISK with deviceid = 0 gives error, as expected.
   - Attach DATADISK with deviceid = 1 gives error, as expected.
   - Attach DATADISK with deviceid = 2 with success, as expected.
   
   VM2 without ROOT disk:
   - Attach DATADISK with deviceid = 0. The DATADISK was recognized as ROOT disk, as expected.
   - Attach DATADISK with deviceid = 5 with success, as expected.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6201: [UI] Added attach and detach features to UI for ROOT disks

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6201:
URL: https://github.com/apache/cloudstack/pull/6201#issuecomment-1105204824

   @nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] nvazquez commented on pull request #6201: [UI] Added attach and detach features to UI for ROOT disks

Posted by GitBox <gi...@apache.org>.
nvazquez commented on PR #6201:
URL: https://github.com/apache/cloudstack/pull/6201#issuecomment-1104569569

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] acs-robot commented on pull request #6201: [UI] Added attach and detach features to UI for ROOT disks

Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6201:
URL: https://github.com/apache/cloudstack/pull/6201#issuecomment-1102897002

   Found UI changes, kicking a new UI QA build
   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] nvazquez commented on pull request #6201: [UI] Added attach and detach features to UI for ROOT disks

Posted by GitBox <gi...@apache.org>.
nvazquez commented on PR #6201:
URL: https://github.com/apache/cloudstack/pull/6201#issuecomment-1104106349

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6201: [UI] Added attach and detach features to UI for ROOT disks

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6201:
URL: https://github.com/apache/cloudstack/pull/6201#issuecomment-1104589720

   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3254


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6201: [UI] Added attach and detach features to UI for ROOT disks

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6201:
URL: https://github.com/apache/cloudstack/pull/6201#issuecomment-1095321896

   @nvazquez a Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] acs-robot commented on pull request #6201: [UI] Added attach and detach features to UI for ROOT disks

Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6201:
URL: https://github.com/apache/cloudstack/pull/6201#issuecomment-1102897017

   Found Java/XML changes, kicking packaging job
   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] BryanMLima commented on pull request #6201: [UI] Added attach and detach features to UI for ROOT disks

Posted by GitBox <gi...@apache.org>.
BryanMLima commented on PR #6201:
URL: https://github.com/apache/cloudstack/pull/6201#issuecomment-1104385012

   Hi @nvazquez, thanks for creating a fix, I messed up the commit history, but I correctly rebased my branch with the main branch now. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6201: [UI] Added attach and detach features to UI for ROOT disks

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6201:
URL: https://github.com/apache/cloudstack/pull/6201#issuecomment-1101338286

   @nvazquez a Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] nvazquez commented on pull request #6201: [UI] Added attach and detach features to UI for ROOT disks

Posted by GitBox <gi...@apache.org>.
nvazquez commented on PR #6201:
URL: https://github.com/apache/cloudstack/pull/6201#issuecomment-1101337779

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6201: [UI] Added attach and detach features to UI for ROOT disks

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6201:
URL: https://github.com/apache/cloudstack/pull/6201#issuecomment-1104570091

   @nvazquez a Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6201: [UI] Added attach and detach features to UI for ROOT disks

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6201:
URL: https://github.com/apache/cloudstack/pull/6201#issuecomment-1099827862

   Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 3178


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6201: [UI] Added attach and detach features to UI for ROOT disks

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6201:
URL: https://github.com/apache/cloudstack/pull/6201#issuecomment-1104393091

   UI build: :heavy_check_mark:
   Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6201 (SL-JID-1417)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] nvazquez commented on pull request #6201: [UI] Added attach and detach features to UI for ROOT disks

Posted by GitBox <gi...@apache.org>.
nvazquez commented on PR #6201:
URL: https://github.com/apache/cloudstack/pull/6201#issuecomment-1104569447

   Thanks @BryanMLima, I’ll test again with the latest changes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] acs-robot commented on pull request #6201: [UI] Added attach and detach features to UI for ROOT disks

Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6201:
URL: https://github.com/apache/cloudstack/pull/6201#issuecomment-1102929627

   ## PR Coverage Report
   |**CLASS**|**INSTRUCTION MISSED**|**INSTRUCTION COVERED**|**BRANCH MISSED**|**BRANCH COVERED**|**LINE MISSED**|**LINE COVERED**|
   |-----|-----|-----|-----|-----|-----|-----|
   ||


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6201: [UI] Added attach and detach features to UI for ROOT disks

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6201:
URL: https://github.com/apache/cloudstack/pull/6201#issuecomment-1104638642

   @nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6201: [UI] Added attach and detach features to UI for ROOT disks

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6201:
URL: https://github.com/apache/cloudstack/pull/6201#issuecomment-1104384098

   @acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] acs-robot commented on pull request #6201: [UI] Added attach and detach features to UI for ROOT disks

Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6201:
URL: https://github.com/apache/cloudstack/pull/6201#issuecomment-1104421327

   ## PR Coverage Report
   |**CLASS**|**INSTRUCTION MISSED**|**INSTRUCTION COVERED**|**BRANCH MISSED**|**BRANCH COVERED**|**LINE MISSED**|**LINE COVERED**|
   |-----|-----|-----|-----|-----|-----|-----|
   ||


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6201: [UI] Added attach and detach features to UI for ROOT disks

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6201:
URL: https://github.com/apache/cloudstack/pull/6201#issuecomment-1099812892

   @nvazquez a Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] nvazquez commented on pull request #6201: [UI] Added attach and detach features to UI for ROOT disks

Posted by GitBox <gi...@apache.org>.
nvazquez commented on PR #6201:
URL: https://github.com/apache/cloudstack/pull/6201#issuecomment-1095321705

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] nvazquez commented on pull request #6201: [UI] Added attach and detach features to UI for ROOT disks

Posted by GitBox <gi...@apache.org>.
nvazquez commented on PR #6201:
URL: https://github.com/apache/cloudstack/pull/6201#issuecomment-1096935683

   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] nvazquez commented on pull request #6201: [UI] Added attach and detach features to UI for ROOT disks

Posted by GitBox <gi...@apache.org>.
nvazquez commented on PR #6201:
URL: https://github.com/apache/cloudstack/pull/6201#issuecomment-1105940867

   Merged based on approvals, intermittent tests failures not related to this PR


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] nvazquez commented on pull request #6201: [UI] Added attach and detach features to UI for ROOT disks

Posted by GitBox <gi...@apache.org>.
nvazquez commented on PR #6201:
URL: https://github.com/apache/cloudstack/pull/6201#issuecomment-1102788183

   Hi @BryanMLima I have tested again and I still have the same issue after detaching a VM's root disk - both times have tested your on a vanilla environment. I have traced the error is caused by this:
   ````
   2022-04-19 15:17:37,061 DEBUG [c.c.a.m.AgentManagerImpl] (AgentManager-Handler-8:null) (logid:) SeqA 3-6270: Processing Seq 3-6270:  { Cmd , MgmtId: -1, via: 3, Ver: v1, Flags: 11, [{"com.cloud.agent.api.ConsoleProxyLoadReportCommand":{"_proxyVmId":"2","_loadInfo":"{
     "connections": []
   }","wait":"0","bypassHostMaintenance":"false"}}] }
   2022-04-19 15:17:37,064 DEBUG [c.c.a.m.AgentManagerImpl] (AgentManager-Handler-8:null) (logid:) SeqA 3-6270: Sending Seq 3-6270:  { Ans: , MgmtId: 32988268069116, via: 3, Ver: v1, Flags: 100010, [{"com.cloud.agent.api.AgentControlAnswer":{"result":"true","wait":"0","bypassHostMaintenance":"false"}}] }
   2022-04-19 15:17:37,498 DEBUG [o.a.c.h.HAManagerImpl] (BackgroundTaskPollManager-5:ctx-4f360eb6) (logid:80937b13) HA health check task is running...
   2022-04-19 15:17:39,780 DEBUG [c.c.a.ApiServlet] (qtp793138072-17:ctx-5f7bb05e) (logid:dc99935d) ===START===  10.0.3.251 -- GET  listall=true&page=1&pagesize=20&showIcon=true&command=listVirtualMachinesMetrics&response=json
   2022-04-19 15:17:39,784 DEBUG [c.c.a.ApiServer] (qtp793138072-17:ctx-5f7bb05e ctx-162916e3) (logid:dc99935d) CIDRs from which account 'Acct[d088e28f-bf84-11ec-b127-1e00ae0000fc-admin] -- Account {"id": 2, "name": "admin", "uuid": "d088e28f-bf84-11ec-b127-1e00ae0000fc"}' is allowed to perform API calls: 0.0.0.0/0,::/0
   2022-04-19 15:17:39,802 ERROR [c.c.a.ApiServer] (qtp793138072-17:ctx-5f7bb05e ctx-162916e3) (logid:dc99935d) unhandled exception executing api command: [Ljava.lang.String;@6baff340
   java.lang.NullPointerException
   	at com.cloud.api.ApiDBUtils.findDiskOfferingById(ApiDBUtils.java:1056)
   	at com.cloud.api.query.dao.UserVmJoinDaoImpl.newUserVmResponse(UserVmJoinDaoImpl.java:187)
   	at jdk.internal.reflect.GeneratedMethodAccessor330.invoke(Unknown Source)
   	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
   	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
   	at org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:344)
   	at org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:198)
   	at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:163)
   	at com.cloud.utils.db.TransactionContextInterceptor.invoke(TransactionContextInterceptor.java:34)
   	at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:175)
   	at org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:97)
   	at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:186)
   	at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:215)
   	at com.sun.proxy.$Proxy158.newUserVmResponse(Unknown Source)
   	at com.cloud.api.ApiDBUtils.newUserVmResponse(ApiDBUtils.java:1812)
   	at com.cloud.api.query.ViewResponseHelper.createUserVmResponse(ViewResponseHelper.java:154)
   	at com.cloud.api.query.QueryManagerImpl.searchForUserVMs(QueryManagerImpl.java:931)
   	at org.apache.cloudstack.api.ListVMsMetricsCmd.execute(ListVMsMetricsCmd.java:60)
   	at com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:156)
   	at com.cloud.api.ApiServer.queueCommand(ApiServer.java:776)
   	at com.cloud.api.ApiServer.handleRequest(ApiServer.java:600)
   	at com.cloud.api.ApiServlet.processRequestInContext(ApiServlet.java:334)
   ````
   
   I can create a fix for this issue, can you please rebase main branch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6201: [UI] Added attach and detach features to UI for ROOT disks

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6201:
URL: https://github.com/apache/cloudstack/pull/6201#issuecomment-1104107741

   @nvazquez a Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] acs-robot commented on pull request #6201: [UI] Added attach and detach features to UI for ROOT disks

Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6201:
URL: https://github.com/apache/cloudstack/pull/6201#issuecomment-1104381329

   Found UI changes, kicking a new UI QA build
   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] nvazquez commented on pull request #6201: [UI] Added attach and detach features to UI for ROOT disks

Posted by GitBox <gi...@apache.org>.
nvazquez commented on PR #6201:
URL: https://github.com/apache/cloudstack/pull/6201#issuecomment-1104638324

   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] nvazquez commented on pull request #6201: [UI] Added attach and detach features to UI for ROOT disks

Posted by GitBox <gi...@apache.org>.
nvazquez commented on PR #6201:
URL: https://github.com/apache/cloudstack/pull/6201#issuecomment-1105203389

   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] nvazquez commented on pull request #6201: [UI] Added attach and detach features to UI for ROOT disks

Posted by GitBox <gi...@apache.org>.
nvazquez commented on PR #6201:
URL: https://github.com/apache/cloudstack/pull/6201#issuecomment-1099812333

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] BryanMLima commented on pull request #6201: [UI] Added attach and detach features to UI for ROOT disks

Posted by GitBox <gi...@apache.org>.
BryanMLima commented on PR #6201:
URL: https://github.com/apache/cloudstack/pull/6201#issuecomment-1099601654

   Hello @nvazquez,
   I tested this scenario at my local lab and it listed the instances normally. Furthermore, this error does not seem to be related to the changes I've made, as I only changed the sections related to the Attach and Detach of volumes. Could you please test again?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6201: [UI] Added attach and detach features to UI for ROOT disks

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6201:
URL: https://github.com/apache/cloudstack/pull/6201#issuecomment-1096936233

   @nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6201: [UI] Added attach and detach features to UI for ROOT disks

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6201:
URL: https://github.com/apache/cloudstack/pull/6201#issuecomment-1095367109

   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3127


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6201: [UI] Added attach and detach features to UI for ROOT disks

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6201:
URL: https://github.com/apache/cloudstack/pull/6201#issuecomment-1097442712

   <b>Trillian test result (tid-3880)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 29760 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6201-t3880-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_iso.py


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6201: [UI] Added attach and detach features to UI for ROOT disks

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6201:
URL: https://github.com/apache/cloudstack/pull/6201#issuecomment-1101364524

   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3199


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6201: [UI] Added attach and detach features to UI for ROOT disks

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6201:
URL: https://github.com/apache/cloudstack/pull/6201#issuecomment-1104271481

   Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: debian. SL-JID 3246


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6201: [UI] Added attach and detach features to UI for ROOT disks

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6201:
URL: https://github.com/apache/cloudstack/pull/6201#issuecomment-1105188285

   <b>Trillian test result (tid-3956)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 37692 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6201-t3956-kvm-centos7.zip
   Smoke tests completed. 93 look OK, 3 have errors
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_add_primary_storage_disabled_host | `Error` | 0.64 | test_primary_storage.py
   test_01_primary_storage_nfs | `Error` | 0.12 | test_primary_storage.py
   ContextSuite context=TestStorageTags>:setup | `Error` | 0.23 | test_primary_storage.py
   test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 30.82 | test_kubernetes_clusters.py
   test_07_deploy_kubernetes_ha_cluster | `Failure` | 57.44 | test_kubernetes_clusters.py
   test_08_upgrade_kubernetes_ha_cluster | `Failure` | 42.14 | test_kubernetes_clusters.py
   test_09_delete_kubernetes_ha_cluster | `Failure` | 31.82 | test_kubernetes_clusters.py
   ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 120.28 | test_kubernetes_clusters.py
   test_hostha_enable_ha_when_host_in_maintenance | `Error` | 301.81 | test_hostha_kvm.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] nvazquez merged pull request #6201: [UI] Added attach and detach features to UI for ROOT disks

Posted by GitBox <gi...@apache.org>.
nvazquez merged PR #6201:
URL: https://github.com/apache/cloudstack/pull/6201


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org