[jira] [Commented] (GEODE-3609) Cleanup AcceptorImpl use of ConnectionMode

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-3609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16172039#comment-16172039 ] 

ASF subversion and git services commented on GEODE-3609:
--------------------------------------------------------

Commit 8211f2fd26fa57ad2a49634d7e3d343ec6106c6c in geode's branch refs/heads/develop from [~gosullivan]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=8211f2f ]

GEODE-3609 Small AcceptorImpl refactor (#772)

Use one CommunicationMode variable, not 3.

Also, refactor the selector and not-selector cases into separate
methods.

I'm not changing the `ServerConnectionFactory` because it more or less
passes straight through to `ServerConnection`, and there's too much
legacy code there to change easily.

> Cleanup AcceptorImpl use of ConnectionMode
> ------------------------------------------
>
>                 Key: GEODE-3609
>                 URL: https://issues.apache.org/jira/browse/GEODE-3609
>             Project: Geode
>          Issue Type: Improvement
>          Components: messaging
>            Reporter: Galen O'Sullivan
>            Assignee: Galen O'Sullivan
>
> AcceptorImpl currently uses three variables to keep track of the connection mode: a byte, a string, and a ConnectionMode (which can provide the byte and string). Change the implementation to just have the class.
> I have a PR for this, creating an issue to track it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)