You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmitro Lisnichenko <dl...@hortonworks.com> on 2015/12/10 19:18:22 UTC
Review Request 41217: RESTART STORM/NIMBUS fails during EU,
2.1 --> 2.3
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41217/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Jayush Luniya, and Nate Cole.
Bugs: AMBARI-14326
https://issues.apache.org/jira/browse/AMBARI-14326
Repository: ambari
Description
-------
{code}
Traceback (most recent call last):
File "/var/lib/ambari-agent/cache/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py", line 149, in <module>
Nimbus().execute()
File "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py", line 218, in execute
method(env)
File "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py", line 514, in restart
self.start(env, upgrade_type=upgrade_type)
File "/var/lib/ambari-agent/cache/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py", line 68, in start
self.configure(env)
File "/var/lib/ambari-agent/cache/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py", line 50, in configure
storm("nimbus")
File "/usr/lib/python2.6/site-packages/ambari_commons/os_family_impl.py", line 89, in thunk
return fn(*args, **kwargs)
File "/var/lib/ambari-agent/cache/common-services/STORM/0.9.1.2.1/package/scripts/storm.py", line 103, in storm
only_if=format("ls {metric_collector_sink_jar}")
File "/usr/lib/python2.6/site-packages/resource_management/core/base.py", line 154, in __init__
self.env.run()
File "/usr/lib/python2.6/site-packages/resource_management/core/environment.py", line 158, in run
self.run_action(resource, action)
File "/usr/lib/python2.6/site-packages/resource_management/core/environment.py", line 121, in run_action
provider_action()
File "/usr/lib/python2.6/site-packages/resource_management/core/providers/system.py", line 238, in action_run
tries=self.resource.tries, try_sleep=self.resource.try_sleep)
File "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 70, in inner
result = function(command, **kwargs)
File "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 92, in checked_call
tries=tries, try_sleep=try_sleep)
File "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 140, in _call_wrapper
result = _call(command, **kwargs_copy)
File "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 291, in _call
raise Fail(err_msg)
resource_management.core.exceptions.Fail: Execution of 'ambari-sudo.sh ln -s /usr/lib/storm/lib/ambari-metrics-storm-sink*.jar /usr/hdp/current/storm-nimbus/lib/ambari-metrics-storm-sink.jar' returned 1. ln: target `/usr/hdp/current/storm-nimbus/lib/ambari-metrics-storm-sink.jar' is not a directory
{code}
Perhaps because there are two files that satisfy the wildcard:
{code}
ls /usr/lib/storm/lib/ambari-metrics-storm-sink*.jar
/usr/lib/storm/lib/ambari-metrics-storm-sink.jar /usr/lib/storm/lib/ambari-metrics-storm-sink-with-common-2.2.0.0.1262.jar
{code}
Diffs
-----
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/storm.py 4e97c65
Diff: https://reviews.apache.org/r/41217/diff/
Testing
-------
mvn clean test
Thanks,
Dmitro Lisnichenko
Re: Review Request 41217: RESTART STORM/NIMBUS fails during EU,
2.1 --> 2.3
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
> On Dec. 10, 2015, 8:37 p.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/storm.py, line 98
> > <https://reviews.apache.org/r/41217/diff/1/?file=1158956#file1158956line98>
> >
> > Isnt storm_lib_dir = /usr/lib/storm/lib/ already on HDP 2.1?
No, during EU it is /usr/hdp/current/storm-nimbus/lib
> On Dec. 10, 2015, 8:37 p.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/storm.py, line 101
> > <https://reviews.apache.org/r/41217/diff/1/?file=1158956#file1158956line101>
> >
> > format not required here
good catch
- Dmitro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41217/#review109823
-----------------------------------------------------------
On Dec. 10, 2015, 9:08 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41217/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2015, 9:08 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Jayush Luniya, and Nate Cole.
>
>
> Bugs: AMBARI-14326
> https://issues.apache.org/jira/browse/AMBARI-14326
>
>
> Repository: ambari
>
>
> Description
> -------
>
> {code}
> Traceback (most recent call last):
> File "/var/lib/ambari-agent/cache/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py", line 149, in <module>
> Nimbus().execute()
> File "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py", line 218, in execute
> method(env)
> File "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py", line 514, in restart
> self.start(env, upgrade_type=upgrade_type)
> File "/var/lib/ambari-agent/cache/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py", line 68, in start
> self.configure(env)
> File "/var/lib/ambari-agent/cache/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py", line 50, in configure
> storm("nimbus")
> File "/usr/lib/python2.6/site-packages/ambari_commons/os_family_impl.py", line 89, in thunk
> return fn(*args, **kwargs)
> File "/var/lib/ambari-agent/cache/common-services/STORM/0.9.1.2.1/package/scripts/storm.py", line 103, in storm
> only_if=format("ls {metric_collector_sink_jar}")
> File "/usr/lib/python2.6/site-packages/resource_management/core/base.py", line 154, in __init__
> self.env.run()
> File "/usr/lib/python2.6/site-packages/resource_management/core/environment.py", line 158, in run
> self.run_action(resource, action)
> File "/usr/lib/python2.6/site-packages/resource_management/core/environment.py", line 121, in run_action
> provider_action()
> File "/usr/lib/python2.6/site-packages/resource_management/core/providers/system.py", line 238, in action_run
> tries=self.resource.tries, try_sleep=self.resource.try_sleep)
> File "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 70, in inner
> result = function(command, **kwargs)
> File "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 92, in checked_call
> tries=tries, try_sleep=try_sleep)
> File "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 140, in _call_wrapper
> result = _call(command, **kwargs_copy)
> File "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 291, in _call
> raise Fail(err_msg)
> resource_management.core.exceptions.Fail: Execution of 'ambari-sudo.sh ln -s /usr/lib/storm/lib/ambari-metrics-storm-sink*.jar /usr/hdp/current/storm-nimbus/lib/ambari-metrics-storm-sink.jar' returned 1. ln: target `/usr/hdp/current/storm-nimbus/lib/ambari-metrics-storm-sink.jar' is not a directory
> {code}
>
> Perhaps because there are two files that satisfy the wildcard:
> {code}
> ls /usr/lib/storm/lib/ambari-metrics-storm-sink*.jar
> /usr/lib/storm/lib/ambari-metrics-storm-sink.jar /usr/lib/storm/lib/ambari-metrics-storm-sink-with-common-2.2.0.0.1262.jar
> {code}
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/storm.py 4e97c65
>
> Diff: https://reviews.apache.org/r/41217/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
> Checked upgrade on live cluster
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 41217: RESTART STORM/NIMBUS fails during EU,
2.1 --> 2.3
Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41217/#review109823
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/storm.py (line 98)
<https://reviews.apache.org/r/41217/#comment169457>
Isnt storm_lib_dir = /usr/lib/storm/lib/ already on HDP 2.1?
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/storm.py (line 101)
<https://reviews.apache.org/r/41217/#comment169455>
format not required here
- Jayush Luniya
On Dec. 10, 2015, 6:19 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41217/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2015, 6:19 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Jayush Luniya, and Nate Cole.
>
>
> Bugs: AMBARI-14326
> https://issues.apache.org/jira/browse/AMBARI-14326
>
>
> Repository: ambari
>
>
> Description
> -------
>
> {code}
> Traceback (most recent call last):
> File "/var/lib/ambari-agent/cache/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py", line 149, in <module>
> Nimbus().execute()
> File "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py", line 218, in execute
> method(env)
> File "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py", line 514, in restart
> self.start(env, upgrade_type=upgrade_type)
> File "/var/lib/ambari-agent/cache/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py", line 68, in start
> self.configure(env)
> File "/var/lib/ambari-agent/cache/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py", line 50, in configure
> storm("nimbus")
> File "/usr/lib/python2.6/site-packages/ambari_commons/os_family_impl.py", line 89, in thunk
> return fn(*args, **kwargs)
> File "/var/lib/ambari-agent/cache/common-services/STORM/0.9.1.2.1/package/scripts/storm.py", line 103, in storm
> only_if=format("ls {metric_collector_sink_jar}")
> File "/usr/lib/python2.6/site-packages/resource_management/core/base.py", line 154, in __init__
> self.env.run()
> File "/usr/lib/python2.6/site-packages/resource_management/core/environment.py", line 158, in run
> self.run_action(resource, action)
> File "/usr/lib/python2.6/site-packages/resource_management/core/environment.py", line 121, in run_action
> provider_action()
> File "/usr/lib/python2.6/site-packages/resource_management/core/providers/system.py", line 238, in action_run
> tries=self.resource.tries, try_sleep=self.resource.try_sleep)
> File "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 70, in inner
> result = function(command, **kwargs)
> File "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 92, in checked_call
> tries=tries, try_sleep=try_sleep)
> File "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 140, in _call_wrapper
> result = _call(command, **kwargs_copy)
> File "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 291, in _call
> raise Fail(err_msg)
> resource_management.core.exceptions.Fail: Execution of 'ambari-sudo.sh ln -s /usr/lib/storm/lib/ambari-metrics-storm-sink*.jar /usr/hdp/current/storm-nimbus/lib/ambari-metrics-storm-sink.jar' returned 1. ln: target `/usr/hdp/current/storm-nimbus/lib/ambari-metrics-storm-sink.jar' is not a directory
> {code}
>
> Perhaps because there are two files that satisfy the wildcard:
> {code}
> ls /usr/lib/storm/lib/ambari-metrics-storm-sink*.jar
> /usr/lib/storm/lib/ambari-metrics-storm-sink.jar /usr/lib/storm/lib/ambari-metrics-storm-sink-with-common-2.2.0.0.1262.jar
> {code}
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/storm.py 4e97c65
>
> Diff: https://reviews.apache.org/r/41217/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
> Checked upgrade on live cluster
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 41217: RESTART STORM/NIMBUS fails during EU,
2.1 --> 2.3
Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41217/#review109866
-----------------------------------------------------------
Ship it!
Ship It!
- Jayush Luniya
On Dec. 10, 2015, 7:08 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41217/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2015, 7:08 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Jayush Luniya, and Nate Cole.
>
>
> Bugs: AMBARI-14326
> https://issues.apache.org/jira/browse/AMBARI-14326
>
>
> Repository: ambari
>
>
> Description
> -------
>
> {code}
> Traceback (most recent call last):
> File "/var/lib/ambari-agent/cache/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py", line 149, in <module>
> Nimbus().execute()
> File "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py", line 218, in execute
> method(env)
> File "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py", line 514, in restart
> self.start(env, upgrade_type=upgrade_type)
> File "/var/lib/ambari-agent/cache/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py", line 68, in start
> self.configure(env)
> File "/var/lib/ambari-agent/cache/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py", line 50, in configure
> storm("nimbus")
> File "/usr/lib/python2.6/site-packages/ambari_commons/os_family_impl.py", line 89, in thunk
> return fn(*args, **kwargs)
> File "/var/lib/ambari-agent/cache/common-services/STORM/0.9.1.2.1/package/scripts/storm.py", line 103, in storm
> only_if=format("ls {metric_collector_sink_jar}")
> File "/usr/lib/python2.6/site-packages/resource_management/core/base.py", line 154, in __init__
> self.env.run()
> File "/usr/lib/python2.6/site-packages/resource_management/core/environment.py", line 158, in run
> self.run_action(resource, action)
> File "/usr/lib/python2.6/site-packages/resource_management/core/environment.py", line 121, in run_action
> provider_action()
> File "/usr/lib/python2.6/site-packages/resource_management/core/providers/system.py", line 238, in action_run
> tries=self.resource.tries, try_sleep=self.resource.try_sleep)
> File "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 70, in inner
> result = function(command, **kwargs)
> File "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 92, in checked_call
> tries=tries, try_sleep=try_sleep)
> File "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 140, in _call_wrapper
> result = _call(command, **kwargs_copy)
> File "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 291, in _call
> raise Fail(err_msg)
> resource_management.core.exceptions.Fail: Execution of 'ambari-sudo.sh ln -s /usr/lib/storm/lib/ambari-metrics-storm-sink*.jar /usr/hdp/current/storm-nimbus/lib/ambari-metrics-storm-sink.jar' returned 1. ln: target `/usr/hdp/current/storm-nimbus/lib/ambari-metrics-storm-sink.jar' is not a directory
> {code}
>
> Perhaps because there are two files that satisfy the wildcard:
> {code}
> ls /usr/lib/storm/lib/ambari-metrics-storm-sink*.jar
> /usr/lib/storm/lib/ambari-metrics-storm-sink.jar /usr/lib/storm/lib/ambari-metrics-storm-sink-with-common-2.2.0.0.1262.jar
> {code}
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/storm.py 4e97c65
>
> Diff: https://reviews.apache.org/r/41217/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
> Checked upgrade on live cluster
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 41217: RESTART STORM/NIMBUS fails during EU,
2.1 --> 2.3
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41217/
-----------------------------------------------------------
(Updated Dec. 10, 2015, 9:08 p.m.)
Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Jayush Luniya, and Nate Cole.
Changes
-------
Removed format()
Bugs: AMBARI-14326
https://issues.apache.org/jira/browse/AMBARI-14326
Repository: ambari
Description
-------
{code}
Traceback (most recent call last):
File "/var/lib/ambari-agent/cache/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py", line 149, in <module>
Nimbus().execute()
File "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py", line 218, in execute
method(env)
File "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py", line 514, in restart
self.start(env, upgrade_type=upgrade_type)
File "/var/lib/ambari-agent/cache/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py", line 68, in start
self.configure(env)
File "/var/lib/ambari-agent/cache/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py", line 50, in configure
storm("nimbus")
File "/usr/lib/python2.6/site-packages/ambari_commons/os_family_impl.py", line 89, in thunk
return fn(*args, **kwargs)
File "/var/lib/ambari-agent/cache/common-services/STORM/0.9.1.2.1/package/scripts/storm.py", line 103, in storm
only_if=format("ls {metric_collector_sink_jar}")
File "/usr/lib/python2.6/site-packages/resource_management/core/base.py", line 154, in __init__
self.env.run()
File "/usr/lib/python2.6/site-packages/resource_management/core/environment.py", line 158, in run
self.run_action(resource, action)
File "/usr/lib/python2.6/site-packages/resource_management/core/environment.py", line 121, in run_action
provider_action()
File "/usr/lib/python2.6/site-packages/resource_management/core/providers/system.py", line 238, in action_run
tries=self.resource.tries, try_sleep=self.resource.try_sleep)
File "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 70, in inner
result = function(command, **kwargs)
File "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 92, in checked_call
tries=tries, try_sleep=try_sleep)
File "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 140, in _call_wrapper
result = _call(command, **kwargs_copy)
File "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 291, in _call
raise Fail(err_msg)
resource_management.core.exceptions.Fail: Execution of 'ambari-sudo.sh ln -s /usr/lib/storm/lib/ambari-metrics-storm-sink*.jar /usr/hdp/current/storm-nimbus/lib/ambari-metrics-storm-sink.jar' returned 1. ln: target `/usr/hdp/current/storm-nimbus/lib/ambari-metrics-storm-sink.jar' is not a directory
{code}
Perhaps because there are two files that satisfy the wildcard:
{code}
ls /usr/lib/storm/lib/ambari-metrics-storm-sink*.jar
/usr/lib/storm/lib/ambari-metrics-storm-sink.jar /usr/lib/storm/lib/ambari-metrics-storm-sink-with-common-2.2.0.0.1262.jar
{code}
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/storm.py 4e97c65
Diff: https://reviews.apache.org/r/41217/diff/
Testing
-------
mvn clean test
Checked upgrade on live cluster
Thanks,
Dmitro Lisnichenko
Re: Review Request 41217: RESTART STORM/NIMBUS fails during EU,
2.1 --> 2.3
Posted by Jayush Luniya <jl...@hortonworks.com>.
> On Dec. 10, 2015, 6:54 p.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/storm.py, line 101
> > <https://reviews.apache.org/r/41217/diff/1/?file=1158956#file1158956line101>
> >
> > Actually based on your comment isnt the issue because of there being more than one JAR that matches the wildcard?
> >
> > {quote}
> >
> > Perhaps because there are two files that satisfy the wildcard:
> > {code}
> > ls /usr/lib/storm/lib/ambari-metrics-storm-sink*.jar
> > /usr/lib/storm/lib/ambari-metrics-storm-sink.jar /usr/lib/storm/lib/ambari-metrics-storm-sink-with-common-2.2.0.0.1262.jar
> > {code}
> >
> > {quote}
[vagrant@c6401 dir]$ touch a
[vagrant@c6401 dir]$ touch a1
[vagrant@c6401 dir]$ ls
a a1
[vagrant@c6401 dir]$ ln -s a* a.ln
ln: target `a.ln' is not a directory
[vagrant@c6401 dir]$ rm a1
[vagrant@c6401 dir]$ ln -s a* a.ln
[vagrant@c6401 dir]$ ls -lh
total 0
-rw-rw-r-- 1 vagrant vagrant 0 Dec 10 18:55 a
lrwxrwxrwx 1 vagrant vagrant 1 Dec 10 18:56 a.ln -> a
- Jayush
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41217/#review109829
-----------------------------------------------------------
On Dec. 10, 2015, 6:19 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41217/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2015, 6:19 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Jayush Luniya, and Nate Cole.
>
>
> Bugs: AMBARI-14326
> https://issues.apache.org/jira/browse/AMBARI-14326
>
>
> Repository: ambari
>
>
> Description
> -------
>
> {code}
> Traceback (most recent call last):
> File "/var/lib/ambari-agent/cache/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py", line 149, in <module>
> Nimbus().execute()
> File "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py", line 218, in execute
> method(env)
> File "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py", line 514, in restart
> self.start(env, upgrade_type=upgrade_type)
> File "/var/lib/ambari-agent/cache/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py", line 68, in start
> self.configure(env)
> File "/var/lib/ambari-agent/cache/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py", line 50, in configure
> storm("nimbus")
> File "/usr/lib/python2.6/site-packages/ambari_commons/os_family_impl.py", line 89, in thunk
> return fn(*args, **kwargs)
> File "/var/lib/ambari-agent/cache/common-services/STORM/0.9.1.2.1/package/scripts/storm.py", line 103, in storm
> only_if=format("ls {metric_collector_sink_jar}")
> File "/usr/lib/python2.6/site-packages/resource_management/core/base.py", line 154, in __init__
> self.env.run()
> File "/usr/lib/python2.6/site-packages/resource_management/core/environment.py", line 158, in run
> self.run_action(resource, action)
> File "/usr/lib/python2.6/site-packages/resource_management/core/environment.py", line 121, in run_action
> provider_action()
> File "/usr/lib/python2.6/site-packages/resource_management/core/providers/system.py", line 238, in action_run
> tries=self.resource.tries, try_sleep=self.resource.try_sleep)
> File "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 70, in inner
> result = function(command, **kwargs)
> File "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 92, in checked_call
> tries=tries, try_sleep=try_sleep)
> File "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 140, in _call_wrapper
> result = _call(command, **kwargs_copy)
> File "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 291, in _call
> raise Fail(err_msg)
> resource_management.core.exceptions.Fail: Execution of 'ambari-sudo.sh ln -s /usr/lib/storm/lib/ambari-metrics-storm-sink*.jar /usr/hdp/current/storm-nimbus/lib/ambari-metrics-storm-sink.jar' returned 1. ln: target `/usr/hdp/current/storm-nimbus/lib/ambari-metrics-storm-sink.jar' is not a directory
> {code}
>
> Perhaps because there are two files that satisfy the wildcard:
> {code}
> ls /usr/lib/storm/lib/ambari-metrics-storm-sink*.jar
> /usr/lib/storm/lib/ambari-metrics-storm-sink.jar /usr/lib/storm/lib/ambari-metrics-storm-sink-with-common-2.2.0.0.1262.jar
> {code}
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/storm.py 4e97c65
>
> Diff: https://reviews.apache.org/r/41217/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
> Checked upgrade on live cluster
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 41217: RESTART STORM/NIMBUS fails during EU,
2.1 --> 2.3
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
> On Dec. 10, 2015, 8:54 p.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/storm.py, line 101
> > <https://reviews.apache.org/r/41217/diff/1/?file=1158956#file1158956line101>
> >
> > Actually based on your comment isnt the issue because of there being more than one JAR that matches the wildcard?
> >
> > {quote}
> >
> > Perhaps because there are two files that satisfy the wildcard:
> > {code}
> > ls /usr/lib/storm/lib/ambari-metrics-storm-sink*.jar
> > /usr/lib/storm/lib/ambari-metrics-storm-sink.jar /usr/lib/storm/lib/ambari-metrics-storm-sink-with-common-2.2.0.0.1262.jar
> > {code}
> >
> > {quote}
>
> Jayush Luniya wrote:
> [vagrant@c6401 dir]$ touch a
> [vagrant@c6401 dir]$ touch a1
> [vagrant@c6401 dir]$ ls
> a a1
> [vagrant@c6401 dir]$ ln -s a* a.ln
> ln: target `a.ln' is not a directory
> [vagrant@c6401 dir]$ rm a1
> [vagrant@c6401 dir]$ ln -s a* a.ln
> [vagrant@c6401 dir]$ ls -lh
> total 0
> -rw-rw-r-- 1 vagrant vagrant 0 Dec 10 18:55 a
> lrwxrwxrwx 1 vagrant vagrant 1 Dec 10 18:56 a.ln -> a
yes, one jar is required, and one is obsolete
- Dmitro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41217/#review109829
-----------------------------------------------------------
On Dec. 10, 2015, 9:08 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41217/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2015, 9:08 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Jayush Luniya, and Nate Cole.
>
>
> Bugs: AMBARI-14326
> https://issues.apache.org/jira/browse/AMBARI-14326
>
>
> Repository: ambari
>
>
> Description
> -------
>
> {code}
> Traceback (most recent call last):
> File "/var/lib/ambari-agent/cache/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py", line 149, in <module>
> Nimbus().execute()
> File "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py", line 218, in execute
> method(env)
> File "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py", line 514, in restart
> self.start(env, upgrade_type=upgrade_type)
> File "/var/lib/ambari-agent/cache/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py", line 68, in start
> self.configure(env)
> File "/var/lib/ambari-agent/cache/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py", line 50, in configure
> storm("nimbus")
> File "/usr/lib/python2.6/site-packages/ambari_commons/os_family_impl.py", line 89, in thunk
> return fn(*args, **kwargs)
> File "/var/lib/ambari-agent/cache/common-services/STORM/0.9.1.2.1/package/scripts/storm.py", line 103, in storm
> only_if=format("ls {metric_collector_sink_jar}")
> File "/usr/lib/python2.6/site-packages/resource_management/core/base.py", line 154, in __init__
> self.env.run()
> File "/usr/lib/python2.6/site-packages/resource_management/core/environment.py", line 158, in run
> self.run_action(resource, action)
> File "/usr/lib/python2.6/site-packages/resource_management/core/environment.py", line 121, in run_action
> provider_action()
> File "/usr/lib/python2.6/site-packages/resource_management/core/providers/system.py", line 238, in action_run
> tries=self.resource.tries, try_sleep=self.resource.try_sleep)
> File "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 70, in inner
> result = function(command, **kwargs)
> File "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 92, in checked_call
> tries=tries, try_sleep=try_sleep)
> File "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 140, in _call_wrapper
> result = _call(command, **kwargs_copy)
> File "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 291, in _call
> raise Fail(err_msg)
> resource_management.core.exceptions.Fail: Execution of 'ambari-sudo.sh ln -s /usr/lib/storm/lib/ambari-metrics-storm-sink*.jar /usr/hdp/current/storm-nimbus/lib/ambari-metrics-storm-sink.jar' returned 1. ln: target `/usr/hdp/current/storm-nimbus/lib/ambari-metrics-storm-sink.jar' is not a directory
> {code}
>
> Perhaps because there are two files that satisfy the wildcard:
> {code}
> ls /usr/lib/storm/lib/ambari-metrics-storm-sink*.jar
> /usr/lib/storm/lib/ambari-metrics-storm-sink.jar /usr/lib/storm/lib/ambari-metrics-storm-sink-with-common-2.2.0.0.1262.jar
> {code}
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/storm.py 4e97c65
>
> Diff: https://reviews.apache.org/r/41217/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
> Checked upgrade on live cluster
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 41217: RESTART STORM/NIMBUS fails during EU,
2.1 --> 2.3
Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41217/#review109829
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/storm.py (line 101)
<https://reviews.apache.org/r/41217/#comment169459>
Actually based on your comment isnt the issue because of there being more than one JAR that matches the wildcard?
{quote}
Perhaps because there are two files that satisfy the wildcard:
{code}
ls /usr/lib/storm/lib/ambari-metrics-storm-sink*.jar
/usr/lib/storm/lib/ambari-metrics-storm-sink.jar /usr/lib/storm/lib/ambari-metrics-storm-sink-with-common-2.2.0.0.1262.jar
{code}
{quote}
- Jayush Luniya
On Dec. 10, 2015, 6:19 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41217/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2015, 6:19 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Jayush Luniya, and Nate Cole.
>
>
> Bugs: AMBARI-14326
> https://issues.apache.org/jira/browse/AMBARI-14326
>
>
> Repository: ambari
>
>
> Description
> -------
>
> {code}
> Traceback (most recent call last):
> File "/var/lib/ambari-agent/cache/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py", line 149, in <module>
> Nimbus().execute()
> File "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py", line 218, in execute
> method(env)
> File "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py", line 514, in restart
> self.start(env, upgrade_type=upgrade_type)
> File "/var/lib/ambari-agent/cache/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py", line 68, in start
> self.configure(env)
> File "/var/lib/ambari-agent/cache/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py", line 50, in configure
> storm("nimbus")
> File "/usr/lib/python2.6/site-packages/ambari_commons/os_family_impl.py", line 89, in thunk
> return fn(*args, **kwargs)
> File "/var/lib/ambari-agent/cache/common-services/STORM/0.9.1.2.1/package/scripts/storm.py", line 103, in storm
> only_if=format("ls {metric_collector_sink_jar}")
> File "/usr/lib/python2.6/site-packages/resource_management/core/base.py", line 154, in __init__
> self.env.run()
> File "/usr/lib/python2.6/site-packages/resource_management/core/environment.py", line 158, in run
> self.run_action(resource, action)
> File "/usr/lib/python2.6/site-packages/resource_management/core/environment.py", line 121, in run_action
> provider_action()
> File "/usr/lib/python2.6/site-packages/resource_management/core/providers/system.py", line 238, in action_run
> tries=self.resource.tries, try_sleep=self.resource.try_sleep)
> File "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 70, in inner
> result = function(command, **kwargs)
> File "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 92, in checked_call
> tries=tries, try_sleep=try_sleep)
> File "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 140, in _call_wrapper
> result = _call(command, **kwargs_copy)
> File "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 291, in _call
> raise Fail(err_msg)
> resource_management.core.exceptions.Fail: Execution of 'ambari-sudo.sh ln -s /usr/lib/storm/lib/ambari-metrics-storm-sink*.jar /usr/hdp/current/storm-nimbus/lib/ambari-metrics-storm-sink.jar' returned 1. ln: target `/usr/hdp/current/storm-nimbus/lib/ambari-metrics-storm-sink.jar' is not a directory
> {code}
>
> Perhaps because there are two files that satisfy the wildcard:
> {code}
> ls /usr/lib/storm/lib/ambari-metrics-storm-sink*.jar
> /usr/lib/storm/lib/ambari-metrics-storm-sink.jar /usr/lib/storm/lib/ambari-metrics-storm-sink-with-common-2.2.0.0.1262.jar
> {code}
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/storm.py 4e97c65
>
> Diff: https://reviews.apache.org/r/41217/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
> Checked upgrade on live cluster
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 41217: RESTART STORM/NIMBUS fails during EU,
2.1 --> 2.3
Posted by Mahadev Konar <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41217/#review109814
-----------------------------------------------------------
Ship it!
Ship It!
- Mahadev Konar
On Dec. 10, 2015, 6:19 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41217/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2015, 6:19 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Jayush Luniya, and Nate Cole.
>
>
> Bugs: AMBARI-14326
> https://issues.apache.org/jira/browse/AMBARI-14326
>
>
> Repository: ambari
>
>
> Description
> -------
>
> {code}
> Traceback (most recent call last):
> File "/var/lib/ambari-agent/cache/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py", line 149, in <module>
> Nimbus().execute()
> File "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py", line 218, in execute
> method(env)
> File "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py", line 514, in restart
> self.start(env, upgrade_type=upgrade_type)
> File "/var/lib/ambari-agent/cache/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py", line 68, in start
> self.configure(env)
> File "/var/lib/ambari-agent/cache/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py", line 50, in configure
> storm("nimbus")
> File "/usr/lib/python2.6/site-packages/ambari_commons/os_family_impl.py", line 89, in thunk
> return fn(*args, **kwargs)
> File "/var/lib/ambari-agent/cache/common-services/STORM/0.9.1.2.1/package/scripts/storm.py", line 103, in storm
> only_if=format("ls {metric_collector_sink_jar}")
> File "/usr/lib/python2.6/site-packages/resource_management/core/base.py", line 154, in __init__
> self.env.run()
> File "/usr/lib/python2.6/site-packages/resource_management/core/environment.py", line 158, in run
> self.run_action(resource, action)
> File "/usr/lib/python2.6/site-packages/resource_management/core/environment.py", line 121, in run_action
> provider_action()
> File "/usr/lib/python2.6/site-packages/resource_management/core/providers/system.py", line 238, in action_run
> tries=self.resource.tries, try_sleep=self.resource.try_sleep)
> File "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 70, in inner
> result = function(command, **kwargs)
> File "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 92, in checked_call
> tries=tries, try_sleep=try_sleep)
> File "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 140, in _call_wrapper
> result = _call(command, **kwargs_copy)
> File "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 291, in _call
> raise Fail(err_msg)
> resource_management.core.exceptions.Fail: Execution of 'ambari-sudo.sh ln -s /usr/lib/storm/lib/ambari-metrics-storm-sink*.jar /usr/hdp/current/storm-nimbus/lib/ambari-metrics-storm-sink.jar' returned 1. ln: target `/usr/hdp/current/storm-nimbus/lib/ambari-metrics-storm-sink.jar' is not a directory
> {code}
>
> Perhaps because there are two files that satisfy the wildcard:
> {code}
> ls /usr/lib/storm/lib/ambari-metrics-storm-sink*.jar
> /usr/lib/storm/lib/ambari-metrics-storm-sink.jar /usr/lib/storm/lib/ambari-metrics-storm-sink-with-common-2.2.0.0.1262.jar
> {code}
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/storm.py 4e97c65
>
> Diff: https://reviews.apache.org/r/41217/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
> Checked upgrade on live cluster
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 41217: RESTART STORM/NIMBUS fails during EU,
2.1 --> 2.3
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
> On Dec. 10, 2015, 8:37 p.m., Nate Cole wrote:
> > ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/storm.py, lines 100-102
> > <https://reviews.apache.org/r/41217/diff/1/?file=1158956#file1158956line100>
> >
> > So should there be some kind of version check, or only_if (or not_if) directive?
This statement defines the required resource state (link is missing), and link is not present on HDP versions > 2.1, so if/not if seems to be excessive here
- Dmitro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41217/#review109824
-----------------------------------------------------------
On Dec. 10, 2015, 9:08 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41217/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2015, 9:08 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Jayush Luniya, and Nate Cole.
>
>
> Bugs: AMBARI-14326
> https://issues.apache.org/jira/browse/AMBARI-14326
>
>
> Repository: ambari
>
>
> Description
> -------
>
> {code}
> Traceback (most recent call last):
> File "/var/lib/ambari-agent/cache/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py", line 149, in <module>
> Nimbus().execute()
> File "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py", line 218, in execute
> method(env)
> File "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py", line 514, in restart
> self.start(env, upgrade_type=upgrade_type)
> File "/var/lib/ambari-agent/cache/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py", line 68, in start
> self.configure(env)
> File "/var/lib/ambari-agent/cache/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py", line 50, in configure
> storm("nimbus")
> File "/usr/lib/python2.6/site-packages/ambari_commons/os_family_impl.py", line 89, in thunk
> return fn(*args, **kwargs)
> File "/var/lib/ambari-agent/cache/common-services/STORM/0.9.1.2.1/package/scripts/storm.py", line 103, in storm
> only_if=format("ls {metric_collector_sink_jar}")
> File "/usr/lib/python2.6/site-packages/resource_management/core/base.py", line 154, in __init__
> self.env.run()
> File "/usr/lib/python2.6/site-packages/resource_management/core/environment.py", line 158, in run
> self.run_action(resource, action)
> File "/usr/lib/python2.6/site-packages/resource_management/core/environment.py", line 121, in run_action
> provider_action()
> File "/usr/lib/python2.6/site-packages/resource_management/core/providers/system.py", line 238, in action_run
> tries=self.resource.tries, try_sleep=self.resource.try_sleep)
> File "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 70, in inner
> result = function(command, **kwargs)
> File "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 92, in checked_call
> tries=tries, try_sleep=try_sleep)
> File "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 140, in _call_wrapper
> result = _call(command, **kwargs_copy)
> File "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 291, in _call
> raise Fail(err_msg)
> resource_management.core.exceptions.Fail: Execution of 'ambari-sudo.sh ln -s /usr/lib/storm/lib/ambari-metrics-storm-sink*.jar /usr/hdp/current/storm-nimbus/lib/ambari-metrics-storm-sink.jar' returned 1. ln: target `/usr/hdp/current/storm-nimbus/lib/ambari-metrics-storm-sink.jar' is not a directory
> {code}
>
> Perhaps because there are two files that satisfy the wildcard:
> {code}
> ls /usr/lib/storm/lib/ambari-metrics-storm-sink*.jar
> /usr/lib/storm/lib/ambari-metrics-storm-sink.jar /usr/lib/storm/lib/ambari-metrics-storm-sink-with-common-2.2.0.0.1262.jar
> {code}
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/storm.py 4e97c65
>
> Diff: https://reviews.apache.org/r/41217/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
> Checked upgrade on live cluster
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 41217: RESTART STORM/NIMBUS fails during EU,
2.1 --> 2.3
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41217/#review109824
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/storm.py (lines 100 - 102)
<https://reviews.apache.org/r/41217/#comment169456>
So should there be some kind of version check, or only_if (or not_if) directive?
- Nate Cole
On Dec. 10, 2015, 1:19 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41217/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2015, 1:19 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Jayush Luniya, and Nate Cole.
>
>
> Bugs: AMBARI-14326
> https://issues.apache.org/jira/browse/AMBARI-14326
>
>
> Repository: ambari
>
>
> Description
> -------
>
> {code}
> Traceback (most recent call last):
> File "/var/lib/ambari-agent/cache/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py", line 149, in <module>
> Nimbus().execute()
> File "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py", line 218, in execute
> method(env)
> File "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py", line 514, in restart
> self.start(env, upgrade_type=upgrade_type)
> File "/var/lib/ambari-agent/cache/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py", line 68, in start
> self.configure(env)
> File "/var/lib/ambari-agent/cache/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py", line 50, in configure
> storm("nimbus")
> File "/usr/lib/python2.6/site-packages/ambari_commons/os_family_impl.py", line 89, in thunk
> return fn(*args, **kwargs)
> File "/var/lib/ambari-agent/cache/common-services/STORM/0.9.1.2.1/package/scripts/storm.py", line 103, in storm
> only_if=format("ls {metric_collector_sink_jar}")
> File "/usr/lib/python2.6/site-packages/resource_management/core/base.py", line 154, in __init__
> self.env.run()
> File "/usr/lib/python2.6/site-packages/resource_management/core/environment.py", line 158, in run
> self.run_action(resource, action)
> File "/usr/lib/python2.6/site-packages/resource_management/core/environment.py", line 121, in run_action
> provider_action()
> File "/usr/lib/python2.6/site-packages/resource_management/core/providers/system.py", line 238, in action_run
> tries=self.resource.tries, try_sleep=self.resource.try_sleep)
> File "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 70, in inner
> result = function(command, **kwargs)
> File "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 92, in checked_call
> tries=tries, try_sleep=try_sleep)
> File "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 140, in _call_wrapper
> result = _call(command, **kwargs_copy)
> File "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 291, in _call
> raise Fail(err_msg)
> resource_management.core.exceptions.Fail: Execution of 'ambari-sudo.sh ln -s /usr/lib/storm/lib/ambari-metrics-storm-sink*.jar /usr/hdp/current/storm-nimbus/lib/ambari-metrics-storm-sink.jar' returned 1. ln: target `/usr/hdp/current/storm-nimbus/lib/ambari-metrics-storm-sink.jar' is not a directory
> {code}
>
> Perhaps because there are two files that satisfy the wildcard:
> {code}
> ls /usr/lib/storm/lib/ambari-metrics-storm-sink*.jar
> /usr/lib/storm/lib/ambari-metrics-storm-sink.jar /usr/lib/storm/lib/ambari-metrics-storm-sink-with-common-2.2.0.0.1262.jar
> {code}
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/storm.py 4e97c65
>
> Diff: https://reviews.apache.org/r/41217/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
> Checked upgrade on live cluster
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 41217: RESTART STORM/NIMBUS fails during EU,
2.1 --> 2.3
Posted by Aravindan Vijayan <av...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41217/#review109820
-----------------------------------------------------------
Ship it!
Ship It!
- Aravindan Vijayan
On Dec. 10, 2015, 6:19 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41217/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2015, 6:19 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Jayush Luniya, and Nate Cole.
>
>
> Bugs: AMBARI-14326
> https://issues.apache.org/jira/browse/AMBARI-14326
>
>
> Repository: ambari
>
>
> Description
> -------
>
> {code}
> Traceback (most recent call last):
> File "/var/lib/ambari-agent/cache/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py", line 149, in <module>
> Nimbus().execute()
> File "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py", line 218, in execute
> method(env)
> File "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py", line 514, in restart
> self.start(env, upgrade_type=upgrade_type)
> File "/var/lib/ambari-agent/cache/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py", line 68, in start
> self.configure(env)
> File "/var/lib/ambari-agent/cache/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py", line 50, in configure
> storm("nimbus")
> File "/usr/lib/python2.6/site-packages/ambari_commons/os_family_impl.py", line 89, in thunk
> return fn(*args, **kwargs)
> File "/var/lib/ambari-agent/cache/common-services/STORM/0.9.1.2.1/package/scripts/storm.py", line 103, in storm
> only_if=format("ls {metric_collector_sink_jar}")
> File "/usr/lib/python2.6/site-packages/resource_management/core/base.py", line 154, in __init__
> self.env.run()
> File "/usr/lib/python2.6/site-packages/resource_management/core/environment.py", line 158, in run
> self.run_action(resource, action)
> File "/usr/lib/python2.6/site-packages/resource_management/core/environment.py", line 121, in run_action
> provider_action()
> File "/usr/lib/python2.6/site-packages/resource_management/core/providers/system.py", line 238, in action_run
> tries=self.resource.tries, try_sleep=self.resource.try_sleep)
> File "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 70, in inner
> result = function(command, **kwargs)
> File "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 92, in checked_call
> tries=tries, try_sleep=try_sleep)
> File "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 140, in _call_wrapper
> result = _call(command, **kwargs_copy)
> File "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 291, in _call
> raise Fail(err_msg)
> resource_management.core.exceptions.Fail: Execution of 'ambari-sudo.sh ln -s /usr/lib/storm/lib/ambari-metrics-storm-sink*.jar /usr/hdp/current/storm-nimbus/lib/ambari-metrics-storm-sink.jar' returned 1. ln: target `/usr/hdp/current/storm-nimbus/lib/ambari-metrics-storm-sink.jar' is not a directory
> {code}
>
> Perhaps because there are two files that satisfy the wildcard:
> {code}
> ls /usr/lib/storm/lib/ambari-metrics-storm-sink*.jar
> /usr/lib/storm/lib/ambari-metrics-storm-sink.jar /usr/lib/storm/lib/ambari-metrics-storm-sink-with-common-2.2.0.0.1262.jar
> {code}
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/storm.py 4e97c65
>
> Diff: https://reviews.apache.org/r/41217/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
> Checked upgrade on live cluster
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 41217: RESTART STORM/NIMBUS fails during EU,
2.1 --> 2.3
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
> On Dec. 10, 2015, 8:51 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/storm.py, line 101
> > <https://reviews.apache.org/r/41217/diff/1/?file=1158956#file1158956line101>
> >
> > +1 to check the version.
> > When not in RU/EU, can use params.stack_version, otherwise, use params.version
please see the comment above
- Dmitro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41217/#review109828
-----------------------------------------------------------
On Dec. 10, 2015, 8:19 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41217/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2015, 8:19 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Jayush Luniya, and Nate Cole.
>
>
> Bugs: AMBARI-14326
> https://issues.apache.org/jira/browse/AMBARI-14326
>
>
> Repository: ambari
>
>
> Description
> -------
>
> {code}
> Traceback (most recent call last):
> File "/var/lib/ambari-agent/cache/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py", line 149, in <module>
> Nimbus().execute()
> File "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py", line 218, in execute
> method(env)
> File "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py", line 514, in restart
> self.start(env, upgrade_type=upgrade_type)
> File "/var/lib/ambari-agent/cache/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py", line 68, in start
> self.configure(env)
> File "/var/lib/ambari-agent/cache/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py", line 50, in configure
> storm("nimbus")
> File "/usr/lib/python2.6/site-packages/ambari_commons/os_family_impl.py", line 89, in thunk
> return fn(*args, **kwargs)
> File "/var/lib/ambari-agent/cache/common-services/STORM/0.9.1.2.1/package/scripts/storm.py", line 103, in storm
> only_if=format("ls {metric_collector_sink_jar}")
> File "/usr/lib/python2.6/site-packages/resource_management/core/base.py", line 154, in __init__
> self.env.run()
> File "/usr/lib/python2.6/site-packages/resource_management/core/environment.py", line 158, in run
> self.run_action(resource, action)
> File "/usr/lib/python2.6/site-packages/resource_management/core/environment.py", line 121, in run_action
> provider_action()
> File "/usr/lib/python2.6/site-packages/resource_management/core/providers/system.py", line 238, in action_run
> tries=self.resource.tries, try_sleep=self.resource.try_sleep)
> File "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 70, in inner
> result = function(command, **kwargs)
> File "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 92, in checked_call
> tries=tries, try_sleep=try_sleep)
> File "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 140, in _call_wrapper
> result = _call(command, **kwargs_copy)
> File "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 291, in _call
> raise Fail(err_msg)
> resource_management.core.exceptions.Fail: Execution of 'ambari-sudo.sh ln -s /usr/lib/storm/lib/ambari-metrics-storm-sink*.jar /usr/hdp/current/storm-nimbus/lib/ambari-metrics-storm-sink.jar' returned 1. ln: target `/usr/hdp/current/storm-nimbus/lib/ambari-metrics-storm-sink.jar' is not a directory
> {code}
>
> Perhaps because there are two files that satisfy the wildcard:
> {code}
> ls /usr/lib/storm/lib/ambari-metrics-storm-sink*.jar
> /usr/lib/storm/lib/ambari-metrics-storm-sink.jar /usr/lib/storm/lib/ambari-metrics-storm-sink-with-common-2.2.0.0.1262.jar
> {code}
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/storm.py 4e97c65
>
> Diff: https://reviews.apache.org/r/41217/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
> Checked upgrade on live cluster
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 41217: RESTART STORM/NIMBUS fails during EU,
2.1 --> 2.3
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41217/#review109828
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/storm.py (line 101)
<https://reviews.apache.org/r/41217/#comment169458>
+1 to check the version.
When not in RU/EU, can use params.stack_version, otherwise, use params.version
- Alejandro Fernandez
On Dec. 10, 2015, 6:19 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41217/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2015, 6:19 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Jayush Luniya, and Nate Cole.
>
>
> Bugs: AMBARI-14326
> https://issues.apache.org/jira/browse/AMBARI-14326
>
>
> Repository: ambari
>
>
> Description
> -------
>
> {code}
> Traceback (most recent call last):
> File "/var/lib/ambari-agent/cache/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py", line 149, in <module>
> Nimbus().execute()
> File "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py", line 218, in execute
> method(env)
> File "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py", line 514, in restart
> self.start(env, upgrade_type=upgrade_type)
> File "/var/lib/ambari-agent/cache/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py", line 68, in start
> self.configure(env)
> File "/var/lib/ambari-agent/cache/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py", line 50, in configure
> storm("nimbus")
> File "/usr/lib/python2.6/site-packages/ambari_commons/os_family_impl.py", line 89, in thunk
> return fn(*args, **kwargs)
> File "/var/lib/ambari-agent/cache/common-services/STORM/0.9.1.2.1/package/scripts/storm.py", line 103, in storm
> only_if=format("ls {metric_collector_sink_jar}")
> File "/usr/lib/python2.6/site-packages/resource_management/core/base.py", line 154, in __init__
> self.env.run()
> File "/usr/lib/python2.6/site-packages/resource_management/core/environment.py", line 158, in run
> self.run_action(resource, action)
> File "/usr/lib/python2.6/site-packages/resource_management/core/environment.py", line 121, in run_action
> provider_action()
> File "/usr/lib/python2.6/site-packages/resource_management/core/providers/system.py", line 238, in action_run
> tries=self.resource.tries, try_sleep=self.resource.try_sleep)
> File "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 70, in inner
> result = function(command, **kwargs)
> File "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 92, in checked_call
> tries=tries, try_sleep=try_sleep)
> File "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 140, in _call_wrapper
> result = _call(command, **kwargs_copy)
> File "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 291, in _call
> raise Fail(err_msg)
> resource_management.core.exceptions.Fail: Execution of 'ambari-sudo.sh ln -s /usr/lib/storm/lib/ambari-metrics-storm-sink*.jar /usr/hdp/current/storm-nimbus/lib/ambari-metrics-storm-sink.jar' returned 1. ln: target `/usr/hdp/current/storm-nimbus/lib/ambari-metrics-storm-sink.jar' is not a directory
> {code}
>
> Perhaps because there are two files that satisfy the wildcard:
> {code}
> ls /usr/lib/storm/lib/ambari-metrics-storm-sink*.jar
> /usr/lib/storm/lib/ambari-metrics-storm-sink.jar /usr/lib/storm/lib/ambari-metrics-storm-sink-with-common-2.2.0.0.1262.jar
> {code}
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/storm.py 4e97c65
>
> Diff: https://reviews.apache.org/r/41217/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
> Checked upgrade on live cluster
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 41217: RESTART STORM/NIMBUS fails during EU,
2.1 --> 2.3
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41217/
-----------------------------------------------------------
(Updated Dec. 10, 2015, 8:19 p.m.)
Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Jayush Luniya, and Nate Cole.
Bugs: AMBARI-14326
https://issues.apache.org/jira/browse/AMBARI-14326
Repository: ambari
Description
-------
{code}
Traceback (most recent call last):
File "/var/lib/ambari-agent/cache/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py", line 149, in <module>
Nimbus().execute()
File "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py", line 218, in execute
method(env)
File "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py", line 514, in restart
self.start(env, upgrade_type=upgrade_type)
File "/var/lib/ambari-agent/cache/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py", line 68, in start
self.configure(env)
File "/var/lib/ambari-agent/cache/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py", line 50, in configure
storm("nimbus")
File "/usr/lib/python2.6/site-packages/ambari_commons/os_family_impl.py", line 89, in thunk
return fn(*args, **kwargs)
File "/var/lib/ambari-agent/cache/common-services/STORM/0.9.1.2.1/package/scripts/storm.py", line 103, in storm
only_if=format("ls {metric_collector_sink_jar}")
File "/usr/lib/python2.6/site-packages/resource_management/core/base.py", line 154, in __init__
self.env.run()
File "/usr/lib/python2.6/site-packages/resource_management/core/environment.py", line 158, in run
self.run_action(resource, action)
File "/usr/lib/python2.6/site-packages/resource_management/core/environment.py", line 121, in run_action
provider_action()
File "/usr/lib/python2.6/site-packages/resource_management/core/providers/system.py", line 238, in action_run
tries=self.resource.tries, try_sleep=self.resource.try_sleep)
File "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 70, in inner
result = function(command, **kwargs)
File "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 92, in checked_call
tries=tries, try_sleep=try_sleep)
File "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 140, in _call_wrapper
result = _call(command, **kwargs_copy)
File "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 291, in _call
raise Fail(err_msg)
resource_management.core.exceptions.Fail: Execution of 'ambari-sudo.sh ln -s /usr/lib/storm/lib/ambari-metrics-storm-sink*.jar /usr/hdp/current/storm-nimbus/lib/ambari-metrics-storm-sink.jar' returned 1. ln: target `/usr/hdp/current/storm-nimbus/lib/ambari-metrics-storm-sink.jar' is not a directory
{code}
Perhaps because there are two files that satisfy the wildcard:
{code}
ls /usr/lib/storm/lib/ambari-metrics-storm-sink*.jar
/usr/lib/storm/lib/ambari-metrics-storm-sink.jar /usr/lib/storm/lib/ambari-metrics-storm-sink-with-common-2.2.0.0.1262.jar
{code}
Diffs
-----
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/storm.py 4e97c65
Diff: https://reviews.apache.org/r/41217/diff/
Testing (updated)
-------
mvn clean test
Checked upgrade on live cluster
Thanks,
Dmitro Lisnichenko