You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/05/10 22:02:43 UTC

[GitHub] [ozone] adoroszlai opened a new pull request #2233: HDDS-5207. Intermittent failure in TestRatisPipelineProvider#testCreatePipelineWithFactorThree

adoroszlai opened a new pull request #2233:
URL: https://github.com/apache/ozone/pull/2233


   ## What changes were proposed in this pull request?
   
   `testCreatePipelineWithFactorThree` fails intermittently with two 3-nodes pipeline being assigned to the same set of nodes, while only a single pipeline per datanode is allowed.  The problem is that `MockNodeManager` ignores this config and has a separate variable, which tests need to set.  Similar setting in other test:
   
   https://github.com/apache/ozone/blob/8e8a01dfd20899cd9dc95ab3de744b636a807ab2/hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/pipeline/TestPipelinePlacementPolicy.java#L91-L92
   
   https://issues.apache.org/jira/browse/HDDS-5207
   
   ## How was this patch tested?
   
   100x repeated `TestRatisPipelineProvider`:
   https://github.com/adoroszlai/hadoop-ozone/runs/2549825702
   
   Regular CI:
   https://github.com/adoroszlai/hadoop-ozone/actions/runs/829491474


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


[GitHub] [ozone] adoroszlai commented on pull request #2233: HDDS-5207. Intermittent failure in TestRatisPipelineProvider#testCreatePipelineWithFactorThree

Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #2233:
URL: https://github.com/apache/ozone/pull/2233#issuecomment-837906361


   Thanks @GlenGeng and @bshashikant for the review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


[GitHub] [ozone] bshashikant merged pull request #2233: HDDS-5207. Intermittent failure in TestRatisPipelineProvider#testCreatePipelineWithFactorThree

Posted by GitBox <gi...@apache.org>.
bshashikant merged pull request #2233:
URL: https://github.com/apache/ozone/pull/2233


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


[GitHub] [ozone] GlenGeng commented on pull request #2233: HDDS-5207. Intermittent failure in TestRatisPipelineProvider#testCreatePipelineWithFactorThree

Posted by GitBox <gi...@apache.org>.
GlenGeng commented on pull request #2233:
URL: https://github.com/apache/ozone/pull/2233#issuecomment-837656938


   +1. 
   Thanks @adoroszlai for the effort to stabilize the CI. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


[GitHub] [ozone] bshashikant commented on pull request #2233: HDDS-5207. Intermittent failure in TestRatisPipelineProvider#testCreatePipelineWithFactorThree

Posted by GitBox <gi...@apache.org>.
bshashikant commented on pull request #2233:
URL: https://github.com/apache/ozone/pull/2233#issuecomment-837847310


   Thanks @adoroszlai for the fix and @GlenGeng for the review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org