You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jackrabbit.apache.org by re...@apache.org on 2011/11/29 21:55:32 UTC

svn commit: r1208060 - in /jackrabbit/trunk: jackrabbit-core/pom.xml jackrabbit-parent/pom.xml

Author: reschke
Date: Tue Nov 29 20:55:32 2011
New Revision: 1208060

URL: http://svn.apache.org/viewvc?rev=1208060&view=rev
Log:
revert change 1205866 which might be the cause for the failing spi2jcr query tests

Modified:
    jackrabbit/trunk/jackrabbit-core/pom.xml
    jackrabbit/trunk/jackrabbit-parent/pom.xml

Modified: jackrabbit/trunk/jackrabbit-core/pom.xml
URL: http://svn.apache.org/viewvc/jackrabbit/trunk/jackrabbit-core/pom.xml?rev=1208060&r1=1208059&r2=1208060&view=diff
==============================================================================
--- jackrabbit/trunk/jackrabbit-core/pom.xml (original)
+++ jackrabbit/trunk/jackrabbit-core/pom.xml Tue Nov 29 20:55:32 2011
@@ -74,7 +74,6 @@
           <includes>
             <include>**/*TestAll.java</include>
           </includes>
-          <runOrder>alphabetical</runOrder>
           <argLine>-Xmx256m</argLine>
           <systemProperties>
             <property>

Modified: jackrabbit/trunk/jackrabbit-parent/pom.xml
URL: http://svn.apache.org/viewvc/jackrabbit/trunk/jackrabbit-parent/pom.xml?rev=1208060&r1=1208059&r2=1208060&view=diff
==============================================================================
--- jackrabbit/trunk/jackrabbit-parent/pom.xml (original)
+++ jackrabbit/trunk/jackrabbit-parent/pom.xml Tue Nov 29 20:55:32 2011
@@ -204,6 +204,10 @@
           </configuration>
         </plugin>
         <plugin>
+          <artifactId>maven-surefire-plugin</artifactId>
+          <version>2.4.3</version>
+        </plugin>
+        <plugin>
           <artifactId>maven-failsafe-plugin</artifactId>
           <version>2.10</version>
         </plugin>



Re: svn commit: r1208060 - in /jackrabbit/trunk: jackrabbit-core/pom.xml jackrabbit-parent/pom.xml

Posted by Julian Reschke <ju...@gmx.de>.
On 2011-11-29 23:10, Jukka Zitting wrote:
> Hi,
>
> On Tue, Nov 29, 2011 at 9:55 PM,<re...@apache.org>  wrote:
>> revert change 1205866 which might be the cause for the failing
>> spi2jcr query tests
>
> Thanks, I'll look deeper into this tomorrow.
>
> I made the change in revision 1205866 in an effort to work around the
> ACL import test failure before cutting the 2.3.4 candidate, but as
> discussed since then that change didn't even solve the issue entirely.
> Thus its best for now to have the change reverted.
>
> Anyway, our test suite shouldn't really depend on the ordering of
> tests. Or if it does, then such ordering should be explicitly
> declared. I'll see if I can track down the causes of such ordering
> issues.
> ...

Agreed. Now that we have a hint about what's going on, we should be able 
to fix it.

Best regards, Julian

Re: svn commit: r1208060 - in /jackrabbit/trunk: jackrabbit-core/pom.xml jackrabbit-parent/pom.xml

Posted by Jukka Zitting <ju...@gmail.com>.
Hi,

On Tue, Nov 29, 2011 at 9:55 PM,  <re...@apache.org> wrote:
> revert change 1205866 which might be the cause for the failing
> spi2jcr query tests

Thanks, I'll look deeper into this tomorrow.

I made the change in revision 1205866 in an effort to work around the
ACL import test failure before cutting the 2.3.4 candidate, but as
discussed since then that change didn't even solve the issue entirely.
Thus its best for now to have the change reverted.

Anyway, our test suite shouldn't really depend on the ordering of
tests. Or if it does, then such ordering should be explicitly
declared. I'll see if I can track down the causes of such ordering
issues.

BR,

Jukka Zitting