You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/01/11 16:20:55 UTC

[GitHub] [incubator-nuttx] hartmannathan commented on a change in pull request #5201: inline: switch from inline to inline_function

hartmannathan commented on a change in pull request #5201:
URL: https://github.com/apache/incubator-nuttx/pull/5201#discussion_r782311674



##########
File path: arch/arm/include/armv6-m/irq.h
##########
@@ -219,8 +219,7 @@ struct xcptcontext
 
 /* Get/set the PRIMASK register */
 
-static inline uint8_t getprimask(void) inline_function;
-static inline uint8_t getprimask(void)
+inline_function static uint8_t getprimask(void)

Review comment:
       I think it would be a good thing to pass -std=c89 on common files in the precheck. Then if someone inadvertently uses C99 in common files, it will be noticed immediately.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org