You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/01/14 13:59:09 UTC
[GitHub] [airflow] potiuk opened a new pull request #7162: [AIRFLOW-6557]
Add test for newly added fields in BaseOperator
potiuk opened a new pull request #7162: [AIRFLOW-6557] Add test for newly added fields in BaseOperator
URL: https://github.com/apache/airflow/pull/7162
Adding new field in BaseOperator requires some manual updates
in serialization code. This test detects new fields and informs
what should be done in case new field is added.
---
Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
<sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #7162: [AIRFLOW-6557] Add
test for newly added fields in BaseOperator
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #7162: [AIRFLOW-6557] Add test for newly added fields in BaseOperator
URL: https://github.com/apache/airflow/pull/7162#issuecomment-574227743
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7162?src=pr&el=h1) Report
> Merging [#7162](https://codecov.io/gh/apache/airflow/pull/7162?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/389f68cb9109dc658b5ee2bf0a47a79afef8714b?src=pr&el=desc) will **decrease** coverage by `0.54%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/7162?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7162 +/- ##
==========================================
- Coverage 85.45% 84.91% -0.55%
==========================================
Files 710 710
Lines 39474 39475 +1
==========================================
- Hits 33734 33520 -214
- Misses 5740 5955 +215
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7162?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/operators/mysql\_operator.py](https://codecov.io/gh/apache/airflow/pull/7162/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvbXlzcWxfb3BlcmF0b3IucHk=) | `0% <0%> (-100%)` | :arrow_down: |
| [airflow/operators/mysql\_to\_hive.py](https://codecov.io/gh/apache/airflow/pull/7162/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvbXlzcWxfdG9faGl2ZS5weQ==) | `0% <0%> (-100%)` | :arrow_down: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7162/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7162/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7162/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/security/kerberos.py](https://codecov.io/gh/apache/airflow/pull/7162/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZWN1cml0eS9rZXJiZXJvcy5weQ==) | `30.43% <0%> (-45.66%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7162/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7162/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.31% <0%> (-20.49%)` | :arrow_down: |
| [airflow/providers/apache/druid/operators/druid.py](https://codecov.io/gh/apache/airflow/pull/7162/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2RydWlkL29wZXJhdG9ycy9kcnVpZC5weQ==) | `82.35% <0%> (-1.86%)` | :arrow_down: |
| [airflow/providers/apache/hive/hooks/hive.py](https://codecov.io/gh/apache/airflow/pull/7162/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2hpdmUvaG9va3MvaGl2ZS5weQ==) | `76.02% <0%> (-1.54%)` | :arrow_down: |
| ... and [4 more](https://codecov.io/gh/apache/airflow/pull/7162/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7162?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7162?src=pr&el=footer). Last update [389f68c...8ad2704](https://codecov.io/gh/apache/airflow/pull/7162?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7162:
[AIRFLOW-6557] Add test for newly added fields in BaseOperator
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7162: [AIRFLOW-6557] Add test for newly added fields in BaseOperator
URL: https://github.com/apache/airflow/pull/7162#issuecomment-574227743
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7162?src=pr&el=h1) Report
> Merging [#7162](https://codecov.io/gh/apache/airflow/pull/7162?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/389f68cb9109dc658b5ee2bf0a47a79afef8714b?src=pr&el=desc) will **decrease** coverage by `0.54%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/7162?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7162 +/- ##
==========================================
- Coverage 85.45% 84.91% -0.55%
==========================================
Files 710 710
Lines 39474 39475 +1
==========================================
- Hits 33734 33520 -214
- Misses 5740 5955 +215
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7162?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/operators/mysql\_operator.py](https://codecov.io/gh/apache/airflow/pull/7162/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvbXlzcWxfb3BlcmF0b3IucHk=) | `0% <0%> (-100%)` | :arrow_down: |
| [airflow/operators/mysql\_to\_hive.py](https://codecov.io/gh/apache/airflow/pull/7162/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvbXlzcWxfdG9faGl2ZS5weQ==) | `0% <0%> (-100%)` | :arrow_down: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7162/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7162/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7162/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/security/kerberos.py](https://codecov.io/gh/apache/airflow/pull/7162/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZWN1cml0eS9rZXJiZXJvcy5weQ==) | `30.43% <0%> (-45.66%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7162/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7162/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.31% <0%> (-20.49%)` | :arrow_down: |
| [airflow/providers/apache/druid/operators/druid.py](https://codecov.io/gh/apache/airflow/pull/7162/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2RydWlkL29wZXJhdG9ycy9kcnVpZC5weQ==) | `82.35% <0%> (-1.86%)` | :arrow_down: |
| [airflow/providers/apache/hive/hooks/hive.py](https://codecov.io/gh/apache/airflow/pull/7162/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2hpdmUvaG9va3MvaGl2ZS5weQ==) | `76.02% <0%> (-1.54%)` | :arrow_down: |
| ... and [4 more](https://codecov.io/gh/apache/airflow/pull/7162/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7162?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7162?src=pr&el=footer). Last update [389f68c...8ad2704](https://codecov.io/gh/apache/airflow/pull/7162?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] ashb commented on a change in pull request #7162:
[AIRFLOW-6557] Add test for newly added fields in BaseOperator
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #7162: [AIRFLOW-6557] Add test for newly added fields in BaseOperator
URL: https://github.com/apache/airflow/pull/7162#discussion_r367051937
##########
File path: tests/serialization/test_dag_serialization.py
##########
@@ -543,6 +543,66 @@ def test_dag_serialized_fields_with_schema(self):
dag_params: set = set(dag_schema.keys()) - ignored_keys
self.assertEqual(set(DAG.get_serialized_fields()), dag_params)
+ def test_no_new_fields_added_to_base_operator(self):
+ """
+ This test verifies that there are no new fields added to BaseOperator. And reminds that
+ tests should be added for it.
+ """
+ base_operator = BaseOperator(task_id="10")
+ fields = base_operator.__dict__
+ self.assertEqual({'_dag': None,
+ '_downstream_task_ids': set(),
+ '_inlets': [],
+ '_log': base_operator.log,
+ '_outlets': [],
+ '_upstream_task_ids': set(),
+ 'depends_on_past': False,
+ 'do_xcom_push': True,
+ 'email': None,
+ 'email_on_failure': True,
+ 'email_on_retry': True,
+ 'end_date': None,
+ 'execution_timeout': None,
+ 'executor_config': {},
+ 'inlets': [],
+ 'max_retry_delay': None,
+ 'on_execute_callback': None,
+ 'on_failure_callback': None,
+ 'on_retry_callback': None,
+ 'on_success_callback': None,
+ 'outlets': [],
+ 'owner': 'airflow',
+ 'params': {},
+ 'pool': 'default_pool',
+ 'priority_weight': 1,
+ 'queue': 'default',
+ 'resources': None,
+ 'retries': 0,
+ 'retry_delay': timedelta(0, 300),
+ 'retry_exponential_backoff': False,
+ 'run_as_user': None,
+ 'sla': None,
+ 'start_date': None,
+ 'subdag': None,
+ 'task_concurrency': None,
+ 'task_id': '10',
+ 'trigger_rule': 'all_success',
+ 'wait_for_downstream': False,
+ 'weight_rule': 'downstream'}, fields,
+ """
+!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
+
+ ACTION NEEDED! PLEASE READ THIS CAREFULLY AND CORRECT TESTS CAREFULLY
+
+ Some fields were added to the BaseOperator! Please add them to the list above and make sure that
+ you add support for DAG serialization - you should add the field to
+ `airflow/serialization/schema.json` and add it in `serialized_simple_dag_ground_truth` above
Review comment:
So the goal of the ground truth test is to ensure that DAGs that are _currently_ in people's databases get correctly handled as the model changes. The important bit I think is that this data can't change sa it's fixed in a DB.
_But_ some changes such as adding an optional field to Operators/Tasks is allowed, as the JSON Schema allows unknown fields at the task level.
But by default BaseOperator.get_serialized_fields will include extra fields. So I guess the only check I would like here is that new fields from base operator get specified with a type in the JSON schema, and that it sohuld be optional (if it's not optional then we would have to bump the version field in our schema. But we haven't worked out how to handle versioning of schemas and blobs yet!) -- which is sadly harder to test for.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7162:
[AIRFLOW-6557] Add test for newly added fields in BaseOperator
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7162: [AIRFLOW-6557] Add test for newly added fields in BaseOperator
URL: https://github.com/apache/airflow/pull/7162#issuecomment-574227743
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7162?src=pr&el=h1) Report
> Merging [#7162](https://codecov.io/gh/apache/airflow/pull/7162?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/b38766e83495803e0a95912aaa25d727938fc9c1?src=pr&el=desc) will **decrease** coverage by `52.15%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/7162?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7162 +/- ##
===========================================
- Coverage 84.94% 32.79% -52.16%
===========================================
Files 723 722 -1
Lines 39537 39524 -13
===========================================
- Hits 33585 12961 -20624
- Misses 5952 26563 +20611
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7162?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...low/contrib/operators/wasb\_delete\_blob\_operator.py](https://codecov.io/gh/apache/airflow/pull/7162/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy93YXNiX2RlbGV0ZV9ibG9iX29wZXJhdG9yLnB5) | `0% <0%> (-100%)` | :arrow_down: |
| [...flow/contrib/example\_dags/example\_qubole\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7162/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2V4YW1wbGVfZGFncy9leGFtcGxlX3F1Ym9sZV9zZW5zb3IucHk=) | `0% <0%> (-100%)` | :arrow_down: |
| [...ample\_dags/example\_emr\_job\_flow\_automatic\_steps.py](https://codecov.io/gh/apache/airflow/pull/7162/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2V4YW1wbGVfZGFncy9leGFtcGxlX2Vtcl9qb2JfZmxvd19hdXRvbWF0aWNfc3RlcHMucHk=) | `0% <0%> (-100%)` | :arrow_down: |
| [...contrib/example\_dags/example\_papermill\_operator.py](https://codecov.io/gh/apache/airflow/pull/7162/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2V4YW1wbGVfZGFncy9leGFtcGxlX3BhcGVybWlsbF9vcGVyYXRvci5weQ==) | `0% <0%> (-100%)` | :arrow_down: |
| [airflow/hooks/webhdfs\_hook.py](https://codecov.io/gh/apache/airflow/pull/7162/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy93ZWJoZGZzX2hvb2sucHk=) | `0% <0%> (-100%)` | :arrow_down: |
| [airflow/contrib/operators/gcs\_list\_operator.py](https://codecov.io/gh/apache/airflow/pull/7162/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3NfbGlzdF9vcGVyYXRvci5weQ==) | `0% <0%> (-100%)` | :arrow_down: |
| [airflow/operators/pig\_operator.py](https://codecov.io/gh/apache/airflow/pull/7162/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvcGlnX29wZXJhdG9yLnB5) | `0% <0%> (-100%)` | :arrow_down: |
| [airflow/contrib/operators/file\_to\_gcs.py](https://codecov.io/gh/apache/airflow/pull/7162/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9maWxlX3RvX2djcy5weQ==) | `0% <0%> (-100%)` | :arrow_down: |
| [airflow/contrib/hooks/gcp\_spanner\_hook.py](https://codecov.io/gh/apache/airflow/pull/7162/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2djcF9zcGFubmVyX2hvb2sucHk=) | `0% <0%> (-100%)` | :arrow_down: |
| [airflow/operators/hive\_operator.py](https://codecov.io/gh/apache/airflow/pull/7162/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvaGl2ZV9vcGVyYXRvci5weQ==) | `0% <0%> (-100%)` | :arrow_down: |
| ... and [582 more](https://codecov.io/gh/apache/airflow/pull/7162/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7162?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7162?src=pr&el=footer). Last update [b38766e...2acd697](https://codecov.io/gh/apache/airflow/pull/7162?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #7162: [AIRFLOW-6557] Add test
for newly added fields in BaseOperator
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #7162: [AIRFLOW-6557] Add test for newly added fields in BaseOperator
URL: https://github.com/apache/airflow/pull/7162#issuecomment-574854810
> 
>
> :) The bot caught you @potiuk
Good bot! Nice bot!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7162:
[AIRFLOW-6557] Add test for newly added fields in BaseOperator
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7162: [AIRFLOW-6557] Add test for newly added fields in BaseOperator
URL: https://github.com/apache/airflow/pull/7162#issuecomment-574227743
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7162?src=pr&el=h1) Report
> Merging [#7162](https://codecov.io/gh/apache/airflow/pull/7162?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/389f68cb9109dc658b5ee2bf0a47a79afef8714b?src=pr&el=desc) will **decrease** coverage by `0.28%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/7162?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7162 +/- ##
==========================================
- Coverage 85.45% 85.17% -0.29%
==========================================
Files 710 710
Lines 39474 39475 +1
==========================================
- Hits 33734 33624 -110
- Misses 5740 5851 +111
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7162?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7162/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7162/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7162/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7162/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7162/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.31% <0%> (-20.49%)` | :arrow_down: |
| [airflow/providers/apache/druid/operators/druid.py](https://codecov.io/gh/apache/airflow/pull/7162/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2RydWlkL29wZXJhdG9ycy9kcnVpZC5weQ==) | `82.35% <0%> (-1.86%)` | :arrow_down: |
| [airflow/utils/log/s3\_task\_handler.py](https://codecov.io/gh/apache/airflow/pull/7162/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9sb2cvczNfdGFza19oYW5kbGVyLnB5) | `98.57% <0%> (+0.06%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7162?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7162?src=pr&el=footer). Last update [389f68c...8ad2704](https://codecov.io/gh/apache/airflow/pull/7162?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on a change in pull request #7162:
[AIRFLOW-6557] Add test for newly added fields in BaseOperator
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #7162: [AIRFLOW-6557] Add test for newly added fields in BaseOperator
URL: https://github.com/apache/airflow/pull/7162#discussion_r366367086
##########
File path: tests/serialization/test_dag_serialization.py
##########
@@ -543,6 +543,66 @@ def test_dag_serialized_fields_with_schema(self):
dag_params: set = set(dag_schema.keys()) - ignored_keys
self.assertEqual(set(DAG.get_serialized_fields()), dag_params)
+ def test_no_new_fields_added_to_base_operator(self):
+ """
+ This test verifies that there are no new fields added to BaseOperator. And reminds that
+ tests should be added for it.
+ """
+ base_operator = BaseOperator(task_id="10")
+ fields = base_operator.__dict__
+ self.assertEqual({'_dag': None,
+ '_downstream_task_ids': set(),
+ '_inlets': [],
+ '_log': base_operator.log,
+ '_outlets': [],
+ '_upstream_task_ids': set(),
+ 'depends_on_past': False,
+ 'do_xcom_push': True,
+ 'email': None,
+ 'email_on_failure': True,
+ 'email_on_retry': True,
+ 'end_date': None,
+ 'execution_timeout': None,
+ 'executor_config': {},
+ 'inlets': [],
+ 'max_retry_delay': None,
+ 'on_execute_callback': None,
+ 'on_failure_callback': None,
+ 'on_retry_callback': None,
+ 'on_success_callback': None,
+ 'outlets': [],
+ 'owner': 'airflow',
+ 'params': {},
+ 'pool': 'default_pool',
+ 'priority_weight': 1,
+ 'queue': 'default',
+ 'resources': None,
+ 'retries': 0,
+ 'retry_delay': timedelta(0, 300),
+ 'retry_exponential_backoff': False,
+ 'run_as_user': None,
+ 'sla': None,
+ 'start_date': None,
+ 'subdag': None,
+ 'task_concurrency': None,
+ 'task_id': '10',
+ 'trigger_rule': 'all_success',
+ 'wait_for_downstream': False,
+ 'weight_rule': 'downstream'}, fields,
+ """
+!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
+
+ ACTION NEEDED! PLEASE READ THIS CAREFULLY AND CORRECT TESTS CAREFULLY
+
+ Some fields were added to the BaseOperator! Please add them to the list above and make sure that
+ you add support for DAG serialization - you should add the field to
+ `airflow/serialization/schema.json` and add it in `serialized_simple_dag_ground_truth` above
Review comment:
I think then we need to decide what to do in this case and tell @lokeshlal what to do in this case: https://github.com/apache/airflow/pull/7162 (and update this description).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on a change in pull request #7162:
[AIRFLOW-6557] Add test for newly added fields in BaseOperator
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #7162: [AIRFLOW-6557] Add test for newly added fields in BaseOperator
URL: https://github.com/apache/airflow/pull/7162#discussion_r367100569
##########
File path: tests/serialization/test_dag_serialization.py
##########
@@ -543,6 +543,66 @@ def test_dag_serialized_fields_with_schema(self):
dag_params: set = set(dag_schema.keys()) - ignored_keys
self.assertEqual(set(DAG.get_serialized_fields()), dag_params)
+ def test_no_new_fields_added_to_base_operator(self):
+ """
+ This test verifies that there are no new fields added to BaseOperator. And reminds that
+ tests should be added for it.
+ """
+ base_operator = BaseOperator(task_id="10")
+ fields = base_operator.__dict__
+ self.assertEqual({'_dag': None,
+ '_downstream_task_ids': set(),
+ '_inlets': [],
+ '_log': base_operator.log,
+ '_outlets': [],
+ '_upstream_task_ids': set(),
+ 'depends_on_past': False,
+ 'do_xcom_push': True,
+ 'email': None,
+ 'email_on_failure': True,
+ 'email_on_retry': True,
+ 'end_date': None,
+ 'execution_timeout': None,
+ 'executor_config': {},
+ 'inlets': [],
+ 'max_retry_delay': None,
+ 'on_execute_callback': None,
+ 'on_failure_callback': None,
+ 'on_retry_callback': None,
+ 'on_success_callback': None,
+ 'outlets': [],
+ 'owner': 'airflow',
+ 'params': {},
+ 'pool': 'default_pool',
+ 'priority_weight': 1,
+ 'queue': 'default',
+ 'resources': None,
+ 'retries': 0,
+ 'retry_delay': timedelta(0, 300),
+ 'retry_exponential_backoff': False,
+ 'run_as_user': None,
+ 'sla': None,
+ 'start_date': None,
+ 'subdag': None,
+ 'task_concurrency': None,
+ 'task_id': '10',
+ 'trigger_rule': 'all_success',
+ 'wait_for_downstream': False,
+ 'weight_rule': 'downstream'}, fields,
+ """
+!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
+
+ ACTION NEEDED! PLEASE READ THIS CAREFULLY AND CORRECT TESTS CAREFULLY
+
+ Some fields were added to the BaseOperator! Please add them to the list above and make sure that
+ you add support for DAG serialization - you should add the field to
+ `airflow/serialization/schema.json` and add it in `serialized_simple_dag_ground_truth` above
Review comment:
Similar rules as for protobuf. I will modify the message. We cannot test a lot of that fully automatically yet but we can at least provide the right message.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil commented on issue #7162: [AIRFLOW-6557] Add test
for newly added fields in BaseOperator
Posted by GitBox <gi...@apache.org>.
kaxil commented on issue #7162: [AIRFLOW-6557] Add test for newly added fields in BaseOperator
URL: https://github.com/apache/airflow/pull/7162#issuecomment-575729720
@bolkedebruin
Would be curious to know why you feel so? And what would you recommend as an alternative?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] ashb commented on a change in pull request #7162:
[AIRFLOW-6557] Add test for newly added fields in BaseOperator
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #7162: [AIRFLOW-6557] Add test for newly added fields in BaseOperator
URL: https://github.com/apache/airflow/pull/7162#discussion_r366358285
##########
File path: tests/serialization/test_dag_serialization.py
##########
@@ -543,6 +543,66 @@ def test_dag_serialized_fields_with_schema(self):
dag_params: set = set(dag_schema.keys()) - ignored_keys
self.assertEqual(set(DAG.get_serialized_fields()), dag_params)
+ def test_no_new_fields_added_to_base_operator(self):
+ """
+ This test verifies that there are no new fields added to BaseOperator. And reminds that
+ tests should be added for it.
+ """
+ base_operator = BaseOperator(task_id="10")
+ fields = base_operator.__dict__
+ self.assertEqual({'_dag': None,
+ '_downstream_task_ids': set(),
+ '_inlets': [],
+ '_log': base_operator.log,
+ '_outlets': [],
+ '_upstream_task_ids': set(),
+ 'depends_on_past': False,
+ 'do_xcom_push': True,
+ 'email': None,
+ 'email_on_failure': True,
+ 'email_on_retry': True,
+ 'end_date': None,
+ 'execution_timeout': None,
+ 'executor_config': {},
+ 'inlets': [],
+ 'max_retry_delay': None,
+ 'on_execute_callback': None,
+ 'on_failure_callback': None,
+ 'on_retry_callback': None,
+ 'on_success_callback': None,
+ 'outlets': [],
+ 'owner': 'airflow',
+ 'params': {},
+ 'pool': 'default_pool',
+ 'priority_weight': 1,
+ 'queue': 'default',
+ 'resources': None,
+ 'retries': 0,
+ 'retry_delay': timedelta(0, 300),
+ 'retry_exponential_backoff': False,
+ 'run_as_user': None,
+ 'sla': None,
+ 'start_date': None,
+ 'subdag': None,
+ 'task_concurrency': None,
+ 'task_id': '10',
+ 'trigger_rule': 'all_success',
+ 'wait_for_downstream': False,
+ 'weight_rule': 'downstream'}, fields,
+ """
+!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
+
+ ACTION NEEDED! PLEASE READ THIS CAREFULLY AND CORRECT TESTS CAREFULLY
+
+ Some fields were added to the BaseOperator! Please add them to the list above and make sure that
+ you add support for DAG serialization - you should add the field to
+ `airflow/serialization/schema.json` and add it in `serialized_simple_dag_ground_truth` above
Review comment:
Having said that I'm now not sure this last part is true.
So since DAG serialization schema version 1.0 is now released with 1.10.7 we might have to start thinking about versioning of this schema and migrate/update. But the important bit is that a row that exists in the DB right now must continue to work and that is what the "ground truth" (not the best name) is meant to represent.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on a change in pull request #7162:
[AIRFLOW-6557] Add test for newly added fields in BaseOperator
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #7162: [AIRFLOW-6557] Add test for newly added fields in BaseOperator
URL: https://github.com/apache/airflow/pull/7162#discussion_r367413700
##########
File path: tests/serialization/test_dag_serialization.py
##########
@@ -543,6 +543,68 @@ def test_dag_serialized_fields_with_schema(self):
dag_params: set = set(dag_schema.keys()) - ignored_keys
self.assertEqual(set(DAG.get_serialized_fields()), dag_params)
+ def test_no_new_fields_added_to_base_operator(self):
+ """
+ This test verifies that there are no new fields added to BaseOperator. And reminds that
+ tests should be added for it.
+ """
+ base_operator = BaseOperator(task_id="10")
+ fields = base_operator.__dict__
+ self.assertEqual({'_dag': None,
+ '_downstream_task_ids': set(),
+ '_inlets': [],
+ '_log': base_operator.log,
+ '_outlets': [],
+ '_upstream_task_ids': set(),
+ 'depends_on_past': False,
+ 'do_xcom_push': True,
+ 'email': None,
+ 'email_on_failure': True,
+ 'email_on_retry': True,
+ 'end_date': None,
+ 'execution_timeout': None,
+ 'executor_config': {},
+ 'inlets': [],
+ 'max_retry_delay': None,
+ 'on_execute_callback': None,
+ 'on_failure_callback': None,
+ 'on_retry_callback': None,
+ 'on_success_callback': None,
+ 'outlets': [],
+ 'owner': 'airflow',
+ 'params': {},
+ 'pool': 'default_pool',
+ 'priority_weight': 1,
+ 'queue': 'default',
+ 'resources': None,
+ 'retries': 0,
+ 'retry_delay': timedelta(0, 300),
+ 'retry_exponential_backoff': False,
+ 'run_as_user': None,
+ 'sla': None,
+ 'start_date': None,
+ 'subdag': None,
+ 'task_concurrency': None,
+ 'task_id': '10',
+ 'trigger_rule': 'all_success',
+ 'wait_for_downstream': False,
+ 'weight_rule': 'downstream'}, fields,
+ """
+!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
+
+ ACTION NEEDED! PLEASE READ THIS CAREFULLY AND CORRECT TESTS CAREFULLY
+
+ Some fields were added to the BaseOperator! Please add them to the list above and make sure that
+ you add support for DAG serialization - you should add the field to
+ `airflow/serialization/schema.json` - they should have correct type defined there.
+
+ Note that we do not support versioning yet so you should only add optional fields. We do not support
Review comment:
```suggestion
Note that we do not support versioning yet so you should only add optional fields.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7162:
[AIRFLOW-6557] Add test for newly added fields in BaseOperator
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7162: [AIRFLOW-6557] Add test for newly added fields in BaseOperator
URL: https://github.com/apache/airflow/pull/7162#issuecomment-574227743
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7162?src=pr&el=h1) Report
> Merging [#7162](https://codecov.io/gh/apache/airflow/pull/7162?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/b38766e83495803e0a95912aaa25d727938fc9c1?src=pr&el=desc) will **decrease** coverage by `0.28%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/7162?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7162 +/- ##
==========================================
- Coverage 85.4% 85.12% -0.29%
==========================================
Files 723 723
Lines 39537 39537
==========================================
- Hits 33768 33657 -111
- Misses 5769 5880 +111
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7162?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7162/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7162/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7162/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7162/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7162/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.31% <0%> (-20.49%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7162?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7162?src=pr&el=footer). Last update [b38766e...2acd697](https://codecov.io/gh/apache/airflow/pull/7162?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] ashb commented on a change in pull request #7162:
[AIRFLOW-6557] Add test for newly added fields in BaseOperator
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #7162: [AIRFLOW-6557] Add test for newly added fields in BaseOperator
URL: https://github.com/apache/airflow/pull/7162#discussion_r367384009
##########
File path: tests/serialization/test_dag_serialization.py
##########
@@ -543,6 +543,68 @@ def test_dag_serialized_fields_with_schema(self):
dag_params: set = set(dag_schema.keys()) - ignored_keys
self.assertEqual(set(DAG.get_serialized_fields()), dag_params)
+ def test_no_new_fields_added_to_base_operator(self):
+ """
+ This test verifies that there are no new fields added to BaseOperator. And reminds that
+ tests should be added for it.
+ """
+ base_operator = BaseOperator(task_id="10")
+ fields = base_operator.__dict__
+ self.assertEqual({'_dag': None,
+ '_downstream_task_ids': set(),
+ '_inlets': [],
+ '_log': base_operator.log,
+ '_outlets': [],
+ '_upstream_task_ids': set(),
+ 'depends_on_past': False,
+ 'do_xcom_push': True,
+ 'email': None,
+ 'email_on_failure': True,
+ 'email_on_retry': True,
+ 'end_date': None,
+ 'execution_timeout': None,
+ 'executor_config': {},
+ 'inlets': [],
+ 'max_retry_delay': None,
+ 'on_execute_callback': None,
+ 'on_failure_callback': None,
+ 'on_retry_callback': None,
+ 'on_success_callback': None,
+ 'outlets': [],
+ 'owner': 'airflow',
+ 'params': {},
+ 'pool': 'default_pool',
+ 'priority_weight': 1,
+ 'queue': 'default',
+ 'resources': None,
+ 'retries': 0,
+ 'retry_delay': timedelta(0, 300),
+ 'retry_exponential_backoff': False,
+ 'run_as_user': None,
+ 'sla': None,
+ 'start_date': None,
+ 'subdag': None,
+ 'task_concurrency': None,
+ 'task_id': '10',
+ 'trigger_rule': 'all_success',
+ 'wait_for_downstream': False,
+ 'weight_rule': 'downstream'}, fields,
+ """
+!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
+
+ ACTION NEEDED! PLEASE READ THIS CAREFULLY AND CORRECT TESTS CAREFULLY
+
+ Some fields were added to the BaseOperator! Please add them to the list above and make sure that
+ you add support for DAG serialization - you should add the field to
+ `airflow/serialization/schema.json` - they should have correct type defined there.
+
+ Note that we do not support versioning yet so you should only add optional fields. We do not support
+ versioning yet so you should make sure all fields added to the BaseOperator should be optional.
Review comment:
You've duplicated(ish) the message here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7162:
[AIRFLOW-6557] Add test for newly added fields in BaseOperator
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7162: [AIRFLOW-6557] Add test for newly added fields in BaseOperator
URL: https://github.com/apache/airflow/pull/7162#issuecomment-574227743
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7162?src=pr&el=h1) Report
> Merging [#7162](https://codecov.io/gh/apache/airflow/pull/7162?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/b38766e83495803e0a95912aaa25d727938fc9c1?src=pr&el=desc) will **decrease** coverage by `0.28%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/7162?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7162 +/- ##
==========================================
- Coverage 85.4% 85.12% -0.29%
==========================================
Files 723 723
Lines 39537 39537
==========================================
- Hits 33768 33657 -111
- Misses 5769 5880 +111
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7162?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/operators/postgres\_operator.py](https://codecov.io/gh/apache/airflow/pull/7162/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvcG9zdGdyZXNfb3BlcmF0b3IucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7162/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7162/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7162/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/operators/postgres\_to\_gcs.py](https://codecov.io/gh/apache/airflow/pull/7162/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvcG9zdGdyZXNfdG9fZ2NzLnB5) | `85.29% <0%> (ø)` | :arrow_up: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7162/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7162/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.31% <0%> (-20.49%)` | :arrow_down: |
| [airflow/hooks/postgres\_hook.py](https://codecov.io/gh/apache/airflow/pull/7162/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9wb3N0Z3Jlc19ob29rLnB5) | `94.36% <0%> (ø)` | :arrow_up: |
| [airflow/hooks/dbapi\_hook.py](https://codecov.io/gh/apache/airflow/pull/7162/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9kYmFwaV9ob29rLnB5) | `91.73% <0%> (ø)` | :arrow_up: |
| [airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/7162/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=) | `89.34% <0%> (ø)` | :arrow_up: |
| ... and [4 more](https://codecov.io/gh/apache/airflow/pull/7162/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7162?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7162?src=pr&el=footer). Last update [b38766e...2acd697](https://codecov.io/gh/apache/airflow/pull/7162?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil commented on a change in pull request #7162:
[AIRFLOW-6557] Add test for newly added fields in BaseOperator
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #7162: [AIRFLOW-6557] Add test for newly added fields in BaseOperator
URL: https://github.com/apache/airflow/pull/7162#discussion_r367102031
##########
File path: tests/serialization/test_dag_serialization.py
##########
@@ -543,6 +543,66 @@ def test_dag_serialized_fields_with_schema(self):
dag_params: set = set(dag_schema.keys()) - ignored_keys
self.assertEqual(set(DAG.get_serialized_fields()), dag_params)
+ def test_no_new_fields_added_to_base_operator(self):
+ """
+ This test verifies that there are no new fields added to BaseOperator. And reminds that
+ tests should be added for it.
+ """
+ base_operator = BaseOperator(task_id="10")
+ fields = base_operator.__dict__
+ self.assertEqual({'_dag': None,
+ '_downstream_task_ids': set(),
+ '_inlets': [],
+ '_log': base_operator.log,
+ '_outlets': [],
+ '_upstream_task_ids': set(),
+ 'depends_on_past': False,
+ 'do_xcom_push': True,
+ 'email': None,
+ 'email_on_failure': True,
+ 'email_on_retry': True,
+ 'end_date': None,
+ 'execution_timeout': None,
+ 'executor_config': {},
+ 'inlets': [],
+ 'max_retry_delay': None,
+ 'on_execute_callback': None,
+ 'on_failure_callback': None,
+ 'on_retry_callback': None,
+ 'on_success_callback': None,
+ 'outlets': [],
+ 'owner': 'airflow',
+ 'params': {},
+ 'pool': 'default_pool',
+ 'priority_weight': 1,
+ 'queue': 'default',
+ 'resources': None,
+ 'retries': 0,
+ 'retry_delay': timedelta(0, 300),
+ 'retry_exponential_backoff': False,
+ 'run_as_user': None,
+ 'sla': None,
+ 'start_date': None,
+ 'subdag': None,
+ 'task_concurrency': None,
+ 'task_id': '10',
+ 'trigger_rule': 'all_success',
+ 'wait_for_downstream': False,
+ 'weight_rule': 'downstream'}, fields,
+ """
+!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
+
+ ACTION NEEDED! PLEASE READ THIS CAREFULLY AND CORRECT TESTS CAREFULLY
+
+ Some fields were added to the BaseOperator! Please add them to the list above and make sure that
+ you add support for DAG serialization - you should add the field to
+ `airflow/serialization/schema.json` and add it in `serialized_simple_dag_ground_truth` above
Review comment:
I think this should good enough for the time being
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] bolkedebruin commented on a change in pull request #7162:
[AIRFLOW-6557] Add test for newly added fields in BaseOperator
Posted by GitBox <gi...@apache.org>.
bolkedebruin commented on a change in pull request #7162: [AIRFLOW-6557] Add test for newly added fields in BaseOperator
URL: https://github.com/apache/airflow/pull/7162#discussion_r368018186
##########
File path: tests/serialization/test_dag_serialization.py
##########
@@ -543,6 +543,66 @@ def test_dag_serialized_fields_with_schema(self):
dag_params: set = set(dag_schema.keys()) - ignored_keys
self.assertEqual(set(DAG.get_serialized_fields()), dag_params)
+ def test_no_new_fields_added_to_base_operator(self):
+ """
+ This test verifies that there are no new fields added to BaseOperator. And reminds that
+ tests should be added for it.
+ """
+ base_operator = BaseOperator(task_id="10")
+ fields = base_operator.__dict__
+ self.assertEqual({'_dag': None,
+ '_downstream_task_ids': set(),
+ '_inlets': [],
+ '_log': base_operator.log,
+ '_outlets': [],
+ '_upstream_task_ids': set(),
+ 'depends_on_past': False,
+ 'do_xcom_push': True,
+ 'email': None,
+ 'email_on_failure': True,
+ 'email_on_retry': True,
+ 'end_date': None,
+ 'execution_timeout': None,
+ 'executor_config': {},
+ 'inlets': [],
+ 'max_retry_delay': None,
+ 'on_execute_callback': None,
+ 'on_failure_callback': None,
+ 'on_retry_callback': None,
+ 'on_success_callback': None,
+ 'outlets': [],
+ 'owner': 'airflow',
+ 'params': {},
+ 'pool': 'default_pool',
+ 'priority_weight': 1,
+ 'queue': 'default',
+ 'resources': None,
+ 'retries': 0,
+ 'retry_delay': timedelta(0, 300),
+ 'retry_exponential_backoff': False,
+ 'run_as_user': None,
+ 'sla': None,
+ 'start_date': None,
+ 'subdag': None,
+ 'task_concurrency': None,
+ 'task_id': '10',
+ 'trigger_rule': 'all_success',
+ 'wait_for_downstream': False,
+ 'weight_rule': 'downstream'}, fields,
+ """
+!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
+
+ ACTION NEEDED! PLEASE READ THIS CAREFULLY AND CORRECT TESTS CAREFULLY
+
+ Some fields were added to the BaseOperator! Please add them to the list above and make sure that
+ you add support for DAG serialization - you should add the field to
+ `airflow/serialization/schema.json` and add it in `serialized_simple_dag_ground_truth` above
Review comment:
Oh yes, and switch away from JSON Schema. Geez its 2020 :-P
JSON you only use to interface *externally*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk merged pull request #7162: [AIRFLOW-6557] Add test
for newly added fields in BaseOperator
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #7162: [AIRFLOW-6557] Add test for newly added fields in BaseOperator
URL: https://github.com/apache/airflow/pull/7162
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on a change in pull request #7162:
[AIRFLOW-6557] Add test for newly added fields in BaseOperator
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #7162: [AIRFLOW-6557] Add test for newly added fields in BaseOperator
URL: https://github.com/apache/airflow/pull/7162#discussion_r367413700
##########
File path: tests/serialization/test_dag_serialization.py
##########
@@ -543,6 +543,68 @@ def test_dag_serialized_fields_with_schema(self):
dag_params: set = set(dag_schema.keys()) - ignored_keys
self.assertEqual(set(DAG.get_serialized_fields()), dag_params)
+ def test_no_new_fields_added_to_base_operator(self):
+ """
+ This test verifies that there are no new fields added to BaseOperator. And reminds that
+ tests should be added for it.
+ """
+ base_operator = BaseOperator(task_id="10")
+ fields = base_operator.__dict__
+ self.assertEqual({'_dag': None,
+ '_downstream_task_ids': set(),
+ '_inlets': [],
+ '_log': base_operator.log,
+ '_outlets': [],
+ '_upstream_task_ids': set(),
+ 'depends_on_past': False,
+ 'do_xcom_push': True,
+ 'email': None,
+ 'email_on_failure': True,
+ 'email_on_retry': True,
+ 'end_date': None,
+ 'execution_timeout': None,
+ 'executor_config': {},
+ 'inlets': [],
+ 'max_retry_delay': None,
+ 'on_execute_callback': None,
+ 'on_failure_callback': None,
+ 'on_retry_callback': None,
+ 'on_success_callback': None,
+ 'outlets': [],
+ 'owner': 'airflow',
+ 'params': {},
+ 'pool': 'default_pool',
+ 'priority_weight': 1,
+ 'queue': 'default',
+ 'resources': None,
+ 'retries': 0,
+ 'retry_delay': timedelta(0, 300),
+ 'retry_exponential_backoff': False,
+ 'run_as_user': None,
+ 'sla': None,
+ 'start_date': None,
+ 'subdag': None,
+ 'task_concurrency': None,
+ 'task_id': '10',
+ 'trigger_rule': 'all_success',
+ 'wait_for_downstream': False,
+ 'weight_rule': 'downstream'}, fields,
+ """
+!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
+
+ ACTION NEEDED! PLEASE READ THIS CAREFULLY AND CORRECT TESTS CAREFULLY
+
+ Some fields were added to the BaseOperator! Please add them to the list above and make sure that
+ you add support for DAG serialization - you should add the field to
+ `airflow/serialization/schema.json` - they should have correct type defined there.
+
+ Note that we do not support versioning yet so you should only add optional fields. We do not support
Review comment:
```suggestion
Note that we do not support versioning yet so you should only add optional fields.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on a change in pull request #7162:
[AIRFLOW-6557] Add test for newly added fields in BaseOperator
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #7162: [AIRFLOW-6557] Add test for newly added fields in BaseOperator
URL: https://github.com/apache/airflow/pull/7162#discussion_r367413148
##########
File path: tests/serialization/test_dag_serialization.py
##########
@@ -543,6 +543,68 @@ def test_dag_serialized_fields_with_schema(self):
dag_params: set = set(dag_schema.keys()) - ignored_keys
self.assertEqual(set(DAG.get_serialized_fields()), dag_params)
+ def test_no_new_fields_added_to_base_operator(self):
+ """
+ This test verifies that there are no new fields added to BaseOperator. And reminds that
+ tests should be added for it.
+ """
+ base_operator = BaseOperator(task_id="10")
+ fields = base_operator.__dict__
+ self.assertEqual({'_dag': None,
+ '_downstream_task_ids': set(),
+ '_inlets': [],
+ '_log': base_operator.log,
+ '_outlets': [],
+ '_upstream_task_ids': set(),
+ 'depends_on_past': False,
+ 'do_xcom_push': True,
+ 'email': None,
+ 'email_on_failure': True,
+ 'email_on_retry': True,
+ 'end_date': None,
+ 'execution_timeout': None,
+ 'executor_config': {},
+ 'inlets': [],
+ 'max_retry_delay': None,
+ 'on_execute_callback': None,
+ 'on_failure_callback': None,
+ 'on_retry_callback': None,
+ 'on_success_callback': None,
+ 'outlets': [],
+ 'owner': 'airflow',
+ 'params': {},
+ 'pool': 'default_pool',
+ 'priority_weight': 1,
+ 'queue': 'default',
+ 'resources': None,
+ 'retries': 0,
+ 'retry_delay': timedelta(0, 300),
+ 'retry_exponential_backoff': False,
+ 'run_as_user': None,
+ 'sla': None,
+ 'start_date': None,
+ 'subdag': None,
+ 'task_concurrency': None,
+ 'task_id': '10',
+ 'trigger_rule': 'all_success',
+ 'wait_for_downstream': False,
+ 'weight_rule': 'downstream'}, fields,
+ """
+!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
+
+ ACTION NEEDED! PLEASE READ THIS CAREFULLY AND CORRECT TESTS CAREFULLY
+
+ Some fields were added to the BaseOperator! Please add them to the list above and make sure that
+ you add support for DAG serialization - you should add the field to
+ `airflow/serialization/schema.json` - they should have correct type defined there.
+
+ Note that we do not support versioning yet so you should only add optional fields. We do not support
+ versioning yet so you should make sure all fields added to the BaseOperator should be optional.
Review comment:
Ah yeah :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil commented on issue #7162: [AIRFLOW-6557] Add test
for newly added fields in BaseOperator
Posted by GitBox <gi...@apache.org>.
kaxil commented on issue #7162: [AIRFLOW-6557] Add test for newly added fields in BaseOperator
URL: https://github.com/apache/airflow/pull/7162#issuecomment-574852543
:) The bot caught you @potiuk
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] bolkedebruin commented on a change in pull request #7162:
[AIRFLOW-6557] Add test for newly added fields in BaseOperator
Posted by GitBox <gi...@apache.org>.
bolkedebruin commented on a change in pull request #7162: [AIRFLOW-6557] Add test for newly added fields in BaseOperator
URL: https://github.com/apache/airflow/pull/7162#discussion_r368018186
##########
File path: tests/serialization/test_dag_serialization.py
##########
@@ -543,6 +543,66 @@ def test_dag_serialized_fields_with_schema(self):
dag_params: set = set(dag_schema.keys()) - ignored_keys
self.assertEqual(set(DAG.get_serialized_fields()), dag_params)
+ def test_no_new_fields_added_to_base_operator(self):
+ """
+ This test verifies that there are no new fields added to BaseOperator. And reminds that
+ tests should be added for it.
+ """
+ base_operator = BaseOperator(task_id="10")
+ fields = base_operator.__dict__
+ self.assertEqual({'_dag': None,
+ '_downstream_task_ids': set(),
+ '_inlets': [],
+ '_log': base_operator.log,
+ '_outlets': [],
+ '_upstream_task_ids': set(),
+ 'depends_on_past': False,
+ 'do_xcom_push': True,
+ 'email': None,
+ 'email_on_failure': True,
+ 'email_on_retry': True,
+ 'end_date': None,
+ 'execution_timeout': None,
+ 'executor_config': {},
+ 'inlets': [],
+ 'max_retry_delay': None,
+ 'on_execute_callback': None,
+ 'on_failure_callback': None,
+ 'on_retry_callback': None,
+ 'on_success_callback': None,
+ 'outlets': [],
+ 'owner': 'airflow',
+ 'params': {},
+ 'pool': 'default_pool',
+ 'priority_weight': 1,
+ 'queue': 'default',
+ 'resources': None,
+ 'retries': 0,
+ 'retry_delay': timedelta(0, 300),
+ 'retry_exponential_backoff': False,
+ 'run_as_user': None,
+ 'sla': None,
+ 'start_date': None,
+ 'subdag': None,
+ 'task_concurrency': None,
+ 'task_id': '10',
+ 'trigger_rule': 'all_success',
+ 'wait_for_downstream': False,
+ 'weight_rule': 'downstream'}, fields,
+ """
+!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
+
+ ACTION NEEDED! PLEASE READ THIS CAREFULLY AND CORRECT TESTS CAREFULLY
+
+ Some fields were added to the BaseOperator! Please add them to the list above and make sure that
+ you add support for DAG serialization - you should add the field to
+ `airflow/serialization/schema.json` and add it in `serialized_simple_dag_ground_truth` above
Review comment:
Oh yes, and switch away from JSON Schema. Geez its 2020 :-P
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #7162: [AIRFLOW-6557] Add test
for newly added fields in BaseOperator
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #7162: [AIRFLOW-6557] Add test for newly added fields in BaseOperator
URL: https://github.com/apache/airflow/pull/7162#issuecomment-575724850
> Just dropped a thought. I am not happy with the choice for JSON Schema.
Not that I am for JSON schema (I was barely involved in DAG serialisation). For me it's simply one of the options one could consider (alongside Protocol Buffers for example). But I am really curious what would be your arguments against it @bolkedebruin - It seems you have pretty strong opinion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7162:
[AIRFLOW-6557] Add test for newly added fields in BaseOperator
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7162: [AIRFLOW-6557] Add test for newly added fields in BaseOperator
URL: https://github.com/apache/airflow/pull/7162#issuecomment-574227743
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7162?src=pr&el=h1) Report
> Merging [#7162](https://codecov.io/gh/apache/airflow/pull/7162?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/b38766e83495803e0a95912aaa25d727938fc9c1?src=pr&el=desc) will **decrease** coverage by `0.31%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/7162?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7162 +/- ##
==========================================
- Coverage 85.4% 85.09% -0.32%
==========================================
Files 723 723
Lines 39537 39546 +9
==========================================
- Hits 33768 33651 -117
- Misses 5769 5895 +126
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7162?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7162/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7162/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7162/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7162/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7162/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.31% <0%> (-20.49%)` | :arrow_down: |
| [airflow/configuration.py](https://codecov.io/gh/apache/airflow/pull/7162/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb25maWd1cmF0aW9uLnB5) | `88.01% <0%> (-3.43%)` | :arrow_down: |
| [airflow/cli/commands/db\_command.py](https://codecov.io/gh/apache/airflow/pull/7162/diff?src=pr&el=tree#diff-YWlyZmxvdy9jbGkvY29tbWFuZHMvZGJfY29tbWFuZC5weQ==) | `95.12% <0%> (-2.32%)` | :arrow_down: |
| [airflow/utils/db.py](https://codecov.io/gh/apache/airflow/pull/7162/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9kYi5weQ==) | `97.93% <0%> (-2.07%)` | :arrow_down: |
| [airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/7162/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==) | `87.8% <0%> (-0.39%)` | :arrow_down: |
| [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/7162/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `94.73% <0%> (ø)` | :arrow_up: |
| ... and [1 more](https://codecov.io/gh/apache/airflow/pull/7162/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7162?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7162?src=pr&el=footer). Last update [b38766e...778173f](https://codecov.io/gh/apache/airflow/pull/7162?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services