You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2019/04/08 16:45:00 UTC

[jira] [Commented] (GEODE-6611) Subprojects should be audited with respect to which plugins aught be applied

    [ https://issues.apache.org/jira/browse/GEODE-6611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16812592#comment-16812592 ] 

ASF subversion and git services commented on GEODE-6611:
--------------------------------------------------------

Commit 63bd991444d3fe60272be01dc614c4e51569fcd7 in geode's branch refs/heads/develop from Patrick Rhomberg
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=63bd991 ]

GEODE-6383: All subprojects should opt into configuration. (#3403)

* The collection of java.gradle, ide.gradle, spotless.gradle et al have been collected to standard-subproject-configuration.gradle.
* This configuration is applied to every subproject to be consistent with previous behavior.  This will be audited and adjusted in GEODE-6611.
* Several cross-subproject evaluation dependencies have been made explicit.


> Subprojects should be audited with respect to which plugins aught be applied
> ----------------------------------------------------------------------------
>
>                 Key: GEODE-6611
>                 URL: https://issues.apache.org/jira/browse/GEODE-6611
>             Project: Geode
>          Issue Type: Improvement
>            Reporter: Patrick Rhomberg
>            Priority: Major
>
> Previously, every Gradle subproject was aggressively configured via blocks like
> {noformat}
> subprojets {
>   apply plugin: 'java'
>   ...
> }
> {noformat}
> As the code base expanded, we have introduced many subprojects who do not warrant a "standard" configuration as a Java project.  For instance, in GEODE-6569, a subproject responsible for producing Geode's BOM was also producing a trivial jar.  This is the direct result of a configuration like the above.
> Modularity was restored by GEODE-6383 and such invasive configuration no longer exists.  We will soon be positioned to remove from such subprojects those plugins that do not belong.
> Each subproject should be audited and only pull in the plugins necessary.  This may resolve many tangental issues, particularly with publication, e.g., the war subproject publishing jars not fit for (direct) consumption.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)