You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/08/11 12:17:46 UTC

[GitHub] [spark] HyukjinKwon commented on a diff in pull request #37478: feat: config(key, value); value by Object

HyukjinKwon commented on code in PR #37478:
URL: https://github.com/apache/spark/pull/37478#discussion_r943415695


##########
sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala:
##########
@@ -819,42 +819,9 @@ object SparkSession extends Logging {
      * Sets a config option. Options set using this method are automatically propagated to
      * both `SparkConf` and SparkSession's own configuration.
      *
-     * @since 2.0.0
-     */
-    def config(key: String, value: String): Builder = synchronized {

Review Comment:
   This breaks binary compatibility so we can't simply do this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org