You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kylin.apache.org by li...@apache.org on 2018/02/04 00:51:44 UTC
[41/50] [abbrv] kylin git commit: KYLIN-3204 minor refine on loggings
KYLIN-3204 minor refine on loggings
Project: http://git-wip-us.apache.org/repos/asf/kylin/repo
Commit: http://git-wip-us.apache.org/repos/asf/kylin/commit/fee57302
Tree: http://git-wip-us.apache.org/repos/asf/kylin/tree/fee57302
Diff: http://git-wip-us.apache.org/repos/asf/kylin/diff/fee57302
Branch: refs/heads/sync
Commit: fee5730258a5082999bcf8d3141aa4cb179b693c
Parents: b07a056
Author: lidongsjtu <li...@apache.org>
Authored: Tue Jan 30 17:28:58 2018 +0800
Committer: lidongsjtu <li...@apache.org>
Committed: Tue Jan 30 17:28:58 2018 +0800
----------------------------------------------------------------------
.../java/org/apache/kylin/source/jdbc/JdbcExplorer.java | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/kylin/blob/fee57302/source-hive/src/main/java/org/apache/kylin/source/jdbc/JdbcExplorer.java
----------------------------------------------------------------------
diff --git a/source-hive/src/main/java/org/apache/kylin/source/jdbc/JdbcExplorer.java b/source-hive/src/main/java/org/apache/kylin/source/jdbc/JdbcExplorer.java
index 2dd8f9a..d858cd4 100644
--- a/source-hive/src/main/java/org/apache/kylin/source/jdbc/JdbcExplorer.java
+++ b/source-hive/src/main/java/org/apache/kylin/source/jdbc/JdbcExplorer.java
@@ -135,7 +135,7 @@ public class JdbcExplorer implements ISourceMetadataExplorer, ISampleDataDeploye
return String.format("IF NOT EXISTS (SELECT name FROM sys.schemas WHERE name = N'%s') EXEC('CREATE SCHEMA"
+ " [%s] AUTHORIZATION [dbo]')", schemaName, schemaName);
} else {
- logger.error(String.format("unsupported dialect %s.", dialect));
+ logger.error("unsupported dialect {}.", dialect);
return null;
}
}
@@ -156,7 +156,7 @@ public class JdbcExplorer implements ISourceMetadataExplorer, ISampleDataDeploye
return String.format("BULK INSERT %s FROM '%s/%s.csv' WITH(FIELDTERMINATOR = ',')", tableName, tableFileDir,
tableName);
} else {
- logger.error(String.format("unsupported dialect %s.", dialect));
+ logger.error("unsupported dialect {}.", dialect);
return null;
}
}
@@ -167,7 +167,7 @@ public class JdbcExplorer implements ISourceMetadataExplorer, ISampleDataDeploye
}
private String[] generateCreateTableSql(TableDesc tableDesc) {
- logger.info(String.format("gen create table sql:%s", tableDesc));
+ logger.info("Generate create table sql: {}", tableDesc);
String tableIdentity = String.format("%s.%s", tableDesc.getDatabase().toUpperCase(), tableDesc.getName())
.toUpperCase();
String dropsql = "DROP TABLE IF EXISTS " + tableIdentity;
@@ -207,7 +207,7 @@ public class JdbcExplorer implements ISourceMetadataExplorer, ISampleDataDeploye
private void executeSQL(String sql) throws SQLException {
Connection con = SqlUtil.getConnection(dbconf);
- logger.info(String.format("Executing sql : %s"), sql);
+ logger.info("Executing sql : {}", sql);
try {
SqlUtil.execUpdateSQL(con, sql);
} finally {
@@ -218,7 +218,7 @@ public class JdbcExplorer implements ISourceMetadataExplorer, ISampleDataDeploye
private void executeSQL(String[] sqls) throws SQLException {
try (Connection con = SqlUtil.getConnection(dbconf)) {
for (String sql : sqls) {
- logger.info(String.format("Executing sql : %s"), sql);
+ logger.info("Executing sql : {}", sql);
SqlUtil.execUpdateSQL(con, sql);
}
}