You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Brenden Matthews <br...@diddyinc.com> on 2013/05/14 02:19:41 UTC

Review Request: Allow ending Hadoop tutorial early.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11111/
-----------------------------------------------------------

Review request for mesos.


Description
-------

>From bca301f9b4aabe353f8ecfca1012ce9d3e839ca5 Mon Sep 17 00:00:00 2001
From: Brenden Matthews <br...@airbnb.com>
Date: Mon, 15 Apr 2013 14:12:33 -0700
Subject: [PATCH 04/24] Allow ending Hadoop tutorial early.

Allow someone to end tutorial after building/packaging complete.  You
can also skip the test part by exporting SKIP_TESTS (i.e., 'make hadoop
SKIP_TESTS=1').

Review: https://reviews.apache.org/r/11111
---
 hadoop/TUTORIAL.sh |   20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)


Diffs
-----

  hadoop/TUTORIAL.sh d81c55562d217e8784745d4a8cedf78ada9f5453 

Diff: https://reviews.apache.org/r/11111/diff/


Testing
-------

Used in production at airbnb.


Thanks,

Brenden Matthews


Re: Review Request: Allow ending Hadoop tutorial early.

Posted by Brenden Matthews <br...@diddyinc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11111/
-----------------------------------------------------------

(Updated June 11, 2013, 9:44 p.m.)


Review request for mesos.


Changes
-------

Rebasing on master.


Description
-------

Allow ending Hadoop tutorial early.

Allow someone to end tutorial after building/packaging complete.  You
can also skip the test part by exporting SKIP_TESTS (i.e., 'make hadoop
SKIP_TESTS=1').

Review: https://reviews.apache.org/r/11111


Diffs (updated)
-----

  hadoop/TUTORIAL.sh d81c55562d217e8784745d4a8cedf78ada9f5453 

Diff: https://reviews.apache.org/r/11111/diff/


Testing (updated)
-------

Used in production at airbnb.

make -j10 check && cd hadoop && make hadoop-2.0.0-mr1-cdh4.2.1 && make hadoop-0.20.205.0 && make hadoop-0.20.2-cdh3u3


Thanks,

Brenden Matthews


Re: Review Request: Allow ending Hadoop tutorial early.

Posted by Brenden Matthews <br...@diddyinc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11111/
-----------------------------------------------------------

(Updated June 6, 2013, 2:12 a.m.)


Review request for mesos.


Changes
-------

Rebasing on master.


Description
-------

Allow ending Hadoop tutorial early.

Allow someone to end tutorial after building/packaging complete.  You
can also skip the test part by exporting SKIP_TESTS (i.e., 'make hadoop
SKIP_TESTS=1').

Review: https://reviews.apache.org/r/11111


Diffs (updated)
-----

  hadoop/TUTORIAL.sh d81c55562d217e8784745d4a8cedf78ada9f5453 

Diff: https://reviews.apache.org/r/11111/diff/


Testing
-------

Used in production at airbnb.


Thanks,

Brenden Matthews


Re: Review Request: Allow ending Hadoop tutorial early.

Posted by Brenden Matthews <br...@diddyinc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11111/
-----------------------------------------------------------

(Updated June 3, 2013, 6 p.m.)


Review request for mesos.


Description (updated)
-------

Allow ending Hadoop tutorial early.

Allow someone to end tutorial after building/packaging complete.  You
can also skip the test part by exporting SKIP_TESTS (i.e., 'make hadoop
SKIP_TESTS=1').

Review: https://reviews.apache.org/r/11111


Diffs (updated)
-----

  hadoop/TUTORIAL.sh d81c55562d217e8784745d4a8cedf78ada9f5453 

Diff: https://reviews.apache.org/r/11111/diff/


Testing
-------

Used in production at airbnb.


Thanks,

Brenden Matthews


Re: Review Request: Allow ending Hadoop tutorial early.

Posted by Brenden Matthews <br...@diddyinc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11111/
-----------------------------------------------------------

(Updated May 28, 2013, 10:52 p.m.)


Review request for mesos.


Description
-------

>From bca301f9b4aabe353f8ecfca1012ce9d3e839ca5 Mon Sep 17 00:00:00 2001
From: Brenden Matthews <br...@airbnb.com>
Date: Mon, 15 Apr 2013 14:12:33 -0700
Subject: [PATCH 04/24] Allow ending Hadoop tutorial early.

Allow someone to end tutorial after building/packaging complete.  You
can also skip the test part by exporting SKIP_TESTS (i.e., 'make hadoop
SKIP_TESTS=1').

Review: https://reviews.apache.org/r/11111
---
 hadoop/TUTORIAL.sh |   20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)


Diffs (updated)
-----

  hadoop/TUTORIAL.sh d81c55562d217e8784745d4a8cedf78ada9f5453 

Diff: https://reviews.apache.org/r/11111/diff/


Testing
-------

Used in production at airbnb.


Thanks,

Brenden Matthews


Re: Review Request: Allow ending Hadoop tutorial early.

Posted by Brenden Matthews <br...@diddyinc.com>.

> On May 17, 2013, 6:30 p.m., Vinod Kone wrote:
> > hadoop/TUTORIAL.sh, lines 605-624
> > <https://reviews.apache.org/r/11111/diff/1/?file=290969#file290969line605>
> >
> >     Echoing BenH's comments from an earlier review, we could perhaps get rid of this when we actually write a build system for mesos-hadoop.

No disagreement here.  Until that's done though, this is what we've got.


- Brenden


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11111/#review20709
-----------------------------------------------------------


On May 14, 2013, 12:19 a.m., Brenden Matthews wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11111/
> -----------------------------------------------------------
> 
> (Updated May 14, 2013, 12:19 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Description
> -------
> 
> From bca301f9b4aabe353f8ecfca1012ce9d3e839ca5 Mon Sep 17 00:00:00 2001
> From: Brenden Matthews <br...@airbnb.com>
> Date: Mon, 15 Apr 2013 14:12:33 -0700
> Subject: [PATCH 04/24] Allow ending Hadoop tutorial early.
> 
> Allow someone to end tutorial after building/packaging complete.  You
> can also skip the test part by exporting SKIP_TESTS (i.e., 'make hadoop
> SKIP_TESTS=1').
> 
> Review: https://reviews.apache.org/r/11111
> ---
>  hadoop/TUTORIAL.sh |   20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
> 
> 
> Diffs
> -----
> 
>   hadoop/TUTORIAL.sh d81c55562d217e8784745d4a8cedf78ada9f5453 
> 
> Diff: https://reviews.apache.org/r/11111/diff/
> 
> 
> Testing
> -------
> 
> Used in production at airbnb.
> 
> 
> Thanks,
> 
> Brenden Matthews
> 
>


Re: Review Request: Allow ending Hadoop tutorial early.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11111/#review20709
-----------------------------------------------------------



hadoop/TUTORIAL.sh
<https://reviews.apache.org/r/11111/#comment42743>

    Echoing BenH's comments from an earlier review, we could perhaps get rid of this when we actually write a build system for mesos-hadoop.


- Vinod Kone


On May 14, 2013, 12:19 a.m., Brenden Matthews wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11111/
> -----------------------------------------------------------
> 
> (Updated May 14, 2013, 12:19 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Description
> -------
> 
> From bca301f9b4aabe353f8ecfca1012ce9d3e839ca5 Mon Sep 17 00:00:00 2001
> From: Brenden Matthews <br...@airbnb.com>
> Date: Mon, 15 Apr 2013 14:12:33 -0700
> Subject: [PATCH 04/24] Allow ending Hadoop tutorial early.
> 
> Allow someone to end tutorial after building/packaging complete.  You
> can also skip the test part by exporting SKIP_TESTS (i.e., 'make hadoop
> SKIP_TESTS=1').
> 
> Review: https://reviews.apache.org/r/11111
> ---
>  hadoop/TUTORIAL.sh |   20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
> 
> 
> Diffs
> -----
> 
>   hadoop/TUTORIAL.sh d81c55562d217e8784745d4a8cedf78ada9f5453 
> 
> Diff: https://reviews.apache.org/r/11111/diff/
> 
> 
> Testing
> -------
> 
> Used in production at airbnb.
> 
> 
> Thanks,
> 
> Brenden Matthews
> 
>