You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by robertkowalski <gi...@git.apache.org> on 2014/12/25 23:49:51 UTC
[GitHub] couchdb-couch pull request: add *.d to .gitignore
GitHub user robertkowalski opened a pull request:
https://github.com/apache/couchdb-couch/pull/28
add *.d to .gitignore
they are generated by the dependencies in priv/
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/robertkowalski/couchdb-couch ignore-d-files
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-couch/pull/28.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #28
----
commit 090a86c1485c42b4f1f197c82541ba73bb81a6f7
Author: Robert Kowalski <ro...@kowalski.gd>
Date: 2014-12-25T22:50:17Z
add *.d to .gitignore
they are generated by the dependencies in priv/
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: add *.d to .gitignore
Posted by davisp <gi...@git.apache.org>.
Github user davisp commented on the pull request:
https://github.com/apache/couchdb-couch/pull/28#issuecomment-220133188
+1 to making it priv/**/*.d
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: add *.d to .gitignore
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-couch/pull/28#issuecomment-69665187
Hm, I don't have such. How does they looks like?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: add *.d to .gitignore
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-couch/pull/28#issuecomment-108125939
example file content:
```
(01:12:21) [robert@tequila-osx] ~/apache/couchdb/src/couch (master) $ cat priv/couch_js/utf8.d
priv/couch_js/utf8.o: priv/couch_js/utf8.c /usr/local/include/js/jsapi.h \
/usr/local/include/js/js-config.h /usr/local/include/js/jspubtd.h \
/usr/local/include/js/jstypes.h /usr/local/include/js/jsautocfg.h \
/usr/local/include/js/jsinttypes.h /usr/local/include/js/jsotypes.h \
/usr/local/include/js/jscompat.h /usr/local/include/js/jslong.h \
/usr/local/include/js/jsval.h /usr/local/include/js/jsutil.h \
/usr/local/include/js/jsproto.tbl /usr/local/include/js/jsversion.h \
priv/couch_js/config.h
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: add *.d to .gitignore
Posted by davisp <gi...@git.apache.org>.
Github user davisp commented on the pull request:
https://github.com/apache/couchdb-couch/pull/28#issuecomment-220133264
Erp! Formatting
priv/**/*.d
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: add *.d to .gitignore
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-couch/pull/28#issuecomment-108125866
file list
```
priv/couch_ejson_compare/couch_ejson_compare.d
priv/couch_js/http.d
priv/couch_js/main.d
priv/couch_js/utf8.d
priv/couch_js/util.d
priv/icu_driver/couch_icu_driver.d
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: add *.d to .gitignore
Posted by davisp <gi...@git.apache.org>.
Github user davisp commented on the pull request:
https://github.com/apache/couchdb-couch/pull/28#issuecomment-85280587
Which dependencies in priv? *.d seems a bit overly general, perhaps limit to the directory they affect?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: add *.d to .gitignore
Posted by eiri <gi...@git.apache.org>.
Github user eiri commented on the pull request:
https://github.com/apache/couchdb-couch/pull/28#issuecomment-220097203
@kxepal @davisp : Bump for a great justice.
*.d files in question appears to be "deps files" generated by rebar's [port_compiler](https://github.com/rebar/rebar/blob/master/src/rebar_port_compiler.erl#L359). rebar 2.6.1 has a habit to leave them behind.
@robertkowalski I'd suggest to make it `priv/**/*.d`, just to be on a safe side
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---