You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/05/25 16:18:17 UTC

[GitHub] [cloudstack] rhtyd opened a new pull request #5038: systemvmtemplate: update to Debian 10.9

rhtyd opened a new pull request #5038:
URL: https://github.com/apache/cloudstack/pull/5038


   Updates systemvmtemplate build scripts to use latest 10.9 iso. Fix url to get `vhd-util`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on pull request #5038: systemvmtemplate: update to Debian 10.9

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5038:
URL: https://github.com/apache/cloudstack/pull/5038#issuecomment-848212886


   @rhtyd 
   by the way, would it be better to add "--no-check-certificate " to all "wget" command ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #5038: systemvmtemplate: update to Debian 10.9

Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #5038:
URL: https://github.com/apache/cloudstack/pull/5038#discussion_r639453520



##########
File path: tools/appliance/systemvmtemplate/template.json
##########
@@ -36,8 +36,8 @@
       "disk_size": 2500,
       "disk_interface": "virtio",
       "net_device": "virtio-net",
-      "iso_url": "https://cdimage.debian.org/debian-cd/10.8.0/amd64/iso-cd/debian-10.8.0-amd64-netinst.iso",
-      "iso_checksum": "934336d266535c91fcd12cd122c81f8261721efa117fdcb9a31615caa96c5c5ce3454ed5f28f1b25a7b1b5f44631fdfa78a93adb6445e2e2caaf6455ab344cf8",
+      "iso_url": "https://cdimage.debian.org/debian-cd/10.9.0/amd64/iso-cd/debian-10.9.0-amd64-netinst.iso",
+      "iso_checksum": "47d35187b4903e803209959434fb8b65ead3ad2a8f007eef1c3d3284f356ab9955aa7e15e24cb7af6a3859aa66837f5fa2e7441f936496ea447904f7dddfdc20",

Review comment:
       Verified downloads, and checksum. LGTM.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on a change in pull request #5038: systemvmtemplate: update to Debian 10.9

Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #5038:
URL: https://github.com/apache/cloudstack/pull/5038#discussion_r639562488



##########
File path: tools/appliance/systemvmtemplate/scripts/install_systemvm_packages.sh
##########
@@ -68,7 +68,7 @@ function install_packages() {
     haproxy \
     haveged \
     radvd \
-    sharutils genisoimage aria2 \

Review comment:
       Checked with @nvazquez he confirms this is an unnecessary package.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #5038: systemvmtemplate: update to Debian 10.9

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5038:
URL: https://github.com/apache/cloudstack/pull/5038#issuecomment-848623145


   Verified with local build, merging this with two lgtms; smoketest won't cover new builds; which we can kick later on in the health check PR after uploading new template to downloads.cloudstack.org.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd merged pull request #5038: systemvmtemplate: update to Debian 10.9

Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #5038:
URL: https://github.com/apache/cloudstack/pull/5038


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #5038: systemvmtemplate: update to Debian 10.9

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5038:
URL: https://github.com/apache/cloudstack/pull/5038#issuecomment-848271018


   Not necesary if we install the latest ca-certificates, we don't want to install anything with an invalid certificate.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org