You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/09/20 00:00:06 UTC

[GitHub] [incubator-superset] etr2460 opened a new pull request #8262: [SQL Lab] Add commit to resolve query table lock

etr2460 opened a new pull request #8262: [SQL Lab] Add commit to resolve query table lock
URL: https://github.com/apache/incubator-superset/pull/8262
 
 
   ### CATEGORY
   
   Choose one
   
   - [x] Bug Fix
   - [ ] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   We've been trying to track down database row locking issues when trying to call the `stop_query` endpoint for several months now. After digging into this file, it seems like the session that we create to run sql queries has autoflush enabled. Therefore, we're locking the db on these rows until committing the changes to the query. We don't commit this until after the query finishes, so the row gets locked and we can't set the query to stopped. By committing before running the query, this seems to have resolved the issue for us.
   
   ### TEST PLAN
   CI + Deployed in our production environment
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   @graceguo-supercat @michellethomas @john-bodley @mistercrunch 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org