You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/06/10 02:03:24 UTC

[GitHub] [pulsar] gaoran10 commented on a diff in pull request #15998: [doc] Add a step about JDK17 configuration to the Pulsar SQL document

gaoran10 commented on code in PR #15998:
URL: https://github.com/apache/pulsar/pull/15998#discussion_r894094396


##########
site2/docs/sql-getting-started.md:
##########
@@ -21,23 +21,34 @@ To query data in Pulsar with Pulsar SQL, complete the following steps.
 
 ```
 
-2. Start a Pulsar SQL worker.
+2. Adjust configuration. (JDK17)
+
+If you use JDK17, you need to add the following options to the configuration file `conf/presto/jvm.config`. Please note that these two lines can not be put into one line.
+
+```bash
+
+--add-opens

Review Comment:
   Do we need to separate this config into two lines? refer to https://trino.io/docs/current/installation/deployment.html#jvm-config, maybe one line is enough?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org