[GitHub] [lucene] romseygeek commented on a diff in pull request #860: LUCENE-10553: Fix WANDScorer's handling of 0 and +Infty.

[GitBox <gi...@apache.org>]

romseygeek commented on code in PR #860:
URL: https://github.com/apache/lucene/pull/860#discussion_r863538587


##########
lucene/core/src/java/org/apache/lucene/search/WANDScorer.java:
##########
@@ -86,7 +86,6 @@ static int scalingFactor(float f) {
    * sure we do not miss any matches.
    */
   static long scaleMaxScore(float maxScore, int scalingFactor) {
-    assert scalingFactor(maxScore) >= scalingFactor;

Review Comment:
   Does this assertion no longer hold? I'm a bit nervous about removing it, as it tripping was what alerted us to the bug in the first place.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org