You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/05/19 01:07:29 UTC
[GitHub] timifasubaa commented on issue #5023: [sqllab] force limit queries
only when there is no existing limit
timifasubaa commented on issue #5023: [sqllab] force limit queries only when there is no existing limit
URL: https://github.com/apache/incubator-superset/pull/5023#issuecomment-390367349
@mistercrunch That makes sense. I took out your regex and made it a helper method in utils. Now I apply the limit upstream if it exists then we modify the query with the max value if the specified value is more than the max value or there is no specified value. Lmk what you think.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org