You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/01/03 21:23:58 UTC

[jira] [Commented] (THRIFT-3933) Port official C# .NET library for Thrift to C# .NET Core libary

    [ https://issues.apache.org/jira/browse/THRIFT-3933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15796218#comment-15796218 ] 

ASF GitHub Bot commented on THRIFT-3933:
----------------------------------------

GitHub user Jens-G opened a pull request:

    https://github.com/apache/thrift/pull/1149

    THRIFT-3933 add .NETCore support

    Add .NETCore to Apache Thrift
    Patch: Volodymyr Gotra & Jens Geyer


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Jens-G/thrift THRIFT-3933

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/1149.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1149
    
----
commit d7d15cf5f24091d37948f2b635e221f3ddf6d99a
Author: Volodymyr Gotra <vg...@gmail.com>
Date:   2016-09-15T00:18:48Z

    THRIFT-3933 Microsoft .Net Core library port and generator for this library
    Client: .NET Core
    Patch: Volodymyr Gotra <vg...@gmail.com>
    
    This closes #1088

commit 57343eb261d417f78f31fca60875d4ff301e5fb3
Author: Jens Geyer <je...@apache.org>
Date:   2016-12-17T18:04:08Z

    .NETCore fixes and improvements for merge into Thrift codebase
    - removed unecessary "netcore_namespace", this form is deprecated
    - moved t_netcore_generator.cc into the right path + added compiler vcproj
    - added "netcore" namespace to generator
    - removed generated files from the code tree
    - fix for warning: suggest parentheses around '&&' within '||'
    - fixed a bunch of wrongly spelled "Thirft"s
    - added netcore makefiles + m4 for .NET core detection
    - test suite: dictionary console output fixed
    - test suite: general improvements + fixes
    - test suite: refactored server params into class
    - test suite: aligned cmdline args, added --help
    - added missing ASF file headers

----


> Port official C# .NET library for Thrift to C# .NET Core libary
> ---------------------------------------------------------------
>
>                 Key: THRIFT-3933
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3933
>             Project: Thrift
>          Issue Type: New Feature
>          Components: C# - Library
>            Reporter: Volodymyr Gotra
>            Assignee: Jens Geyer
>
> Port current C# .NET library to C# .NET Core library with support for few platforms (Windows, MacOs, Linux)
> Create separate generator for C# .NET Core library 
> Integrate pull request into official Thrift repository



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)