You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mike Percy (Code Review)" <ge...@cloudera.org> on 2017/04/28 22:18:38 UTC
[kudu-CR] tablet copy-itest: Reduce flakiness
Mike Percy has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6764
Change subject: tablet_copy-itest: Reduce flakiness
......................................................................
tablet_copy-itest: Reduce flakiness
This patch reduces the flakiness under heavy CPU load of
TabletCopyITest.TestDisableTabletCopy_NoTightLoopWhenTabletDeleted from
37/100 failures [1] to 0/100 failures [2] on dist-test by simply tuning
up the # of log messages per second we tolerate from 30 to 60.
This patch also fixes a minor bug where we attempt to send a tablet copy
request with invalid parameters even if the PrepareTabletCopyRequest()
method returns an error, indicating that it wasn't able to fill in the
request. This resulted in warning messages in the logs that looked like
the following:
[libprotobuf ERROR /home/mpercy/src/kudu/thirdparty/src/protobuf-2.6.1/src/google/protobuf/message_lite.cc:123] Can't parse message of type "kudu.consensus.StartTabletCopyRequestPB" because it is missing required fields: tablet_id, copy_peer_uuid, copy_peer_addr
W0428 19:46:21.691408 10560 service_if.cc:62] invalid parameter for call kudu.consensus.ConsensusService.StartTabletCopy: missing fields: tablet_id, copy_peer_uuid, copy_peer_addr
[1] http://dist-test.cloudera.org/job?job_id=mpercy.1493408511.5800
[2] http://dist-test.cloudera.org/job?job_id=mpercy.1493408241.3403
Change-Id: Idd10f2fefb67634031f5c08e2adddc695193afb7
---
M src/kudu/consensus/consensus_peers.cc
M src/kudu/consensus/consensus_queue.cc
M src/kudu/integration-tests/tablet_copy-itest.cc
3 files changed, 16 insertions(+), 15 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/64/6764/1
--
To view, visit http://gerrit.cloudera.org:8080/6764
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idd10f2fefb67634031f5c08e2adddc695193afb7
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
[kudu-CR] tablet copy-itest: Reduce flakiness
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has submitted this change and it was merged.
Change subject: tablet_copy-itest: Reduce flakiness
......................................................................
tablet_copy-itest: Reduce flakiness
This patch reduces the flakiness under heavy CPU load of
TabletCopyITest.TestDisableTabletCopy_NoTightLoopWhenTabletDeleted from
37/100 failures [1] to 0/100 failures [2] on dist-test by simply tuning
up the # of log messages per second we tolerate from 30 to 60.
This patch also fixes a minor bug where we attempt to send a tablet copy
request with invalid parameters even if the PrepareTabletCopyRequest()
method returns an error, indicating that it wasn't able to fill in the
request. This resulted in warning messages in the logs that looked like
the following:
[libprotobuf ERROR /home/mpercy/src/kudu/thirdparty/src/protobuf-2.6.1/src/google/protobuf/message_lite.cc:123] Can't parse message of type "kudu.consensus.StartTabletCopyRequestPB" because it is missing required fields: tablet_id, copy_peer_uuid, copy_peer_addr
W0428 19:46:21.691408 10560 service_if.cc:62] invalid parameter for call kudu.consensus.ConsensusService.StartTabletCopy: missing fields: tablet_id, copy_peer_uuid, copy_peer_addr
[1] http://dist-test.cloudera.org/job?job_id=mpercy.1493408511.5800
[2] http://dist-test.cloudera.org/job?job_id=mpercy.1493408241.3403
Change-Id: Idd10f2fefb67634031f5c08e2adddc695193afb7
Reviewed-on: http://gerrit.cloudera.org:8080/6764
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/consensus/consensus_peers.cc
M src/kudu/consensus/consensus_queue.cc
M src/kudu/integration-tests/tablet_copy-itest.cc
3 files changed, 16 insertions(+), 15 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/6764
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idd10f2fefb67634031f5c08e2adddc695193afb7
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] tablet copy-itest: Reduce flakiness
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: tablet_copy-itest: Reduce flakiness
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6764
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd10f2fefb67634031f5c08e2adddc695193afb7
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No