You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@drill.apache.org by superbstreak <gi...@git.apache.org> on 2017/09/21 01:11:01 UTC

[GitHub] drill pull request #950: DRILL-5431: SSL Support

Github user superbstreak commented on a diff in the pull request:

    https://github.com/apache/drill/pull/950#discussion_r140129825
  
    --- Diff: contrib/native/client/src/include/drill/common.hpp ---
    @@ -163,9 +170,13 @@ typedef enum{
     #define USERPROP_USERNAME "userName"
     #define USERPROP_PASSWORD "password"
     #define USERPROP_SCHEMA   "schema"
    -#define USERPROP_USESSL   "useSSL"        // Not implemented yet
    -#define USERPROP_FILEPATH "pemLocation"   // Not implemented yet
    -#define USERPROP_FILENAME "pemFile"       // Not implemented yet
    +#define USERPROP_USESSL   "enableTLS"
    +#define USERPROP_TLSPROTOCOL "TLSProtocol" //TLS version
    +#define USERPROP_CERTFILEPATH "certFilePath" // pem file path and name
    +#define USERPROP_CERTPASSWORD "certPassword" // Password for certificate file
    --- End diff --
    
    I think we can remove this to avoid confusion :)


---