[GitHub] [incubator-teaclave] qinkunbao commented on a change in pull request #609: fix ide scripts; users can run ide.sh from any cwd

[GitBox <gi...@apache.org>]

qinkunbao commented on a change in pull request #609:
URL: https://github.com/apache/incubator-teaclave/pull/609#discussion_r798992927



##########
File path: scripts/ide.sh
##########
@@ -17,20 +17,21 @@
 # specific language governing permissions and limitations
 # under the License.
 
-TRUSTED_TOML="cmake/tomls/Cargo.sgx_trusted_lib.toml"
-UNTRUSTED_TOML="cmake/tomls/Cargo.sgx_untrusted_app.toml"
+script_dir=$(cd "$(dirname "${BASH_SOURCE[0]}")" &>/dev/null && pwd -P)

Review comment:
       > https://stackoverflow.com/questions/673055/correct-bash-and-shell-script-variable-capitalization @qinkunbao please read and see if capitalization is needed
   
   Thanks for the information. It looks like variables like `TRUSTED_TOML` and `UNTRUSTED_TOML` in this shell script should be the lower case as well, according to the convention.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org