[jira] [Commented] (PARQUET-412) Format: Do not shade slf4j-api

["Michal Turek (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PARQUET-412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15146658#comment-15146658 ] 

Michal Turek commented on PARQUET-412:
--------------------------------------

I have just fixed the code, please review my changes and merge them.
https://github.com/apache/parquet-format/pull/37

> Format: Do not shade slf4j-api
> ------------------------------
>
>                 Key: PARQUET-412
>                 URL: https://issues.apache.org/jira/browse/PARQUET-412
>             Project: Parquet
>          Issue Type: Bug
>          Components: parquet-format
>            Reporter: Ryan Blue
>            Assignee: Ryan Blue
>             Fix For: format-2.4.0
>
>
> PARQUET-369 fixed warnings from shading slf4j-api, but a consequence of shading is that the log messages from thrift for parquet-format classes are dropped. This was an accepted trade-off until PARQUET-305 changed logging in the rest of the library to SLF4J. Now that the slf4j-api is a dependency for all of Parquet except parquet-format, it no longer makes sense to suppress the format thrift logs to avoid exposing it.
> This also requires PARQUET-371 because thrift 0.7.0 relies on a very old version of slf4j-api.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)