You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/04/20 03:45:05 UTC

[GitHub] [incubator-nuttx] donghengqaz opened a new pull request #3579: esp32 & esp32c3: Update Wi-Fi BT and Wi-Fi libraries to fix some issues

donghengqaz opened a new pull request #3579:
URL: https://github.com/apache/incubator-nuttx/pull/3579


   ## Summary
   
   Update Wi-Fi BT and Wi-Fi libraries to fix some issue.
   
   ## Impact
   
   ## Testing
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #3579: esp32 & esp32c3: Update Wi-Fi BT and Wi-Fi libraries to fix some issues

Posted by GitBox <gi...@apache.org>.
gustavonihei commented on a change in pull request #3579:
URL: https://github.com/apache/incubator-nuttx/pull/3579#discussion_r616683921



##########
File path: arch/risc-v/src/esp32c3/Kconfig
##########
@@ -423,6 +423,13 @@ config ESP32C3_WIFI_FS_MOUNTPT
 	help
 		Mount point of Wi-Fi storage file system.
 
+config ESP32C3_WIFI_STA_DISCONNECT_PM
+	bool "Power Management for station at disconnected"
+	default n
+	help
+		Select this option to enable power_management for station when disconnected.
+		Chip will do modem-sleep when rf module is not in use any more.

Review comment:
       ```suggestion
   config ESP32C3_WIFI_STA_DISCONNECT_PM
   	bool "Power Management for station when disconnected"
   	default n
   	help
   		Select this option to enable power management for station when disconnected.
   		Chip will do modem-sleep when RT module is not in use anymore.
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] donghengqaz commented on a change in pull request #3579: esp32 & esp32c3: Update Wi-Fi BT and Wi-Fi libraries to fix some issues

Posted by GitBox <gi...@apache.org>.
donghengqaz commented on a change in pull request #3579:
URL: https://github.com/apache/incubator-nuttx/pull/3579#discussion_r617155155



##########
File path: arch/xtensa/src/esp32/Kconfig
##########
@@ -957,6 +957,13 @@ config ESP32_WIFI_FS_MOUNTPT
 	help
 		Mount point of WiFi storage file system.
 
+config ESP32_WIFI_STA_DISCONNECT_PM
+	bool "Power Management for station at disconnected"
+	default n
+	help
+		Select this option to enable power_management for station when disconnected.
+		Chip will do modem-sleep when rf module is not in use any more.

Review comment:
       It is fixed.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #3579: esp32 & esp32c3: Update Wi-Fi BT and Wi-Fi libraries to fix some issues

Posted by GitBox <gi...@apache.org>.
gustavonihei commented on a change in pull request #3579:
URL: https://github.com/apache/incubator-nuttx/pull/3579#discussion_r616684959



##########
File path: arch/xtensa/src/esp32/Kconfig
##########
@@ -957,6 +957,13 @@ config ESP32_WIFI_FS_MOUNTPT
 	help
 		Mount point of WiFi storage file system.
 
+config ESP32_WIFI_STA_DISCONNECT_PM
+	bool "Power Management for station at disconnected"
+	default n
+	help
+		Select this option to enable power_management for station when disconnected.
+		Chip will do modem-sleep when rf module is not in use any more.

Review comment:
       ```suggestion
   config ESP32_WIFI_STA_DISCONNECT_PM
   	bool "Power Management for station when disconnected"
   	default n
   	---help---
   		Select this option to enable power management for station when disconnected.
   		Chip will do modem-sleep when RF module is not in use anymore.
   ```

##########
File path: arch/risc-v/src/esp32c3/Kconfig
##########
@@ -423,6 +423,13 @@ config ESP32C3_WIFI_FS_MOUNTPT
 	help
 		Mount point of Wi-Fi storage file system.
 
+config ESP32C3_WIFI_STA_DISCONNECT_PM
+	bool "Power Management for station at disconnected"
+	default n
+	help
+		Select this option to enable power_management for station when disconnected.
+		Chip will do modem-sleep when rf module is not in use any more.

Review comment:
       ```suggestion
   config ESP32C3_WIFI_STA_DISCONNECT_PM
   	bool "Power Management for station when disconnected"
   	default n
   	---help---
   		Select this option to enable power management for station when disconnected.
   		Chip will do modem-sleep when RT module is not in use anymore.
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #3579: esp32 & esp32c3: Update Wi-Fi BT and Wi-Fi libraries to fix some issues

Posted by GitBox <gi...@apache.org>.
gustavonihei commented on a change in pull request #3579:
URL: https://github.com/apache/incubator-nuttx/pull/3579#discussion_r616683921



##########
File path: arch/risc-v/src/esp32c3/Kconfig
##########
@@ -423,6 +423,13 @@ config ESP32C3_WIFI_FS_MOUNTPT
 	help
 		Mount point of Wi-Fi storage file system.
 
+config ESP32C3_WIFI_STA_DISCONNECT_PM
+	bool "Power Management for station at disconnected"
+	default n
+	help
+		Select this option to enable power_management for station when disconnected.
+		Chip will do modem-sleep when rf module is not in use any more.

Review comment:
       ```suggestion
   config ESP32C3_WIFI_STA_DISCONNECT_PM
   	bool "Power Management for station when disconnected"
   	default n
   	---help---
   		Select this option to enable power management for station when disconnected.
   		Chip will do modem-sleep when RF module is not in use anymore.
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] donghengqaz commented on a change in pull request #3579: esp32 & esp32c3: Update Wi-Fi BT and Wi-Fi libraries to fix some issues

Posted by GitBox <gi...@apache.org>.
donghengqaz commented on a change in pull request #3579:
URL: https://github.com/apache/incubator-nuttx/pull/3579#discussion_r617155104



##########
File path: arch/risc-v/src/esp32c3/Kconfig
##########
@@ -423,6 +423,13 @@ config ESP32C3_WIFI_FS_MOUNTPT
 	help
 		Mount point of Wi-Fi storage file system.
 
+config ESP32C3_WIFI_STA_DISCONNECT_PM
+	bool "Power Management for station at disconnected"
+	default n
+	help
+		Select this option to enable power_management for station when disconnected.
+		Chip will do modem-sleep when rf module is not in use any more.

Review comment:
       It is fixed.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] acassis merged pull request #3579: esp32 & esp32c3: Update Wi-Fi BT and Wi-Fi libraries to fix some issues

Posted by GitBox <gi...@apache.org>.
acassis merged pull request #3579:
URL: https://github.com/apache/incubator-nuttx/pull/3579


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org