You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2014/08/16 03:28:45 UTC
Review Request 24761: Made DockerContainerizer be the default.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24761/
-----------------------------------------------------------
Review request for mesos, Ben Mahler, Ian Downes, Jie Yu, and Vinod Kone.
Repository: mesos-git
Description
-------
See summary.
Diffs
-----
src/slave/flags.hpp a4ddeb124f155ecdcfbd7a5b16f6ac51d9d0be37
Diff: https://reviews.apache.org/r/24761/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman
Re: Review Request 24761: Made DockerContainerizer be the default.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24761/
-----------------------------------------------------------
(Updated Aug. 16, 2014, 2:57 p.m.)
Review request for mesos, Ben Mahler, Ian Downes, Jie Yu, and Vinod Kone.
Repository: mesos-git
Description
-------
See summary.
Diffs (updated)
-----
src/slave/flags.hpp a4ddeb124f155ecdcfbd7a5b16f6ac51d9d0be37
src/tests/mesos.cpp 0f759a70b457561bc878fa62b819142a064d5ea4
Diff: https://reviews.apache.org/r/24761/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman
Re: Review Request 24761: Made DockerContainerizer be the default.
Posted by Jie Yu <yu...@gmail.com>.
> On Aug. 16, 2014, 1:41 a.m., Jie Yu wrote:
> > Ship It!
There will be some extra logging in the docker containerizer launch (if not supported). So either remove those logging (otherwise, we'll see so many misleading logs in the slave log), or use 'mesos,docker'.
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24761/#review50810
-----------------------------------------------------------
On Aug. 16, 2014, 1:28 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24761/
> -----------------------------------------------------------
>
> (Updated Aug. 16, 2014, 1:28 a.m.)
>
>
> Review request for mesos, Ben Mahler, Ian Downes, Jie Yu, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/slave/flags.hpp a4ddeb124f155ecdcfbd7a5b16f6ac51d9d0be37
>
> Diff: https://reviews.apache.org/r/24761/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 24761: Made DockerContainerizer be the default.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24761/#review50810
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Aug. 16, 2014, 1:28 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24761/
> -----------------------------------------------------------
>
> (Updated Aug. 16, 2014, 1:28 a.m.)
>
>
> Review request for mesos, Ben Mahler, Ian Downes, Jie Yu, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/slave/flags.hpp a4ddeb124f155ecdcfbd7a5b16f6ac51d9d0be37
>
> Diff: https://reviews.apache.org/r/24761/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>