You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/09/18 21:39:37 UTC

[GitHub] [beam] brachi-wernick edited a comment on pull request #15510: [BEAM-12883] Add coder for ReadableFileCoder that supports MetadataCoderV2

brachi-wernick edited a comment on pull request #15510:
URL: https://github.com/apache/beam/pull/15510#issuecomment-921774536


   > Maybe it makes better sense to ensure the `MetadataCoder` will actually encode+decode the metadata's `lastModifiedMillis` field? Why did you choose to not make that change instead? I think that would work best.
   > 
   > cc: @reuvenlax
   
    
   @pabloem why initially this separation was needed between the coders? `MetadataCoder` and `MetadataCoderV2`, I just keep this style in the `ReadableFileCoder`. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org