You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Jonathan Hurley <jh...@hortonworks.com> on 2017/07/26 20:31:43 UTC
Review Request 61161: Stack Tools and Feature Should be Ignored in
Blueprints
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61161/
-----------------------------------------------------------
Review request for Ambari and Nate Cole.
Bugs: AMBARI-21582
https://issues.apache.org/jira/browse/AMBARI-21582
Repository: ambari
Description
-------
AMBARI-21430 introduced the ability for multiple stack tools to exist in {{cluster-env}}. In order to remain backward compatible with existing blueprints, it was decided that all stack tools and features properties specified on a blueprint would be ignored in favor of what was defined on the stack.
There is a bug in the logic which overrides the blueprint properties where the wrong map is consulted for a matching key. This causes the properties specified in the blueprint to be used instead of those from the stack.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java 50cea9e00b
Diff: https://reviews.apache.org/r/61161/diff/1/
Testing
-------
Manual test of a bad blueprint.
Thanks,
Jonathan Hurley
Re: Review Request 61161: Stack Tools and Feature Should be Ignored in
Blueprints
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61161/#review181486
-----------------------------------------------------------
Ship it!
Ship It!
- Nate Cole
On July 26, 2017, 4:31 p.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61161/
> -----------------------------------------------------------
>
> (Updated July 26, 2017, 4:31 p.m.)
>
>
> Review request for Ambari and Nate Cole.
>
>
> Bugs: AMBARI-21582
> https://issues.apache.org/jira/browse/AMBARI-21582
>
>
> Repository: ambari
>
>
> Description
> -------
>
> AMBARI-21430 introduced the ability for multiple stack tools to exist in {{cluster-env}}. In order to remain backward compatible with existing blueprints, it was decided that all stack tools and features properties specified on a blueprint would be ignored in favor of what was defined on the stack.
>
> There is a bug in the logic which overrides the blueprint properties where the wrong map is consulted for a matching key. This causes the properties specified in the blueprint to be used instead of those from the stack.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java 50cea9e00b
>
>
> Diff: https://reviews.apache.org/r/61161/diff/1/
>
>
> Testing
> -------
>
> Manual test of a bad blueprint.
>
>
> Thanks,
>
> Jonathan Hurley
>
>