You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by "Sijie Guo (JIRA)" <ji...@apache.org> on 2017/05/25 01:37:04 UTC
[jira] [Commented] (BOOKKEEPER-1021) Improve the merge script to
handle github reviews api
[ https://issues.apache.org/jira/browse/BOOKKEEPER-1021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16024009#comment-16024009 ]
Sijie Guo commented on BOOKKEEPER-1021:
---------------------------------------
[~eolivelli] I think this is fixed, right?
> Improve the merge script to handle github reviews api
> -----------------------------------------------------
>
> Key: BOOKKEEPER-1021
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-1021
> Project: Bookkeeper
> Issue Type: Bug
> Components: build
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.5.0
>
>
> Current script doesn't handle the new reviews API.
> We need to improve the merge script to handle the new review API.
> https://developer.github.com/v3/pulls/reviews/
> We can do similar thing like what DistributedLog is doing.
> https://github.com/apache/incubator-distributedlog/blob/master/scripts/dev/dl-merge-pr.py
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)