You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/03/12 08:15:48 UTC
[GitHub] [iotdb] JackieTien97 opened a new pull request #2819: [To Vector] Finish the tsfile read module
JackieTien97 opened a new pull request #2819:
URL: https://github.com/apache/iotdb/pull/2819
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] wangchao316 commented on a change in pull request #2819: [To Vector] Finish the tsfile read module
Posted by GitBox <gi...@apache.org>.
wangchao316 commented on a change in pull request #2819:
URL: https://github.com/apache/iotdb/pull/2819#discussion_r592990432
##########
File path: tsfile/src/test/java/org/apache/iotdb/tsfile/write/writer/VectorChunkWriterImplTest.java
##########
@@ -138,7 +142,11 @@ public void testWrite2() {
assertEquals((byte) (0x80 | MetaMarker.CHUNK_HEADER), ReadWriteIOUtils.readByte(buffer));
assertEquals("s1.time", ReadWriteIOUtils.readVarIntString(buffer));
assertEquals(362, ReadWriteForEncodingUtils.readUnsignedVarInt(buffer));
+<<<<<<< HEAD
+ assertEquals(TSDataType.VECTOR.serialize(), ReadWriteIOUtils.readByte(buffer));
Review comment:
this have a conflicting
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] JackieTien97 merged pull request #2819: [To Vector] Finish the tsfile read module
Posted by GitBox <gi...@apache.org>.
JackieTien97 merged pull request #2819:
URL: https://github.com/apache/iotdb/pull/2819
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org