You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/12/19 06:27:39 UTC
[GitHub] [pulsar] Shoothzj opened a new pull request #13395: Fix log numbber incorrect on pulsar metadata
Shoothzj opened a new pull request #13395:
URL: https://github.com/apache/pulsar/pull/13395
### Modifications
Fix log numbber incorrect on pulsar metadata
### Documentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?
- [x] `no-need-doc`
Simple changes, no need doc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on a change in pull request #13395: Fix log numbber incorrect on pulsar metadata
Posted by GitBox <gi...@apache.org>.
yuruguo commented on a change in pull request #13395:
URL: https://github.com/apache/pulsar/pull/13395#discussion_r771927706
##########
File path: pulsar-metadata/src/main/java/org/apache/pulsar/metadata/bookkeeper/PulsarLedgerIdGenerator.java
##########
@@ -226,7 +226,7 @@ private String formatHalfId(int i) {
// delete the znode for id generation
store.delete(stat.getPath(), Optional.empty()).
exceptionally(ex -> {
- log.warn("Exception during deleting node for id generation : {}", ex);
+ log.warn("Exception during deleting node for id generation: ", ex);
Review comment:
Is there no need to add `{}` here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on a change in pull request #13395: Fix log numbber incorrect on pulsar metadata
Posted by GitBox <gi...@apache.org>.
yuruguo commented on a change in pull request #13395:
URL: https://github.com/apache/pulsar/pull/13395#discussion_r771927714
##########
File path: pulsar-metadata/src/main/java/org/apache/pulsar/metadata/bookkeeper/PulsarLedgerIdGenerator.java
##########
@@ -95,7 +95,7 @@ public void generateLedgerId(BookkeeperInternalCallbacks.GenericCallback<Long> g
// delete the znode for id generation
store.delete(stat.getPath(), Optional.empty()).
exceptionally(ex -> {
- log.warn("Exception during deleting node for id generation : {}", ex);
+ log.warn("Exception during deleting node for id generation: ", ex);
Review comment:
Is there no need to add `{}` here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #13395: Fix log numbber incorrect on pulsar metadata
Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #13395:
URL: https://github.com/apache/pulsar/pull/13395
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Shoothzj commented on pull request #13395: Fix log numbber incorrect on pulsar metadata
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on pull request #13395:
URL: https://github.com/apache/pulsar/pull/13395#issuecomment-997352458
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on a change in pull request #13395: Fix log numbber incorrect on pulsar metadata
Posted by GitBox <gi...@apache.org>.
yuruguo commented on a change in pull request #13395:
URL: https://github.com/apache/pulsar/pull/13395#discussion_r771927714
##########
File path: pulsar-metadata/src/main/java/org/apache/pulsar/metadata/bookkeeper/PulsarLedgerIdGenerator.java
##########
@@ -95,7 +95,7 @@ public void generateLedgerId(BookkeeperInternalCallbacks.GenericCallback<Long> g
// delete the znode for id generation
store.delete(stat.getPath(), Optional.empty()).
exceptionally(ex -> {
- log.warn("Exception during deleting node for id generation : {}", ex);
+ log.warn("Exception during deleting node for id generation: ", ex);
Review comment:
Is there no need to add `{}` here?
##########
File path: pulsar-metadata/src/main/java/org/apache/pulsar/metadata/bookkeeper/PulsarLedgerIdGenerator.java
##########
@@ -226,7 +226,7 @@ private String formatHalfId(int i) {
// delete the znode for id generation
store.delete(stat.getPath(), Optional.empty()).
exceptionally(ex -> {
- log.warn("Exception during deleting node for id generation : {}", ex);
+ log.warn("Exception during deleting node for id generation: ", ex);
Review comment:
same as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on a change in pull request #13395: Fix log numbber incorrect on pulsar metadata
Posted by GitBox <gi...@apache.org>.
yuruguo commented on a change in pull request #13395:
URL: https://github.com/apache/pulsar/pull/13395#discussion_r771927706
##########
File path: pulsar-metadata/src/main/java/org/apache/pulsar/metadata/bookkeeper/PulsarLedgerIdGenerator.java
##########
@@ -226,7 +226,7 @@ private String formatHalfId(int i) {
// delete the znode for id generation
store.delete(stat.getPath(), Optional.empty()).
exceptionally(ex -> {
- log.warn("Exception during deleting node for id generation : {}", ex);
+ log.warn("Exception during deleting node for id generation: ", ex);
Review comment:
Is there no need to add `{}` here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org