You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/06/18 21:06:19 UTC
[GitHub] [beam] fernando-wizeline opened a new pull request #15039: [BEAM-10913] - Post-commit github actions status
fernando-wizeline opened a new pull request #15039:
URL: https://github.com/apache/beam/pull/15039
Added a new script that populates a postgresql table with status of the Java and Python GitHub Actions.
The data in that table is in turn consumed by a Grafana json file to display the aforementioned status of each testing job within the Java and Python GAs.
The goal is to have more data that will allow us to discern among failing and flaky tests.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
`ValidatesRunner` compliance status (on master branch)
--------------------------------------------------------
<table>
<thead>
<tr>
<th>Lang</th>
<th>ULR</th>
<th>Dataflow</th>
<th>Flink</th>
<th>Samza</th>
<th>Spark</th>
<th>Twister2</th>
</tr>
</thead>
<tbody>
<tr>
<td>Go</td>
<td>---</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/badge/icon">
</a>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/badge/icon">
</a>
</td>
<td>---</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/badge/icon">
</a>
</td>
<td>---</td>
</tr>
<tr>
<td>Java</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_ULR/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_ULR/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/badge/icon?subject=V1">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Streaming/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Streaming/lastCompletedBuild/badge/icon?subject=V1+Streaming">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/badge/icon?subject=V1+Java+11">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_VR_Dataflow_V2/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_VR_Dataflow_V2/lastCompletedBuild/badge/icon?subject=V2">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_VR_Dataflow_V2_Streaming/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_VR_Dataflow_V2_Streaming/lastCompletedBuild/badge/icon?subject=V2+Streaming">
</a><br>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/badge/icon?subject=Java+8">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/badge/icon?subject=Java+11">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/badge/icon?subject=Portable">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/badge/icon?subject=Portable+Streaming">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/badge/icon">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Samza/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Samza/lastCompletedBuild/badge/icon?subject=Portable">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/badge/icon">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/badge/icon?subject=Portable">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/badge/icon?subject=Structured+Streaming">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Twister2/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Twister2/lastCompletedBuild/badge/icon">
</a>
</td>
</tr>
<tr>
<td>Python</td>
<td>---</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/badge/icon?subject=V1">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/badge/icon?subject=V2">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/badge/icon?subject=ValCont">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Python_PVR_Flink_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Python_PVR_Flink_Cron/lastCompletedBuild/badge/icon?subject=Portable">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/badge/icon">
</a>
</td>
<td>---</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/badge/icon">
</a>
</td>
<td>---</td>
</tr>
<tr>
<td>XLang</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Dataflow/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Dataflow/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/badge/icon">
</a>
</td>
<td>---</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/badge/icon">
</a>
</td>
<td>---</td>
</tr>
</tbody>
</table>
Examples testing status on various runners
--------------------------------------------------------
<table>
<thead>
<tr>
<th>Lang</th>
<th>ULR</th>
<th>Dataflow</th>
<th>Flink</th>
<th>Samza</th>
<th>Spark</th>
<th>Twister2</th>
</tr>
</thead>
<tbody>
<tr>
<td>Go</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
</tr>
<tr>
<td>Java</td>
<td>---</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Java_Examples_Dataflow_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Java_Examples_Dataflow_Cron/lastCompletedBuild/badge/icon?subject=V1">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Java_Examples_Dataflow_Java11_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Java_Examples_Dataflow_Java11_Cron/lastCompletedBuild/badge/icon?subject=V1+Java11">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_Examples_Dataflow_V2/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_Examples_Dataflow_V2/lastCompletedBuild/badge/icon?subject=V2">
</a><br>
</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
</tr>
<tr>
<td>Python</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
</tr>
<tr>
<td>XLang</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
</tr>
</tbody>
</table>
Post-Commit SDK/Transform Integration Tests Status (on master branch)
------------------------------------------------------------------------------------------------
<table>
<thead>
<tr>
<th>Go</th>
<th>Java</th>
<th>Python</th>
</tr>
</thead>
<tbody>
<tr>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/badge/icon?subject=3.6">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/badge/icon?subject=3.7">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Python38/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Python38/lastCompletedBuild/badge/icon?subject=3.8">
</a>
</td>
</tr>
</tbody>
</table>
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
<table>
<thead>
<tr>
<th>---</th>
<th>Java</th>
<th>Python</th>
<th>Go</th>
<th>Website</th>
<th>Whitespace</th>
<th>Typescript</th>
</tr>
</thead>
<tbody>
<tr>
<td>Non-portable</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/badge/icon">
</a><br>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/badge/icon?subject=Tests">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/badge/icon?subject=Lint">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_PythonDocker_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_PythonDocker_Cron/badge/icon?subject=Docker">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_PythonDocs_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_PythonDocs_Cron/badge/icon?subject=Docs">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Whitespace_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Whitespace_Cron/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Typescript_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Typescript_Cron/lastCompletedBuild/badge/icon">
</a>
</td>
</tr>
<tr>
<td>Portable</td>
<td>---</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_GoPortable_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_GoPortable_Cron/lastCompletedBuild/badge/icon">
</a>
</td>
<td>---</td>
<td>---</td>
<td>---</td>
</tr>
</tbody>
</table>
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #15039: [BEAM-10913] - Post-commit github actions status
Posted by GitBox <gi...@apache.org>.
pabloem commented on pull request #15039:
URL: https://github.com/apache/beam/pull/15039#issuecomment-871728599
Sorry about the delay! Looking...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kileys commented on pull request #15039: [BEAM-10913] - Post-commit github actions status
Posted by GitBox <gi...@apache.org>.
kileys commented on pull request #15039:
URL: https://github.com/apache/beam/pull/15039#issuecomment-866256664
@pabloem could you take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tysonjh commented on a change in pull request #15039: [BEAM-10913] - Post-commit github actions status
Posted by GitBox <gi...@apache.org>.
tysonjh commented on a change in pull request #15039:
URL: https://github.com/apache/beam/pull/15039#discussion_r665572870
##########
File path: .test-infra/metrics/sync/github/sync_github_actions.py
##########
@@ -0,0 +1,157 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+'''
+This module queries GitHub to collect pre-commit GitHub Actions metrics and put them in
+PostgreSQL.
+'''
+import sys
+import time
+import psycopg2
+import datetime
+import argparse
+
+# Instructions to run this directly from the command line.
+parser = argparse.ArgumentParser(description='Saves status of GitHub Actions jobs into a postgresql database.')
+parser.add_argument('job_name', help='Name of the job to be saved.')
+parser.add_argument('status', help='Whether or not the job succeeded or was skipped.', choices=['success', 'failure', 'skipped'])
+parser.add_argument('workflow_id', help='Used to access the objects of the current thread of execution.')
+parser.add_argument('DB_HOST', help='IP address of the postgresql DB instance.')
+parser.add_argument('DB_PORT', help='Port to connect to at the destination IP. Usually 5432 or 5433.')
+parser.add_argument('DB_NAME', help='Name of the DB to use.')
+parser.add_argument('DB_USER_NAME', help='User with permission to connect, create tables, and upsert into them.')
+parser.add_argument('DB_PASSWORD', help='Password for the given user.')
+parser.parse_args()
+
+
+# Keeping this as reference for localhost debug
+# Fetching docker host machine ip for testing purposes.
+# Actual host should be used for production.
+def findDockerNetworkIP():
+ '''Utilizes ip tool to find docker network IP'''
+ import subprocess
+ cmd_out = subprocess.check_output(["ip", "route", "show"]).decode("utf-8")
+ return cmd_out.split(" ")[2]
+
+
+#DB_HOST = findDockerNetworkIP()
+
+GH_PRS_TABLE_NAME = 'gh_actions_metrics'
+
+GH_PRS_CREATE_TABLE_QUERY = f"""
+ create table {GH_PRS_TABLE_NAME} (
+ ga_id serial NOT NULL PRIMARY KEY,
+ job_name varchar NOT NULL,
+ status varchar NOT NULL,
+ workflow_id varchar NOT NULL,
+ workflow_url varchar NOT NULL,
+ executed_ts timestamp NOT NULL
+ )
+ """
+
+def initDBConnection():
+ '''Opens connection to postgresql DB, as configured via global variables.'''
+
+ DB_HOST = sys.argv[4]
+ DB_PORT = sys.argv[5]
+ DB_NAME = sys.argv[6]
+ DB_USER_NAME = sys.argv[7]
+ DB_PASSWORD = sys.argv[8]
+
+ conn = None
+ while not conn:
Review comment:
Should this fail after some number of attempts instead of looping forever?
##########
File path: .test-infra/metrics/sync/github/sync_github_actions.py
##########
@@ -0,0 +1,157 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+'''
+This module queries GitHub to collect pre-commit GitHub Actions metrics and put them in
+PostgreSQL.
+'''
+import sys
+import time
+import psycopg2
+import datetime
+import argparse
+
+# Instructions to run this directly from the command line.
+parser = argparse.ArgumentParser(description='Saves status of GitHub Actions jobs into a postgresql database.')
+parser.add_argument('job_name', help='Name of the job to be saved.')
+parser.add_argument('status', help='Whether or not the job succeeded or was skipped.', choices=['success', 'failure', 'skipped'])
+parser.add_argument('workflow_id', help='Used to access the objects of the current thread of execution.')
+parser.add_argument('DB_HOST', help='IP address of the postgresql DB instance.')
+parser.add_argument('DB_PORT', help='Port to connect to at the destination IP. Usually 5432 or 5433.')
+parser.add_argument('DB_NAME', help='Name of the DB to use.')
+parser.add_argument('DB_USER_NAME', help='User with permission to connect, create tables, and upsert into them.')
+parser.add_argument('DB_PASSWORD', help='Password for the given user.')
+parser.parse_args()
+
+
+# Keeping this as reference for localhost debug
+# Fetching docker host machine ip for testing purposes.
+# Actual host should be used for production.
+def findDockerNetworkIP():
+ '''Utilizes ip tool to find docker network IP'''
+ import subprocess
+ cmd_out = subprocess.check_output(["ip", "route", "show"]).decode("utf-8")
+ return cmd_out.split(" ")[2]
+
+
+#DB_HOST = findDockerNetworkIP()
+
+GH_PRS_TABLE_NAME = 'gh_actions_metrics'
+
+GH_PRS_CREATE_TABLE_QUERY = f"""
+ create table {GH_PRS_TABLE_NAME} (
+ ga_id serial NOT NULL PRIMARY KEY,
+ job_name varchar NOT NULL,
+ status varchar NOT NULL,
+ workflow_id varchar NOT NULL,
+ workflow_url varchar NOT NULL,
+ executed_ts timestamp NOT NULL
+ )
+ """
+
+def initDBConnection():
+ '''Opens connection to postgresql DB, as configured via global variables.'''
+
+ DB_HOST = sys.argv[4]
+ DB_PORT = sys.argv[5]
+ DB_NAME = sys.argv[6]
+ DB_USER_NAME = sys.argv[7]
+ DB_PASSWORD = sys.argv[8]
+
+ conn = None
+ while not conn:
+ try:
+ conn = psycopg2.connect(
+ f"dbname='{DB_NAME}' user='{DB_USER_NAME}' host='{DB_HOST}'"
+ f" port='{DB_PORT}' password='{DB_PASSWORD}'")
+ except:
+ print('Failed to connect to DB; retrying in one minute')
+ sys.stdout.flush()
+ time.sleep(60)
+ return conn
+
+def tableExists(cursor, tableName):
+ '''Checks the existense of table.'''
+ cursor.execute(f"select * from information_schema.tables"
+ f" where table_name='{tableName}';")
+ return bool(cursor.rowcount)
+
+def initDbTablesIfNeeded():
+ '''Creates and initializes DB tables required for script to work.'''
+ connection = initDBConnection()
+ cursor = connection.cursor()
+
+ buildsTableExists = tableExists(cursor, GH_PRS_TABLE_NAME)
+ print('PRs table %s exists? %s' % (GH_PRS_TABLE_NAME, buildsTableExists))
+ if not buildsTableExists:
+ print('Creating table')
+ cursor.execute(GH_PRS_CREATE_TABLE_QUERY)
+ if not bool(cursor.rowcount):
+ raise Exception(f"Failed to create table {GH_PRS_TABLE_NAME}")
+ cursor.close()
+ connection.commit()
+
Review comment:
Delete empty line?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] fernando-wizeline commented on a change in pull request #15039: [BEAM-10913] - Post-commit github actions status
Posted by GitBox <gi...@apache.org>.
fernando-wizeline commented on a change in pull request #15039:
URL: https://github.com/apache/beam/pull/15039#discussion_r662483296
##########
File path: .test-infra/metrics/sync/github/sync_github_actions.py
##########
@@ -0,0 +1,142 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+'''
+This module queries GitHub to collect pre-commit GitHub Actions metrics and put them in
+PostgreSQL.
+'''
+import sys
+import time
+import psycopg2
+import datetime
+
+# Keeping this as reference for localhost debug
+# Fetching docker host machine ip for testing purposes.
+# Actual host should be used for production.
+def findDockerNetworkIP():
+ '''Utilizes ip tool to find docker network IP'''
+ import subprocess
+ cmd_out = subprocess.check_output(["ip", "route", "show"]).decode("utf-8")
+ return cmd_out.split(" ")[2]
+
+
+#DB_HOST = findDockerNetworkIP()
+
+GH_PRS_TABLE_NAME = 'gh_actions_metrics'
+
+GH_PRS_CREATE_TABLE_QUERY = f"""
+ create table {GH_PRS_TABLE_NAME} (
+ ga_id serial NOT NULL PRIMARY KEY,
+ job_name varchar NOT NULL,
+ status varchar NOT NULL,
+ workflow_id varchar NOT NULL,
+ workflow_url varchar NOT NULL,
+ executed_ts timestamp NOT NULL
+ )
+ """
+
+def initDBConnection():
+ '''Opens connection to postgresql DB, as configured via global variables.'''
+
+ DB_HOST = sys.argv[4]
+ DB_PORT = sys.argv[5]
+ DB_NAME = sys.argv[6]
+ DB_USER_NAME = sys.argv[7]
+ DB_PASSWORD = sys.argv[8]
+
+ conn = None
+ while not conn:
+ try:
+ conn = psycopg2.connect(
+ f"dbname='{DB_NAME}' user='{DB_USER_NAME}' host='{DB_HOST}'"
+ f" port='{DB_PORT}' password='{DB_PASSWORD}'")
+ except:
+ print('Failed to connect to DB; retrying in one hour')
+ sys.stdout.flush()
+ time.sleep(3600)
+ return conn
+
+def tableExists(cursor, tableName):
+ '''Checks the existense of table.'''
+ cursor.execute(f"select * from information_schema.tables"
+ f" where table_name='{tableName}';")
+ return bool(cursor.rowcount)
+
+def initDbTablesIfNeeded():
+ '''Creates and initializes DB tables required for script to work.'''
+ connection = initDBConnection()
+ cursor = connection.cursor()
+
+ buildsTableExists = tableExists(cursor, GH_PRS_TABLE_NAME)
+ print('PRs table exists', buildsTableExists)
+ if not buildsTableExists:
+ cursor.execute(GH_PRS_CREATE_TABLE_QUERY)
+ if not bool(cursor.rowcount):
+ raise Exception(f"Failed to create table {GH_PRS_TABLE_NAME}")
+ cursor.close()
+ connection.commit()
+
+ connection.close()
+
+def insertIntoTable(cursor, values):
+ insertRowQuery = f'''INSERT INTO {GH_PRS_TABLE_NAME}
+ (job_name,
+ status,
+ workflow_id,
+ workflow_url,
+ executed_ts)
+ VALUES
+ (%s, %s, %s, %s, %s)
+ '''
+ cursor.execute(insertRowQuery, values)
+
+def fetchNewData():
+ '''
+ Main workhorse method. Fetches data from GitHub and puts it in metrics table.
+ '''
+
+ job_name = sys.argv[1]
+ status = sys.argv[2]
+ workflow_id = sys.argv[3]
+ workflow_url = f'''https://github.com/fernando-wizeline/beam/actions/runs/{workflow_id}''' #TODO: remove reference to personal repository
+ executed_ts = datetime.datetime.now()
+ row_values = [job_name, status, workflow_id, workflow_url, executed_ts]
Review comment:
> is this method fetching any data from github? I think it is not , right?
The method itself it is not pulling the data, but rather upserting it after the data was feed to it.
I'll update the comment and name of the method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tysonjh commented on pull request #15039: [BEAM-10913] - Post-commit github actions status
Posted by GitBox <gi...@apache.org>.
tysonjh commented on pull request #15039:
URL: https://github.com/apache/beam/pull/15039#issuecomment-876766885
R: @y1chi would you have a look (and merge when you're comfortable)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] fernando-wizeline commented on pull request #15039: [BEAM-10913] - Post-commit github actions status
Posted by GitBox <gi...@apache.org>.
fernando-wizeline commented on pull request #15039:
URL: https://github.com/apache/beam/pull/15039#issuecomment-865198726
Hi @tysonjh @kileys!
I was wondering whom to ask for a review of this PR.
I did a search through a couple OWNERS file, but most of the people mentioned in those don't appear to be really active.
Thanks for the help!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on a change in pull request #15039: [BEAM-10913] - Post-commit github actions status
Posted by GitBox <gi...@apache.org>.
pabloem commented on a change in pull request #15039:
URL: https://github.com/apache/beam/pull/15039#discussion_r661878274
##########
File path: .test-infra/metrics/sync/github/sync_github_actions.py
##########
@@ -0,0 +1,142 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+'''
+This module queries GitHub to collect pre-commit GitHub Actions metrics and put them in
+PostgreSQL.
+'''
+import sys
+import time
+import psycopg2
+import datetime
+
+# Keeping this as reference for localhost debug
+# Fetching docker host machine ip for testing purposes.
+# Actual host should be used for production.
+def findDockerNetworkIP():
+ '''Utilizes ip tool to find docker network IP'''
+ import subprocess
+ cmd_out = subprocess.check_output(["ip", "route", "show"]).decode("utf-8")
+ return cmd_out.split(" ")[2]
+
+
+#DB_HOST = findDockerNetworkIP()
+
+GH_PRS_TABLE_NAME = 'gh_actions_metrics'
+
+GH_PRS_CREATE_TABLE_QUERY = f"""
+ create table {GH_PRS_TABLE_NAME} (
+ ga_id serial NOT NULL PRIMARY KEY,
+ job_name varchar NOT NULL,
+ status varchar NOT NULL,
+ workflow_id varchar NOT NULL,
+ workflow_url varchar NOT NULL,
+ executed_ts timestamp NOT NULL
+ )
+ """
+
+def initDBConnection():
+ '''Opens connection to postgresql DB, as configured via global variables.'''
+
+ DB_HOST = sys.argv[4]
+ DB_PORT = sys.argv[5]
+ DB_NAME = sys.argv[6]
+ DB_USER_NAME = sys.argv[7]
+ DB_PASSWORD = sys.argv[8]
+
+ conn = None
+ while not conn:
+ try:
+ conn = psycopg2.connect(
+ f"dbname='{DB_NAME}' user='{DB_USER_NAME}' host='{DB_HOST}'"
+ f" port='{DB_PORT}' password='{DB_PASSWORD}'")
+ except:
+ print('Failed to connect to DB; retrying in one hour')
+ sys.stdout.flush()
+ time.sleep(3600)
Review comment:
1 hour sounds like a very long wait. Maybe something shorter? maybe even 1 or 2 minutes? WDYT?
##########
File path: .test-infra/metrics/sync/github/sync_github_actions.py
##########
@@ -0,0 +1,142 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+'''
+This module queries GitHub to collect pre-commit GitHub Actions metrics and put them in
+PostgreSQL.
+'''
+import sys
+import time
+import psycopg2
+import datetime
+
+# Keeping this as reference for localhost debug
+# Fetching docker host machine ip for testing purposes.
+# Actual host should be used for production.
+def findDockerNetworkIP():
+ '''Utilizes ip tool to find docker network IP'''
+ import subprocess
+ cmd_out = subprocess.check_output(["ip", "route", "show"]).decode("utf-8")
+ return cmd_out.split(" ")[2]
+
+
+#DB_HOST = findDockerNetworkIP()
+
+GH_PRS_TABLE_NAME = 'gh_actions_metrics'
+
+GH_PRS_CREATE_TABLE_QUERY = f"""
+ create table {GH_PRS_TABLE_NAME} (
+ ga_id serial NOT NULL PRIMARY KEY,
+ job_name varchar NOT NULL,
+ status varchar NOT NULL,
+ workflow_id varchar NOT NULL,
+ workflow_url varchar NOT NULL,
+ executed_ts timestamp NOT NULL
+ )
+ """
+
+def initDBConnection():
+ '''Opens connection to postgresql DB, as configured via global variables.'''
+
+ DB_HOST = sys.argv[4]
+ DB_PORT = sys.argv[5]
+ DB_NAME = sys.argv[6]
+ DB_USER_NAME = sys.argv[7]
+ DB_PASSWORD = sys.argv[8]
+
+ conn = None
+ while not conn:
+ try:
+ conn = psycopg2.connect(
+ f"dbname='{DB_NAME}' user='{DB_USER_NAME}' host='{DB_HOST}'"
+ f" port='{DB_PORT}' password='{DB_PASSWORD}'")
+ except:
+ print('Failed to connect to DB; retrying in one hour')
+ sys.stdout.flush()
+ time.sleep(3600)
+ return conn
+
+def tableExists(cursor, tableName):
+ '''Checks the existense of table.'''
+ cursor.execute(f"select * from information_schema.tables"
+ f" where table_name='{tableName}';")
+ return bool(cursor.rowcount)
+
+def initDbTablesIfNeeded():
+ '''Creates and initializes DB tables required for script to work.'''
+ connection = initDBConnection()
+ cursor = connection.cursor()
+
+ buildsTableExists = tableExists(cursor, GH_PRS_TABLE_NAME)
+ print('PRs table exists', buildsTableExists)
+ if not buildsTableExists:
+ cursor.execute(GH_PRS_CREATE_TABLE_QUERY)
+ if not bool(cursor.rowcount):
+ raise Exception(f"Failed to create table {GH_PRS_TABLE_NAME}")
+ cursor.close()
+ connection.commit()
+
+ connection.close()
+
+def insertIntoTable(cursor, values):
+ insertRowQuery = f'''INSERT INTO {GH_PRS_TABLE_NAME}
+ (job_name,
+ status,
+ workflow_id,
+ workflow_url,
+ executed_ts)
+ VALUES
+ (%s, %s, %s, %s, %s)
+ '''
+ cursor.execute(insertRowQuery, values)
+
+def fetchNewData():
+ '''
+ Main workhorse method. Fetches data from GitHub and puts it in metrics table.
+ '''
+
+ job_name = sys.argv[1]
+ status = sys.argv[2]
+ workflow_id = sys.argv[3]
+ workflow_url = f'''https://github.com/fernando-wizeline/beam/actions/runs/{workflow_id}''' #TODO: remove reference to personal repository
+ executed_ts = datetime.datetime.now()
+ row_values = [job_name, status, workflow_id, workflow_url, executed_ts]
Review comment:
is this method fetching any data from github? I think it is not , right?
##########
File path: .test-infra/metrics/sync/github/sync_github_actions.py
##########
@@ -0,0 +1,142 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+'''
+This module queries GitHub to collect pre-commit GitHub Actions metrics and put them in
+PostgreSQL.
+'''
+import sys
+import time
+import psycopg2
+import datetime
+
+# Keeping this as reference for localhost debug
+# Fetching docker host machine ip for testing purposes.
+# Actual host should be used for production.
+def findDockerNetworkIP():
+ '''Utilizes ip tool to find docker network IP'''
+ import subprocess
+ cmd_out = subprocess.check_output(["ip", "route", "show"]).decode("utf-8")
+ return cmd_out.split(" ")[2]
+
+
+#DB_HOST = findDockerNetworkIP()
+
+GH_PRS_TABLE_NAME = 'gh_actions_metrics'
+
+GH_PRS_CREATE_TABLE_QUERY = f"""
+ create table {GH_PRS_TABLE_NAME} (
+ ga_id serial NOT NULL PRIMARY KEY,
+ job_name varchar NOT NULL,
+ status varchar NOT NULL,
+ workflow_id varchar NOT NULL,
+ workflow_url varchar NOT NULL,
+ executed_ts timestamp NOT NULL
+ )
+ """
+
+def initDBConnection():
+ '''Opens connection to postgresql DB, as configured via global variables.'''
+
+ DB_HOST = sys.argv[4]
+ DB_PORT = sys.argv[5]
+ DB_NAME = sys.argv[6]
+ DB_USER_NAME = sys.argv[7]
+ DB_PASSWORD = sys.argv[8]
+
+ conn = None
+ while not conn:
+ try:
+ conn = psycopg2.connect(
+ f"dbname='{DB_NAME}' user='{DB_USER_NAME}' host='{DB_HOST}'"
+ f" port='{DB_PORT}' password='{DB_PASSWORD}'")
+ except:
+ print('Failed to connect to DB; retrying in one hour')
+ sys.stdout.flush()
+ time.sleep(3600)
+ return conn
+
+def tableExists(cursor, tableName):
+ '''Checks the existense of table.'''
+ cursor.execute(f"select * from information_schema.tables"
+ f" where table_name='{tableName}';")
+ return bool(cursor.rowcount)
+
+def initDbTablesIfNeeded():
+ '''Creates and initializes DB tables required for script to work.'''
+ connection = initDBConnection()
+ cursor = connection.cursor()
+
+ buildsTableExists = tableExists(cursor, GH_PRS_TABLE_NAME)
+ print('PRs table exists', buildsTableExists)
+ if not buildsTableExists:
+ cursor.execute(GH_PRS_CREATE_TABLE_QUERY)
+ if not bool(cursor.rowcount):
+ raise Exception(f"Failed to create table {GH_PRS_TABLE_NAME}")
+ cursor.close()
+ connection.commit()
+
+ connection.close()
+
+def insertIntoTable(cursor, values):
+ insertRowQuery = f'''INSERT INTO {GH_PRS_TABLE_NAME}
+ (job_name,
+ status,
+ workflow_id,
+ workflow_url,
+ executed_ts)
+ VALUES
+ (%s, %s, %s, %s, %s)
+ '''
+ cursor.execute(insertRowQuery, values)
+
+def fetchNewData():
+ '''
+ Main workhorse method. Fetches data from GitHub and puts it in metrics table.
+ '''
+
+ job_name = sys.argv[1]
+ status = sys.argv[2]
+ workflow_id = sys.argv[3]
+ workflow_url = f'''https://github.com/fernando-wizeline/beam/actions/runs/{workflow_id}''' #TODO: remove reference to personal repository
Review comment:
should this be fixed?
##########
File path: .test-infra/metrics/sync/github/sync_github_actions.py
##########
@@ -0,0 +1,142 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+'''
+This module queries GitHub to collect pre-commit GitHub Actions metrics and put them in
+PostgreSQL.
+'''
+import sys
+import time
+import psycopg2
+import datetime
+
+# Keeping this as reference for localhost debug
+# Fetching docker host machine ip for testing purposes.
+# Actual host should be used for production.
+def findDockerNetworkIP():
+ '''Utilizes ip tool to find docker network IP'''
+ import subprocess
+ cmd_out = subprocess.check_output(["ip", "route", "show"]).decode("utf-8")
+ return cmd_out.split(" ")[2]
+
+
+#DB_HOST = findDockerNetworkIP()
+
+GH_PRS_TABLE_NAME = 'gh_actions_metrics'
+
+GH_PRS_CREATE_TABLE_QUERY = f"""
+ create table {GH_PRS_TABLE_NAME} (
+ ga_id serial NOT NULL PRIMARY KEY,
+ job_name varchar NOT NULL,
+ status varchar NOT NULL,
+ workflow_id varchar NOT NULL,
+ workflow_url varchar NOT NULL,
+ executed_ts timestamp NOT NULL
+ )
+ """
+
+def initDBConnection():
+ '''Opens connection to postgresql DB, as configured via global variables.'''
+
+ DB_HOST = sys.argv[4]
+ DB_PORT = sys.argv[5]
+ DB_NAME = sys.argv[6]
+ DB_USER_NAME = sys.argv[7]
+ DB_PASSWORD = sys.argv[8]
+
+ conn = None
+ while not conn:
+ try:
+ conn = psycopg2.connect(
+ f"dbname='{DB_NAME}' user='{DB_USER_NAME}' host='{DB_HOST}'"
+ f" port='{DB_PORT}' password='{DB_PASSWORD}'")
+ except:
+ print('Failed to connect to DB; retrying in one hour')
+ sys.stdout.flush()
+ time.sleep(3600)
+ return conn
+
+def tableExists(cursor, tableName):
+ '''Checks the existense of table.'''
+ cursor.execute(f"select * from information_schema.tables"
+ f" where table_name='{tableName}';")
+ return bool(cursor.rowcount)
+
+def initDbTablesIfNeeded():
+ '''Creates and initializes DB tables required for script to work.'''
+ connection = initDBConnection()
+ cursor = connection.cursor()
+
+ buildsTableExists = tableExists(cursor, GH_PRS_TABLE_NAME)
+ print('PRs table exists', buildsTableExists)
Review comment:
maybe this print statement should be made more clear? Perhaps `'PR table %s exist' % 'does' if buildsTableExists else 'does not'`? WDYT?
Any other option works, but I just want to make the message more clear
##########
File path: .test-infra/metrics/sync/github/sync_github_actions.py
##########
@@ -0,0 +1,142 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+'''
+This module queries GitHub to collect pre-commit GitHub Actions metrics and put them in
+PostgreSQL.
+'''
+import sys
+import time
+import psycopg2
+import datetime
+
+# Keeping this as reference for localhost debug
+# Fetching docker host machine ip for testing purposes.
+# Actual host should be used for production.
+def findDockerNetworkIP():
+ '''Utilizes ip tool to find docker network IP'''
+ import subprocess
+ cmd_out = subprocess.check_output(["ip", "route", "show"]).decode("utf-8")
+ return cmd_out.split(" ")[2]
+
+
+#DB_HOST = findDockerNetworkIP()
+
+GH_PRS_TABLE_NAME = 'gh_actions_metrics'
+
+GH_PRS_CREATE_TABLE_QUERY = f"""
+ create table {GH_PRS_TABLE_NAME} (
+ ga_id serial NOT NULL PRIMARY KEY,
+ job_name varchar NOT NULL,
+ status varchar NOT NULL,
+ workflow_id varchar NOT NULL,
+ workflow_url varchar NOT NULL,
+ executed_ts timestamp NOT NULL
+ )
+ """
+
+def initDBConnection():
+ '''Opens connection to postgresql DB, as configured via global variables.'''
+
+ DB_HOST = sys.argv[4]
+ DB_PORT = sys.argv[5]
+ DB_NAME = sys.argv[6]
+ DB_USER_NAME = sys.argv[7]
+ DB_PASSWORD = sys.argv[8]
Review comment:
Please document the order of arguments at the top of the file.
A good idea may be to use [Python's `argparse`](https://docs.python.org/3/library/argparse.html), which helps document and manages error messages as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] fernando-wizeline commented on pull request #15039: [BEAM-10913] - Post-commit github actions status
Posted by GitBox <gi...@apache.org>.
fernando-wizeline commented on pull request #15039:
URL: https://github.com/apache/beam/pull/15039#issuecomment-882685982
> Any updates on this PR?
Hi Tyson!
This is ready for review. If no further suggestions are made, I'd say it is ready for merging; but, since the DB connection information is now being picked up from the OS (Dockerized or otherwise), the step that saves the status of the jobs will fail.
If we want to decouple this from the runners migration to GKE, I'd say we should, for the moment, get the DB connection info from GitHub secrets and once the migration to GKE is completed we can switch back to obtaining the DB info from the OS.
What are your thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] y1chi commented on pull request #15039: [BEAM-10913] - Post-commit github actions status
Posted by GitBox <gi...@apache.org>.
y1chi commented on pull request #15039:
URL: https://github.com/apache/beam/pull/15039#issuecomment-876781852
@fernando-wizeline Could you squash the commits into one to avoid redundant commit history?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] fernando-wizeline commented on pull request #15039: [BEAM-10913] - Post-commit github actions status
Posted by GitBox <gi...@apache.org>.
fernando-wizeline commented on pull request #15039:
URL: https://github.com/apache/beam/pull/15039#issuecomment-882685982
> Any updates on this PR?
Hi Tyson!
This is ready for review. If no further suggestions are made, I'd say it is ready for merging; but, since the DB connection information is now being picked up from the OS (Dockerized or otherwise), the step that saves the status of the jobs will fail.
If we want to decouple this from the runners migration to GKE, I'd say we should, for the moment, get the DB connection info from GitHub secrets and once the migration to GKE is completed we can switch back to obtaining the DB info from the OS.
What are your thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] fernando-wizeline edited a comment on pull request #15039: [BEAM-10913] - Post-commit github actions status
Posted by GitBox <gi...@apache.org>.
fernando-wizeline edited a comment on pull request #15039:
URL: https://github.com/apache/beam/pull/15039#issuecomment-876795325
> @fernando-wizeline Could you squash the commits into one to avoid redundant commit history?
Thanks @y1chi, will do!
I just noticed I need to make a small change, can you please hold off with the merge for a bit?
Thanks again!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kileys commented on pull request #15039: [BEAM-10913] - Post-commit github actions status
Posted by GitBox <gi...@apache.org>.
kileys commented on pull request #15039:
URL: https://github.com/apache/beam/pull/15039#issuecomment-883735490
AFAIK, we haven't found anyone with the permissions to add the Github secrets. Unless the work to migrate the runners to GKE is going to take a long time, it might be simpler to wait until that work is completed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] fernando-wizeline closed pull request #15039: [BEAM-10913] - Post-commit github actions status
Posted by GitBox <gi...@apache.org>.
fernando-wizeline closed pull request #15039:
URL: https://github.com/apache/beam/pull/15039
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] fernando-wizeline commented on pull request #15039: [BEAM-10913] - Post-commit github actions status
Posted by GitBox <gi...@apache.org>.
fernando-wizeline commented on pull request #15039:
URL: https://github.com/apache/beam/pull/15039#issuecomment-882685982
> Any updates on this PR?
Hi Tyson!
This is ready for review. If no further suggestions are made, I'd say it is ready for merging; but, since the DB connection information is now being picked up from the OS (Dockerized or otherwise), the step that saves the status of the jobs will fail.
If we want to decouple this from the runners migration to GKE, I'd say we should, for the moment, get the DB connection info from GitHub secrets and once the migration to GKE is completed we can switch back to obtaining the DB info from the OS.
What are your thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] fernando-wizeline commented on pull request #15039: [BEAM-10913] - Post-commit github actions status
Posted by GitBox <gi...@apache.org>.
fernando-wizeline commented on pull request #15039:
URL: https://github.com/apache/beam/pull/15039#issuecomment-875835458
> Could you describe briefly how this whole solution will execute? I'm interested in a sequence of steps in bullet form to understand how the whole solution will work.
Of course!
These are the steps that are taking place.
1.- The GA Runners execute a given job as described in the yaml file.
2.- Once all the testing steps get executed, the last step to be executed is the "Status Report" one
3.- This step has access to all the info of the job it resides in, i.e. status, os matrix, and workflow id.
4.- This "Report" step also has access to the DB information via secrets.
5.- All this job data in turn gets feed into the sync_github_actions.py script
6.- The script basically takes that information and stores them in a postgresql table.
7.- With the data saved in the table, the Grafana config file (github-actions-commit_tests.json) reads it and displays a table graph.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tysonjh commented on pull request #15039: [BEAM-10913] - Post-commit github actions status
Posted by GitBox <gi...@apache.org>.
tysonjh commented on pull request #15039:
URL: https://github.com/apache/beam/pull/15039#issuecomment-882672231
Any updates on this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tysonjh commented on pull request #15039: [BEAM-10913] - Post-commit github actions status
Posted by GitBox <gi...@apache.org>.
tysonjh commented on pull request #15039:
URL: https://github.com/apache/beam/pull/15039#issuecomment-882672231
Any updates on this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tysonjh commented on pull request #15039: [BEAM-10913] - Post-commit github actions status
Posted by GitBox <gi...@apache.org>.
tysonjh commented on pull request #15039:
URL: https://github.com/apache/beam/pull/15039#issuecomment-882672231
Any updates on this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kileys commented on a change in pull request #15039: [BEAM-10913] - Post-commit github actions status
Posted by GitBox <gi...@apache.org>.
kileys commented on a change in pull request #15039:
URL: https://github.com/apache/beam/pull/15039#discussion_r666470875
##########
File path: .test-infra/metrics/sync/github/sync_github_actions.py
##########
@@ -0,0 +1,166 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
Review comment:
Missing second half of the license here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] fernando-wizeline commented on a change in pull request #15039: [BEAM-10913] - Post-commit github actions status
Posted by GitBox <gi...@apache.org>.
fernando-wizeline commented on a change in pull request #15039:
URL: https://github.com/apache/beam/pull/15039#discussion_r666492195
##########
File path: .test-infra/metrics/sync/github/sync_github_actions.py
##########
@@ -0,0 +1,166 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
Review comment:
> Missing second half of the license here
Thanks for the heads up Kiley!
I just noticed that all the python scripts under that folder also lack the second half of the license.
I'll go ahead and add the missing half to them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] fernando-wizeline commented on pull request #15039: [BEAM-10913] - Post-commit github actions status
Posted by GitBox <gi...@apache.org>.
fernando-wizeline commented on pull request #15039:
URL: https://github.com/apache/beam/pull/15039#issuecomment-872402065
> Sorry about the delay! Looking...
Thanks for the feedback Pablo!
Taking a look right now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aaltay commented on pull request #15039: [BEAM-10913] - Post-commit github actions status
Posted by GitBox <gi...@apache.org>.
aaltay commented on pull request #15039:
URL: https://github.com/apache/beam/pull/15039#issuecomment-902840950
What is the next step on this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] fernando-wizeline removed a comment on pull request #15039: [BEAM-10913] - Post-commit github actions status
Posted by GitBox <gi...@apache.org>.
fernando-wizeline removed a comment on pull request #15039:
URL: https://github.com/apache/beam/pull/15039#issuecomment-872402065
> Sorry about the delay! Looking...
Thanks for the feedback Pablo!
Taking a look right now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] fernando-wizeline commented on pull request #15039: [BEAM-10913] - Post-commit github actions status
Posted by GitBox <gi...@apache.org>.
fernando-wizeline commented on pull request #15039:
URL: https://github.com/apache/beam/pull/15039#issuecomment-876795325
> @fernando-wizeline Could you squash the commits into one to avoid redundant commit history?
Thanks @y1chi, will do!
I just noticed I need to make a small change, can you please with the merge for a bit?
Thanks again!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #15039: [BEAM-10913] - Post-commit github actions status
Posted by GitBox <gi...@apache.org>.
pabloem commented on pull request #15039:
URL: https://github.com/apache/beam/pull/15039#issuecomment-891273085
hi all! I'm back from vacation and happy to help where necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] fernando-wizeline commented on a change in pull request #15039: [BEAM-10913] - Post-commit github actions status
Posted by GitBox <gi...@apache.org>.
fernando-wizeline commented on a change in pull request #15039:
URL: https://github.com/apache/beam/pull/15039#discussion_r662483296
##########
File path: .test-infra/metrics/sync/github/sync_github_actions.py
##########
@@ -0,0 +1,142 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+'''
+This module queries GitHub to collect pre-commit GitHub Actions metrics and put them in
+PostgreSQL.
+'''
+import sys
+import time
+import psycopg2
+import datetime
+
+# Keeping this as reference for localhost debug
+# Fetching docker host machine ip for testing purposes.
+# Actual host should be used for production.
+def findDockerNetworkIP():
+ '''Utilizes ip tool to find docker network IP'''
+ import subprocess
+ cmd_out = subprocess.check_output(["ip", "route", "show"]).decode("utf-8")
+ return cmd_out.split(" ")[2]
+
+
+#DB_HOST = findDockerNetworkIP()
+
+GH_PRS_TABLE_NAME = 'gh_actions_metrics'
+
+GH_PRS_CREATE_TABLE_QUERY = f"""
+ create table {GH_PRS_TABLE_NAME} (
+ ga_id serial NOT NULL PRIMARY KEY,
+ job_name varchar NOT NULL,
+ status varchar NOT NULL,
+ workflow_id varchar NOT NULL,
+ workflow_url varchar NOT NULL,
+ executed_ts timestamp NOT NULL
+ )
+ """
+
+def initDBConnection():
+ '''Opens connection to postgresql DB, as configured via global variables.'''
+
+ DB_HOST = sys.argv[4]
+ DB_PORT = sys.argv[5]
+ DB_NAME = sys.argv[6]
+ DB_USER_NAME = sys.argv[7]
+ DB_PASSWORD = sys.argv[8]
+
+ conn = None
+ while not conn:
+ try:
+ conn = psycopg2.connect(
+ f"dbname='{DB_NAME}' user='{DB_USER_NAME}' host='{DB_HOST}'"
+ f" port='{DB_PORT}' password='{DB_PASSWORD}'")
+ except:
+ print('Failed to connect to DB; retrying in one hour')
+ sys.stdout.flush()
+ time.sleep(3600)
+ return conn
+
+def tableExists(cursor, tableName):
+ '''Checks the existense of table.'''
+ cursor.execute(f"select * from information_schema.tables"
+ f" where table_name='{tableName}';")
+ return bool(cursor.rowcount)
+
+def initDbTablesIfNeeded():
+ '''Creates and initializes DB tables required for script to work.'''
+ connection = initDBConnection()
+ cursor = connection.cursor()
+
+ buildsTableExists = tableExists(cursor, GH_PRS_TABLE_NAME)
+ print('PRs table exists', buildsTableExists)
+ if not buildsTableExists:
+ cursor.execute(GH_PRS_CREATE_TABLE_QUERY)
+ if not bool(cursor.rowcount):
+ raise Exception(f"Failed to create table {GH_PRS_TABLE_NAME}")
+ cursor.close()
+ connection.commit()
+
+ connection.close()
+
+def insertIntoTable(cursor, values):
+ insertRowQuery = f'''INSERT INTO {GH_PRS_TABLE_NAME}
+ (job_name,
+ status,
+ workflow_id,
+ workflow_url,
+ executed_ts)
+ VALUES
+ (%s, %s, %s, %s, %s)
+ '''
+ cursor.execute(insertRowQuery, values)
+
+def fetchNewData():
+ '''
+ Main workhorse method. Fetches data from GitHub and puts it in metrics table.
+ '''
+
+ job_name = sys.argv[1]
+ status = sys.argv[2]
+ workflow_id = sys.argv[3]
+ workflow_url = f'''https://github.com/fernando-wizeline/beam/actions/runs/{workflow_id}''' #TODO: remove reference to personal repository
+ executed_ts = datetime.datetime.now()
+ row_values = [job_name, status, workflow_id, workflow_url, executed_ts]
Review comment:
> is this method fetching any data from github? I think it is not , right?
The method itself it is not pulling the data, but rather upserting it after the data was fed to it.
I'll update the comment and name of the method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] fernando-wizeline commented on pull request #15039: [BEAM-10913] - Post-commit github actions status
Posted by GitBox <gi...@apache.org>.
fernando-wizeline commented on pull request #15039:
URL: https://github.com/apache/beam/pull/15039#issuecomment-891166499
> > We need
> > > AFAIK, we haven't found anyone with the permissions to add the Github secrets. Unless the work to migrate the runners to GKE is going to take a long time, it might be simpler to wait until that work is completed.
> >
> >
> > You'll need to contact Apache INFRA to add secrets. IIRC that involves creating a ticket, providing the secret KEYs (not the secrets themselves) and then they'll provide instructions for sending the secrets themselves.
>
> Did this work? If it did not please reach out to dev list for help.
Hi, Ahmet! Haven't opened the ticket yet; I'm configuring the GKE cluster first and once that is done, I will follow up with the secrets. Will reach out to the dev list if I get stucked.
Thanks for the help, Ahmet!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] fernando-wizeline commented on pull request #15039: [BEAM-10913] - Post-commit github actions status
Posted by GitBox <gi...@apache.org>.
fernando-wizeline commented on pull request #15039:
URL: https://github.com/apache/beam/pull/15039#issuecomment-874929893
Hi @pabloem !
Performed the suggested changes.
Please let me know if there's something else I need to add.
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] fernando-wizeline commented on pull request #15039: [BEAM-10913] - Post-commit github actions status
Posted by GitBox <gi...@apache.org>.
fernando-wizeline commented on pull request #15039:
URL: https://github.com/apache/beam/pull/15039#issuecomment-904082282
> What is the next step on this PR?
Hi Ahmet!
I'm gonna close this PR for the time being. Need to go back to the drawing board.
I'll open a new PR just containing the github actions status monitoring and then a different one containing the GKE migration changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tysonjh commented on pull request #15039: [BEAM-10913] - Post-commit github actions status
Posted by GitBox <gi...@apache.org>.
tysonjh commented on pull request #15039:
URL: https://github.com/apache/beam/pull/15039#issuecomment-885190896
We need
> AFAIK, we haven't found anyone with the permissions to add the Github secrets. Unless the work to migrate the runners to GKE is going to take a long time, it might be simpler to wait until that work is completed.
You'll need to contact Apache INFRA to add secrets. IIRC that involves creating a ticket, providing the secret KEYs (not the secrets themselves) and then they'll provide instructions for sending the secrets themselves.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] fernando-wizeline commented on pull request #15039: [BEAM-10913] - Post-commit github actions status
Posted by GitBox <gi...@apache.org>.
fernando-wizeline commented on pull request #15039:
URL: https://github.com/apache/beam/pull/15039#issuecomment-865198726
Hi @tysonjh @kileys!
I was wondering whom to ask for a review of this PR.
I did a search through a couple OWNERS file, but most of the people mentioned in those don't appear to be really active.
Thanks for the help!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aaltay commented on pull request #15039: [BEAM-10913] - Post-commit github actions status
Posted by GitBox <gi...@apache.org>.
aaltay commented on pull request #15039:
URL: https://github.com/apache/beam/pull/15039#issuecomment-889569049
> We need
>
> > AFAIK, we haven't found anyone with the permissions to add the Github secrets. Unless the work to migrate the runners to GKE is going to take a long time, it might be simpler to wait until that work is completed.
>
> You'll need to contact Apache INFRA to add secrets. IIRC that involves creating a ticket, providing the secret KEYs (not the secrets themselves) and then they'll provide instructions for sending the secrets themselves.
Did this work? If it did not please reach out to dev list for help.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] fernando-wizeline commented on pull request #15039: [BEAM-10913] - Post-commit github actions status
Posted by GitBox <gi...@apache.org>.
fernando-wizeline commented on pull request #15039:
URL: https://github.com/apache/beam/pull/15039#issuecomment-872401663
> Sorry about the delay! Looking...
Thanks for the feedback Pablo!
Taking a look right now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org