[GitHub] drboyer commented on issue #20658: [SPARK-23488][python] Add missing catalog methods to python API

[GitBox <gi...@apache.org>]

drboyer commented on issue #20658: [SPARK-23488][python] Add missing catalog methods to python API
URL: https://github.com/apache/spark/pull/20658#issuecomment-450569538
 
 
   Hi, sorry for the delay and thanks all for taking a second look at this. I just rebased to latest master and pushed some related changes, like setting the `@since` decorator to `3.0`.
   
   I see I never opened the Jira about the breaking `Function` change mentioned in @HyukjinKwon's [comment](https://github.com/apache/spark/pull/20658#issuecomment-368561007). I've opened [SPARK-26505](https://issues.apache.org/jira/browse/SPARK-26505) about this. Should that change be made in a separate PR or should we re-add that change here, now that it's targeted for inclusion in 3.0?
   
   From my perspective, the only other thing discussed in previous reviews was potentially improving the docstrings for catalog functions, including the ones added here, to include :param:/:return: annotations.  Should I go ahead and make those changes too? Is there anything else needed before this can be merged?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org