You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by Himanshu-it <gi...@git.apache.org> on 2018/03/06 13:46:24 UTC
[GitHub] nifi pull request #2514: NIFI-4938 Upgraded org.eclipse.paho.client.mqttv3 d...
GitHub user Himanshu-it opened a pull request:
https://github.com/apache/nifi/pull/2514
NIFI-4938 Upgraded org.eclipse.paho.client.mqttv3 dependency version …
Off line buffering for mqtt messages will now be supported with the version of paho client being updated to 1.2.0 from 1.0.2 .
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Himanshu-it/nifi NIFI-4938-Offline-mqtt-message-buffering-support-for-mqtt-processors-with-QoS1-and-Qos2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2514.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2514
----
commit 49f1410c7bf61edfe9a9fb19f566743590f50636
Author: himanshu <hm...@...>
Date: 2018-03-06T13:38:50Z
NIFI-4938 Upgraded org.eclipse.paho.client.mqttv3 dependency version to 1.2.0
----
---
[GitHub] nifi pull request #2514: NIFI-4938 Upgraded org.eclipse.paho.client.mqttv3 d...
Posted by Himanshu-it <gi...@git.apache.org>.
Github user Himanshu-it commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2514#discussion_r172748974
--- Diff: nifi-nar-bundles/nifi-mqtt-bundle/nifi-mqtt-processors/src/test/java/org/apache/nifi/processors/mqtt/common/MqttTestClient.java ---
@@ -17,16 +17,7 @@
package org.apache.nifi.processors.mqtt.common;
-import org.eclipse.paho.client.mqttv3.IMqttClient;
-import org.eclipse.paho.client.mqttv3.IMqttDeliveryToken;
-import org.eclipse.paho.client.mqttv3.IMqttToken;
-import org.eclipse.paho.client.mqttv3.MqttCallback;
-import org.eclipse.paho.client.mqttv3.MqttConnectOptions;
-import org.eclipse.paho.client.mqttv3.MqttException;
-import org.eclipse.paho.client.mqttv3.MqttMessage;
-import org.eclipse.paho.client.mqttv3.MqttPersistenceException;
-import org.eclipse.paho.client.mqttv3.MqttSecurityException;
-import org.eclipse.paho.client.mqttv3.MqttTopic;
+import org.eclipse.paho.client.mqttv3.*;
--- End diff --
sure thanks.
---
[GitHub] nifi pull request #2514: NIFI-4938 Upgraded org.eclipse.paho.client.mqttv3 d...
Posted by joewitt <gi...@git.apache.org>.
Github user joewitt commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2514#discussion_r172519579
--- Diff: nifi-nar-bundles/nifi-mqtt-bundle/nifi-mqtt-processors/src/test/java/org/apache/nifi/processors/mqtt/common/MqttTestClient.java ---
@@ -17,16 +17,7 @@
package org.apache.nifi.processors.mqtt.common;
-import org.eclipse.paho.client.mqttv3.IMqttClient;
-import org.eclipse.paho.client.mqttv3.IMqttDeliveryToken;
-import org.eclipse.paho.client.mqttv3.IMqttToken;
-import org.eclipse.paho.client.mqttv3.MqttCallback;
-import org.eclipse.paho.client.mqttv3.MqttConnectOptions;
-import org.eclipse.paho.client.mqttv3.MqttException;
-import org.eclipse.paho.client.mqttv3.MqttMessage;
-import org.eclipse.paho.client.mqttv3.MqttPersistenceException;
-import org.eclipse.paho.client.mqttv3.MqttSecurityException;
-import org.eclipse.paho.client.mqttv3.MqttTopic;
+import org.eclipse.paho.client.mqttv3.*;
--- End diff --
please avoid star import. Be sure to run
mvn clean install -Pcontrib-check
---
[GitHub] nifi pull request #2514: NIFI-4938 Upgraded org.eclipse.paho.client.mqttv3 d...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/2514
---
[GitHub] nifi issue #2514: NIFI-4938 Upgraded org.eclipse.paho.client.mqttv3 dependen...
Posted by Himanshu-it <gi...@git.apache.org>.
Github user Himanshu-it commented on the issue:
https://github.com/apache/nifi/pull/2514
continuous integration with travis falis with concurrent modification error in "TestFileSystemRepository.testMinimalArchiveCleanupIntervalHonoredAndLogged:151", but locally I have build with
mvn clean install and mvn -Pcontrib-check clean install, both are working fine. Any pointers on this.
---
[GitHub] nifi issue #2514: NIFI-4938 Upgraded org.eclipse.paho.client.mqttv3 dependen...
Posted by pvillard31 <gi...@git.apache.org>.
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2514
LGTM. Checked release notes of the updated library and dependency tree to ensure there is nothing wrong here. I've only one request: to also update the version in the notice files (in this bundle and the assembly one). Will take care of this while merging. Thanks!
---