You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Di Li <di...@ca.ibm.com> on 2017/01/26 18:28:18 UTC
Review Request 55990: AMBARI-19728: Custom command name rendered
incorrectly
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55990/
-----------------------------------------------------------
Review request for Ambari and Sangeeta Ravindran.
Bugs: AMBARI-19728
https://issues.apache.org/jira/browse/AMBARI-19728
Repository: ambari
Description
-------
I have a custom command in my Hive service called update-hcat-conf. On the UI, it's shown with label "Update HCat Client Client Conf". It should have been displayed as "Update HCat Client Conf"
Diffs
-----
ambari-web/app/utils/helper.js 927f8a6
ambari-web/test/utils/helper_test.js b438a7a
Diff: https://reviews.apache.org/r/55990/diff/
Testing
-------
unit tests
patch a trunk cluster with the change, the label showed up on the UI correctly
Thanks,
Di Li
Re: Review Request 55990: AMBARI-19728: Custom command name rendered
incorrectly
Posted by Sangeeta Ravindran <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55990/#review163148
-----------------------------------------------------------
Ship it!
Ship It!
- Sangeeta Ravindran
On Jan. 26, 2017, 6:28 p.m., Di Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55990/
> -----------------------------------------------------------
>
> (Updated Jan. 26, 2017, 6:28 p.m.)
>
>
> Review request for Ambari and Sangeeta Ravindran.
>
>
> Bugs: AMBARI-19728
> https://issues.apache.org/jira/browse/AMBARI-19728
>
>
> Repository: ambari
>
>
> Description
> -------
>
> I have a custom command in my Hive service called update-hcat-conf. On the UI, it's shown with label "Update HCat Client Client Conf". It should have been displayed as "Update HCat Client Conf"
>
>
> Diffs
> -----
>
> ambari-web/app/utils/helper.js 927f8a6
> ambari-web/test/utils/helper_test.js b438a7a
>
> Diff: https://reviews.apache.org/r/55990/diff/
>
>
> Testing
> -------
>
> unit tests
> patch a trunk cluster with the change, the label showed up on the UI correctly
>
>
> Thanks,
>
> Di Li
>
>