[GitHub] [parquet-mr] sunchao commented on a diff in pull request #983: WiP: parquet to use openfile api and some other performance enhancements

[GitBox <gi...@apache.org>]

sunchao commented on code in PR #983:
URL: https://github.com/apache/parquet-mr/pull/983#discussion_r940452465


##########
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/util/HadoopInputFile.java:
##########
@@ -66,7 +68,13 @@ public long getLength() {
 
   @Override
   public SeekableInputStream newStream() throws IOException {
-    return HadoopStreams.wrap(fs.open(stat.getPath()));
+    // specify random access always
+    return HadoopStreams.wrap(
+      awaitFuture(fs.openFile(stat.getPath())

Review Comment:
   hmm won't this cause issue if the actual hadoop version is below 3.3? I think we may need to check the version through `VersionInfo.getVersion`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org