You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by "Leif Hedstrom (JIRA)" <ji...@apache.org> on 2010/09/28 06:54:33 UTC
[jira] Created: (TS-471) We don't "set" Content-Length: header
properly for > 2^31 values
We don't "set" Content-Length: header properly for > 2^31 values
----------------------------------------------------------------
Key: TS-471
URL: https://issues.apache.org/jira/browse/TS-471
Project: Traffic Server
Issue Type: Bug
Components: HTTP
Reporter: Leif Hedstrom
Fix For: 2.1.4
If the body is a chunked encoded response, and we convert it to have a content-length header, I believe we don't produce a correct value for the CL: header. The code is
inline void
MIMEHdr::set_content_length(int64 value)
{
value_set_int(MIME_FIELD_CONTENT_LENGTH, MIME_LEN_CONTENT_LENGTH, value);
}
but I'm fairly certain we want the equivalent of value_set_int64() (which doesn't exist). Marking this one for v2.1.4, since it most likely doesn't work properly for > 2^31 chunked encoded objects.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (TS-471) We don't "set" Content-Length: header properly for > 2^31 values
Posted by Leif Hedstrom <zw...@apache.org>.
Should be fixed on trunk now.
Sent from my iPad
On Sep 30, 2010, at 10:34 PM, "Zhao Yongming (JIRA)" <ji...@apache.org> wrote:
>
> [ https://issues.apache.org/jira/browse/TS-471?
>
[jira] Commented: (TS-471) We don't "set" Content-Length: header
properly for > 2^31 values
Posted by "Zhao Yongming (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12916775#action_12916775 ]
Zhao Yongming commented on TS-471:
----------------------------------
I have some problem during trunk testing:
FATAL: MIME.cc:3206: failed assert `val > 0 && val < 100000`
/usr/bin/traffic_server - STACK TRACE:
/usr/bin/traffic_server(ink_fatal_va+0xab)[0x6cc8eb]
/usr/bin/traffic_server(ink_fatal+0x86)[0x6cca16]
/usr/bin/traffic_server(_ink_assert+0x92)[0x6cb662]
/usr/bin/traffic_server(_Z16format_small_intPcim+0x114)[0x5e87b4]
/usr/bin/traffic_server(_Z26mime_field_value_set_int64P7HdrHeapP11MIMEHdrImplP9MIMEFieldx+0x31)[0x5e2e31]
/usr/bin/traffic_server(_ZN19HttpTransactHeaders39insert_time_and_age_headers_in_responseElllP7HTTPHdrS1_+0xa2)[0x5690f2]
/usr/bin/traffic_server(_ZN12HttpTransact14build_responseEPNS_5StateEP7HTTPHdrS3_11HTTPVersion10HTTPStatusPKc+0x92d)[0x5557cd]
/usr/bin/traffic_server(_ZN12HttpTransact49handle_cache_operation_on_forward_server_responseEPNS_5StateE+0x956)[0x55d2c6]
/usr/bin/traffic_server(_ZN12HttpTransact37handle_forward_server_connection_openEPNS_5StateE+0x4a4)[0x55e804]
/usr/bin/traffic_server(_ZN12HttpTransact27handle_response_from_serverEPNS_5StateE+0x1b1)[0x55ed51]
/usr/bin/traffic_server(_ZN12HttpTransact14HandleResponseEPNS_5StateE+0x2c8)[0x567b28]
/usr/bin/traffic_server(_ZN6HttpSM32call_transact_and_set_next_stateEPFvPN12HttpTransact5StateEE+0xc5)[0x5241c5]
/usr/bin/traffic_server(_ZN6HttpSM33state_read_server_response_headerEiPv+0x5a4)[0x535844]
/usr/bin/traffic_server(_ZN6HttpSM12main_handlerEiPv+0x183)[0x536e53]
/usr/bin/traffic_server[0x69fe14]
/usr/bin/traffic_server[0x6a40d7]
/usr/bin/traffic_server(_ZN10NetHandler12mainNetEventEiP5Event+0x2e8)[0x69b7d8]
/usr/bin/traffic_server(_ZN7EThread13process_eventEP5Eventi+0x121)[0x6c45e1]
/usr/bin/traffic_server(
> We don't "set" Content-Length: header properly for > 2^31 values
> ----------------------------------------------------------------
>
> Key: TS-471
> URL: https://issues.apache.org/jira/browse/TS-471
> Project: Traffic Server
> Issue Type: Bug
> Components: HTTP
> Reporter: Leif Hedstrom
> Assignee: Leif Hedstrom
> Fix For: 2.1.4
>
>
> If the body is a chunked encoded response, and we convert it to have a content-length header, I believe we don't produce a correct value for the CL: header. The code is
> inline void
> MIMEHdr::set_content_length(int64 value)
> {
> value_set_int(MIME_FIELD_CONTENT_LENGTH, MIME_LEN_CONTENT_LENGTH, value);
> }
> but I'm fairly certain we want the equivalent of value_set_int64() (which doesn't exist). Marking this one for v2.1.4, since it most likely doesn't work properly for > 2^31 chunked encoded objects.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (TS-471) We don't "set" Content-Length: header
properly for > 2^31 values
Posted by "Leif Hedstrom (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leif Hedstrom reassigned TS-471:
--------------------------------
Assignee: Leif Hedstrom
> We don't "set" Content-Length: header properly for > 2^31 values
> ----------------------------------------------------------------
>
> Key: TS-471
> URL: https://issues.apache.org/jira/browse/TS-471
> Project: Traffic Server
> Issue Type: Bug
> Components: HTTP
> Reporter: Leif Hedstrom
> Assignee: Leif Hedstrom
> Fix For: 2.1.4
>
>
> If the body is a chunked encoded response, and we convert it to have a content-length header, I believe we don't produce a correct value for the CL: header. The code is
> inline void
> MIMEHdr::set_content_length(int64 value)
> {
> value_set_int(MIME_FIELD_CONTENT_LENGTH, MIME_LEN_CONTENT_LENGTH, value);
> }
> but I'm fairly certain we want the equivalent of value_set_int64() (which doesn't exist). Marking this one for v2.1.4, since it most likely doesn't work properly for > 2^31 chunked encoded objects.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (TS-471) We don't "set" Content-Length: header
properly for > 2^31 values
Posted by "Leif Hedstrom (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leif Hedstrom resolved TS-471.
------------------------------
Resolution: Fixed
> We don't "set" Content-Length: header properly for > 2^31 values
> ----------------------------------------------------------------
>
> Key: TS-471
> URL: https://issues.apache.org/jira/browse/TS-471
> Project: Traffic Server
> Issue Type: Bug
> Components: HTTP
> Reporter: Leif Hedstrom
> Assignee: Leif Hedstrom
> Fix For: 2.1.4
>
>
> If the body is a chunked encoded response, and we convert it to have a content-length header, I believe we don't produce a correct value for the CL: header. The code is
> inline void
> MIMEHdr::set_content_length(int64 value)
> {
> value_set_int(MIME_FIELD_CONTENT_LENGTH, MIME_LEN_CONTENT_LENGTH, value);
> }
> but I'm fairly certain we want the equivalent of value_set_int64() (which doesn't exist). Marking this one for v2.1.4, since it most likely doesn't work properly for > 2^31 chunked encoded objects.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.